#187 - Editor has no path-duplicate or 'Save as New' / 'Save Copy' — saving an in-progress edit clobbers the original design, and the user has no way to fork a design - Mark/Kimi_Agent_Brother_10_Digitizing_App - cyguin git: Adlerian Hierarchical Self-Actualization Syllogism

Mark commented

2026-10-03 23:46:39 +00:00

Owner

Finding

src/components/editor/Editor.tsx's handleSave (line 810) calls saveDesignToGallery with loadedDesignIdRef.current. The result has updated: true when an existing design was updated, updated: false when a new one was created (per saveDesign.ts:138-197).

The Editor UI offers only one Save button. There is no "Save Copy" / "Save As" / "Save as New" option. Once a user loads a design from the gallery, edits it, and clicks Save, the gallery row is updated in place. The original is gone unless they explicitly duplicated it before opening the Editor.

The Gallery has a per-card Duplicate action (per RightClickMenu), but a user who:

Loads a design
Wants to experiment ("let me try a different colorway")
Hits Save

...now has a single design with the experiment, not the original + the experiment.

Path-level duplicate is also missing: the Editor has no "duplicate this path" operation. A user with a 30-node path they want to mirror or offset has to redraw it. grep -rn 'duplicate.*path\|clonePath' src/ returns 0 hits.

Where

Editor save: src/pages/Editor.tsx:810-840
No Save Copy UI: src/components/editor/EditorHeader.tsx (single Save button at line 220)
No path duplicate: src/components/editor/EditorRightPanel.tsx (no Duplicate button next to Add Node / Delete)
No path duplicate reducer: grep -n 'DUPLICATE_PATH\|CLONE_PATH' src/components/editor/ returns 0 hits

Suggested fix shape

Save Copy in the Editor's Save button (turn it into a dropdown):

<div className="relative">
  <button onClick={onSave} data-testid="editor-save">Save</button>
  <button onClick={() => setShowSaveMenu(true)} data-testid="editor-save-menu">▾</button>
  {showSaveMenu && (
    <DropdownMenu>
      <MenuItem onClick={handleSave}>Save (update existing)</MenuItem>
      <MenuItem onClick={handleSaveAsNew}>Save as New...</MenuItem>
    </DropdownMenu>
  )}
</div>

handleSaveAsNew clears loadedDesignIdRef.current (or sets it to null) before calling saveDesignToGallery, forcing a new row.

Path duplicate in the Editor's right panel — add a "Duplicate Path" button next to "Add Node" / "Delete" that:

<button onClick={onDuplicateSelectedPath}>
  Duplicate Path
</button>

onDuplicateSelectedPath dispatches a DUPLICATE_PATH action that clones the path (deep copy nodes, new id, offset by +10px), inserts it into the paths array, and pushes history so undo works.

Severity

Medium. The "Save Copy" is a common pattern in any editor; users expect it. Path duplicate is lower priority.

Discovered by

Gap analysis (2026-10-02) of editor save semantics.

#150 (closed) — Editor Save button. Lands the basic Save; Save Copy is the natural follow-up.
#152 (closed) — Gallery → Editor bridge carries loadedDesignId. Same bridge; same place to add a "save as new" handler.
#179 (closed) — Gallery multi-select. Bulk duplicate via the Gallery is a separate but related story.

## Finding `src/components/editor/Editor.tsx`'s `handleSave` (line 810) calls `saveDesignToGallery` with `loadedDesignIdRef.current`. The result has `updated: true` when an existing design was updated, `updated: false` when a new one was created (per `saveDesign.ts:138-197`). The Editor UI offers only one Save button. There is no "Save Copy" / "Save As" / "Save as New" option. Once a user loads a design from the gallery, edits it, and clicks Save, the gallery row is updated in place. The original is gone unless they explicitly duplicated it before opening the Editor. The Gallery has a per-card Duplicate action (per `RightClickMenu`), but a user who: - Loads a design - Wants to experiment ("let me try a different colorway") - Hits Save ...now has a single design with the experiment, not the original + the experiment. Path-level duplicate is also missing: the Editor has no "duplicate this path" operation. A user with a 30-node path they want to mirror or offset has to redraw it. `grep -rn 'duplicate.*path\|clonePath' src/` returns 0 hits. ## Where - Editor save: `src/pages/Editor.tsx:810-840` - No Save Copy UI: `src/components/editor/EditorHeader.tsx` (single Save button at line 220) - No path duplicate: `src/components/editor/EditorRightPanel.tsx` (no Duplicate button next to Add Node / Delete) - No path duplicate reducer: `grep -n 'DUPLICATE_PATH\|CLONE_PATH' src/components/editor/` returns 0 hits ## Suggested fix shape **Save Copy** in the Editor's Save button (turn it into a dropdown): ```tsx <div className="relative"> <button onClick={onSave} data-testid="editor-save">Save</button> <button onClick={() => setShowSaveMenu(true)} data-testid="editor-save-menu">▾</button> {showSaveMenu && ( <DropdownMenu> <MenuItem onClick={handleSave}>Save (update existing)</MenuItem> <MenuItem onClick={handleSaveAsNew}>Save as New...</MenuItem> </DropdownMenu> )} </div> ``` `handleSaveAsNew` clears `loadedDesignIdRef.current` (or sets it to null) before calling `saveDesignToGallery`, forcing a new row. **Path duplicate** in the Editor's right panel — add a "Duplicate Path" button next to "Add Node" / "Delete" that: ```tsx <button onClick={onDuplicateSelectedPath}> Duplicate Path </button> ``` `onDuplicateSelectedPath` dispatches a `DUPLICATE_PATH` action that clones the path (deep copy nodes, new id, offset by +10px), inserts it into the paths array, and pushes history so undo works. ## Severity Medium. The "Save Copy" is a common pattern in any editor; users expect it. Path duplicate is lower priority. ## Discovered by Gap analysis (2026-10-02) of editor save semantics. ## Related - #150 (closed) — Editor Save button. Lands the basic Save; Save Copy is the natural follow-up. - #152 (closed) — Gallery → Editor bridge carries `loadedDesignId`. Same bridge; same place to add a "save as new" handler. - #179 (closed) — Gallery multi-select. Bulk duplicate via the Gallery is a separate but related story.

Mark added the

feature-request

triage-approved

labels

2026-10-03 23:46:39 +00:00

Mark referenced this issue

2026-10-03 23:47:49 +00:00

Editor has no right-click context menu — workspace has 7-item context menu (Select All, Duplicate, Delete, Group, Ungroup, Bring to Front, Send to Back) but editor has nothing #191

Mark referenced this issue

2026-10-03 23:51:18 +00:00

Workspace has no DUPLICATE_OBJECT reducer — context menu shows 'Duplicate' and Ctrl+D shortcut but the action is missing in the workspace; only the editor and gallery have duplicate #200

Mark referenced this issue from a commit

2026-10-03 23:55:28 +00:00

fix(#187): Editor Save split-button + Duplicate Path so in-progress edits can fork without clobbering the original

Mark referenced this issue

2026-10-03 23:59:32 +00:00

Editor has no path split/merge operations — scissors tool cuts a path at one segment but you can't split into two separate paths or merge two selected paths into one #204

Mark referenced this issue

2026-10-03 23:59:32 +00:00

Editor has no path mirror/flip/rotate — no way to reflect a path horizontally, vertically, or rotate around its bounding box center #205

Mark referenced this issue

2026-10-04 00:00:48 +00:00

Editor has no 'reverse path direction' or 'close path' operations — common path ops in any vector editor are missing #209

Mark referenced this issue

2026-10-04 00:00:49 +00:00

Editor has no way to name a path — path list shows generic 'Path 1', 'Path 2' — user with 5+ paths has to identify them by node count, which is fragile #210

Mark referenced this issue

2026-10-04 00:02:07 +00:00

Editor has no 'duplicate path' shortcut — user with 10 mirrored petals must draw each one individually even though the Edit menu has no Duplicate Path entry #213

Mark commented

2026-10-04 00:06:22 +00:00

Author

Owner

Closed by commit 117c193 (origin/main).

fix(#187): Editor Save split-button + Duplicate Path so in-progress edits can fork without clobbering the original.

Save is now a split-button: left half is the existing Save (update loaded gallery row), right caret opens a Radix DropdownMenu with 'Save (update existing)' and 'Save as New...'. The new handler clears loadedDesignIdRef before calling saveDesignToGallery so it always lands on a fresh row, mirroring the Workspace's post-save behaviour. Subsequent Saves also create new rows once the binding is cleared.
Right panel gets a 'Duplicate Path' button between Add Node and Delete. The Editor's handler deep-clones the selected path (new path id, new node ids, +10/+10 mm offset), pushes a history snapshot for Ctrl+Z, and flips isDirty so the #161 beforeunload and #184 Link-confirm prompts both fire.
11 new tests across Editor, EditorHeader, and EditorRightPanel. tsc -b clean, eslint clean. CI run queued on Forgejo (id 7459) but no runner was available during the session — same waiting pattern as #185/#186 in this push storm.

Closes: #187.

Closed by commit 117c193 (origin/main). fix(#187): Editor Save split-button + Duplicate Path so in-progress edits can fork without clobbering the original. - Save is now a split-button: left half is the existing Save (update loaded gallery row), right caret opens a Radix DropdownMenu with 'Save (update existing)' and 'Save as New...'. The new handler clears loadedDesignIdRef before calling saveDesignToGallery so it always lands on a fresh row, mirroring the Workspace's post-save behaviour. Subsequent Saves also create new rows once the binding is cleared. - Right panel gets a 'Duplicate Path' button between Add Node and Delete. The Editor's handler deep-clones the selected path (new path id, new node ids, +10/+10 mm offset), pushes a history snapshot for Ctrl+Z, and flips isDirty so the #161 beforeunload and #184 Link-confirm prompts both fire. - 11 new tests across Editor, EditorHeader, and EditorRightPanel. tsc -b clean, eslint clean. CI run queued on Forgejo (id 7459) but no runner was available during the session — same waiting pattern as #185/#186 in this push storm. Closes: #187.

Mark closed this issue

2026-10-04 00:06:26 +00:00

Mark referenced this issue

2026-10-04 02:13:18 +00:00

Editor has no way to load a different design without navigating back to the gallery — user has 3 designs open in different tabs, wants to switch; can only navigate back to the gallery #228

~~Mark referenced this issue 2026-10-04 02:13:58 +00:00~~

Editor has no 'load a different design' dropdown — user who wants to switch between 3 designs has to navigate Gallery → Editor for each one, losing unsaved work and using 3 browser tabs #231

Mark referenced this issue from a commit

2026-10-04 02:18:32 +00:00

fix(#205): Editor path mirror/flip/rotate around bounding box center

Mark referenced this issue

2026-10-04 02:18:40 +00:00