Mark/Kimi_Agent_Brother_10_Digitizing_App

Fork 0

Editor has no way to name a path — path list shows generic 'Path 1', 'Path 2' — user with 5+ paths has to identify them by node count, which is fragile #210

New issue

Closed

opened 2026-10-04 00:00:49 +00:00 by Mark · 1 comment

Mark commented

2026-10-04 00:00:49 +00:00

Owner

Finding

src/components/editor/EditorRightPanel.tsx:142 renders the path list. Each row displays... let me check. grep -n 'p\.name\|p\.label' src/components/editor/EditorRightPanel.tsx returns 0 matches. The path rows display "Path N" where N is the array index.

A user with 5 paths:

"Path 1, Path 2, Path 3, Path 4, Path 5"
Each has 12 nodes, or 18, or 24
Identifying a specific path requires reading the node count

grep -n 'name:\|name =' src/components/editor/types.ts — the StitchPath type has no name field. The path is identified by id only.

Where

Path list display: src/components/editor/EditorRightPanel.tsx:142-180
StitchPath type: src/components/editor/types.ts (no name field)
No onRenamePath callback: grep -n 'onRenamePath\|renamePath' src/components/editor/ returns 0
Gallery has filename: src/components/gallery/types.ts:18 (Design has filename)

Suggested fix shape

Type change: add name?: string to StitchPath. Default to "Path N" if undefined, where N is the array index + 1.
UI: make the path name editable inline (double-click to rename, like the gallery's DesignCard rename):

{editingPathName ? (
  <input
    value={pathName}
    onChange={(e) => setPathName(e.target.value)}
    onBlur={() => onRenamePath(p.id, pathName.trim()) || setPathName(p.name ?? `Path ${i + 1}`)}
    onKeyDown={(e) => {
      if (e.key === 'Enter') onRenamePath(p.id, pathName.trim());
      if (e.key === 'Escape') setPathName(p.name ?? `Path ${i + 1}`);
    }}
    autoFocus
  />
) : (
  <span onDoubleClick={() => setEditingPathName(true)}>
    {p.name ?? `Path ${i + 1}`}
  </span>
)}

Auto-naming on creation: when handleFinishPath creates a new path from a drawn sequence, give it a meaningful name based on the stitch type: "Satin 1", "Satin 2", "Fill 1", etc. (Next-available-N of the same stitch type). This way the user sees "Satin 3" instead of "Path 7" after drawing 7 satin paths.
Status preservation: the new design saves the path names to the snapshot; loading the design restores the names.

Severity

Low. The user can use node count to identify paths. Power users with many paths name them; without naming it's a frustrating disambiguation problem.

Discovered by

Gap analysis (2026-10-02) of editor path identification.

#187 (open) — Editor duplicate. Duplicating a path should preserve the name (with a " (copy)" suffix).
#204 (open) — Editor split/merge. Splitting creates two new paths that need names.
#205 (open) — Editor mirror/rotate. Transforming a path could optionally rename it ("Left leaf").

## Finding `src/components/editor/EditorRightPanel.tsx:142` renders the path list. Each row displays... let me check. `grep -n 'p\.name\|p\.label' src/components/editor/EditorRightPanel.tsx` returns 0 matches. The path rows display "Path N" where N is the array index. A user with 5 paths: - "Path 1, Path 2, Path 3, Path 4, Path 5" - Each has 12 nodes, or 18, or 24 - Identifying a specific path requires reading the node count `grep -n 'name:\|name =' src/components/editor/types.ts` — the `StitchPath` type has no `name` field. The path is identified by id only. ## Where - Path list display: `src/components/editor/EditorRightPanel.tsx:142-180` - StitchPath type: `src/components/editor/types.ts` (no name field) - No onRenamePath callback: `grep -n 'onRenamePath\|renamePath' src/components/editor/` returns 0 - Gallery has filename: `src/components/gallery/types.ts:18` (Design has filename) ## Suggested fix shape 1. **Type change**: add `name?: string` to `StitchPath`. Default to "Path N" if undefined, where N is the array index + 1. 2. **UI**: make the path name editable inline (double-click to rename, like the gallery's DesignCard rename): ```tsx {editingPathName ? ( <input value={pathName} onChange={(e) => setPathName(e.target.value)} onBlur={() => onRenamePath(p.id, pathName.trim()) || setPathName(p.name ?? `Path ${i + 1}`)} onKeyDown={(e) => { if (e.key === 'Enter') onRenamePath(p.id, pathName.trim()); if (e.key === 'Escape') setPathName(p.name ?? `Path ${i + 1}`); }} autoFocus /> ) : ( <span onDoubleClick={() => setEditingPathName(true)}> {p.name ?? `Path ${i + 1}`} </span> )} ``` 3. **Auto-naming on creation**: when `handleFinishPath` creates a new path from a drawn sequence, give it a meaningful name based on the stitch type: "Satin 1", "Satin 2", "Fill 1", etc. (Next-available-N of the same stitch type). This way the user sees "Satin 3" instead of "Path 7" after drawing 7 satin paths. 4. **Status preservation**: the new design saves the path names to the snapshot; loading the design restores the names. ## Severity Low. The user can use node count to identify paths. Power users with many paths name them; without naming it's a frustrating disambiguation problem. ## Discovered by Gap analysis (2026-10-02) of editor path identification. ## Related - #187 (open) — Editor duplicate. Duplicating a path should preserve the name (with a " (copy)" suffix). - #204 (open) — Editor split/merge. Splitting creates two new paths that need names. - #205 (open) — Editor mirror/rotate. Transforming a path could optionally rename it ("Left leaf").

Mark added the

feature-request

triage-approved

labels

2026-10-04 00:00:49 +00:00

Mark referenced this issue

2026-10-04 00:04:20 +00:00

Workspace right panel's Object List has no per-object rename — user can't name a stitch object (e.g., 'flower' or 'border') so the Object List shows the generated default like 'Object 1' #218

Mark referenced this issue

2026-10-04 02:36:50 +00:00

Editor path list shows generic 'Path 1, Path 2, ...' names and the user can't tell them apart at a glance — Help page documents 'stitch types: satin, fill, running, cross-stitch' but the path list doesn't surface the stitch type visually #244

Mark referenced this issue from a commit

2026-10-04 03:32:38 +00:00

fix(#210): Editor inline path-name rename + stitch-type auto-name

Mark closed this issue

2026-10-04 03:40:34 +00:00

Mark commented

2026-10-04 03:40:37 +00:00

Author

Owner

Shipped in cf9bdaa (fix(#210): Editor inline path-name rename + stitch-type auto-name).

What landed:

Inline rename in the editor Paths section — double-click the label or click the hover-only pencil icon to enter edit mode (Enter/blur commits, Escape reverts, empty/whitespace-only commits rejected). Mirrors the gallery DesignCard pattern.
Auto-name by stitch type on path creation — "Satin 1", "Fill 1" etc. via next-available-N per type. Renamed paths keep their slot; falls back to "Path N" when stitch type is empty.

Local gates green (tsc, lint, 1023 tests pass incl. 22 new for #210, build). CI run 7482 is in waiting state — self-hosted runner queue is backed up with prior cancelled runs; the runner is a substrate issue, not a code issue.

Shipped in cf9bdaa (fix(#210): Editor inline path-name rename + stitch-type auto-name). What landed: - Inline rename in the editor Paths section — double-click the label or click the hover-only pencil icon to enter edit mode (Enter/blur commits, Escape reverts, empty/whitespace-only commits rejected). Mirrors the gallery DesignCard pattern. - Auto-name by stitch type on path creation — "Satin 1", "Fill 1" etc. via next-available-N per type. Renamed paths keep their slot; falls back to "Path N" when stitch type is empty. Local gates green (tsc, lint, 1023 tests pass incl. 22 new for #210, build). CI run 7482 is in waiting state — self-hosted runner queue is backed up with prior cancelled runs; the runner is a substrate issue, not a code issue.

Mark referenced this issue from a commit

2026-10-04 04:26:53 +00:00

feat(#218): Right-panel Object List gets inline per-object rename

Mark referenced this issue

2026-10-04 04:27:00 +00:00

Workspace right panel's Object List has no per-object rename — user can't name a stitch object (e.g., 'flower' or 'border') so the Object List shows the generated default like 'Object 1' #218

Mark referenced this issue from a commit

2026-10-05 01:40:21 +00:00

feat(#327): auto-name paths by shape — 'Satin 1 — Triangle' instead of 'Path N'

Mark referenced this issue

2026-10-05 01:49:00 +00:00

Editor has no 'auto-name' for paths based on shape — user creating a closed polygon gets 'Path 1', a circle gets 'Path 2', no semantic naming, makes the path list harder to navigate #327