Editor has no right-click context menu — workspace has 7-item context menu (Select All, Duplicate, Delete, Group, Ungroup, Bring to Front, Send to Back) but editor has nothing #191

New issue

Closed

opened 2026-10-03 23:47:49 +00:00 by Mark · 1 comment

Mark commented 2026-10-03 23:47:49 +00:00

Owner

Copy link

Finding

The workspace's canvas (src/components/workspace/CanvasArea.tsx:246-365) wires a handleContextMenu that opens a 7-item context menu via <ContextMenu /> (per src/components/workspace/ContextMenu.tsx):

1. Select All (Ctrl+A)
2. Duplicate (Ctrl+D)
3. Delete (Del)
4. Group (Ctrl+G)
5. Ungroup (Ctrl+Shift+G, only when a group member is selected)
6. Bring to Front
7. Send to Back

The editor's canvas (src/components/editor/EditorCanvas.tsx) has no onContextMenu handler. grep -n 'ContextMenu\|onContextMenu' src/components/editor/ returns 0 hits.

A user editing a path in the Editor can't right-click for a quick "Duplicate this path" or "Delete this node" — they have to find the buttons in the right panel or use keyboard shortcuts.

grep -n 'handleDuplicate\|onDuplicate' src/components/editor/ returns 0 hits too — there's no duplicate path action at all (see also #187). The right-click affordance for path operations is missing.

Where

• Workspace context menu: src/components/workspace/ContextMenu.tsx (full 7-item menu)
• Workspace trigger: src/components/workspace/CanvasArea.tsx:365 (onContextMenu={handleContextMenu})
• Editor: src/components/editor/EditorCanvas.tsx (no onContextMenu handler)
• Editor file list: ls src/components/editor/ shows no ContextMenu component

Suggested fix shape

1. Create src/components/editor/EditorContextMenu.tsx with editor-appropriate items:

   • Add Node (when a segment is hovered)
   • Delete Node / Path
   • Duplicate Path
   • Convert Node Type (corner / smooth / symmetric submenu)
   • Path Color (open the color picker from the right panel)
   • Hide / Show Path
   • Fit to View (this path)

2. Wire onContextMenu on the editor canvas. The handler opens the menu with the appropriate items based on:

   • What's under the cursor (a node? a segment? nothing?)
   • The current tool mode (add_node vs. select_nodes vs. draw_path)

3. Plumb the actions through the existing onAddNodeToSelection, onDeleteSelectedNodes, onDuplicateSelectedPath (the latter is a new prop needed for #187).

Severity

Medium. Power users with multi-path designs feel the friction; new users don't notice.

Discovered by

Gap analysis (2026-10-02) of editor right-click affordances.

Related

• #187 (open) — Editor path duplicate. Context menu duplicate is the discoverable entry point.
• #188 (open) — Editor multi-path selection. Context menu items should respect multi-select.

## Finding The workspace's canvas (`src/components/workspace/CanvasArea.tsx:246-365`) wires a `handleContextMenu` that opens a 7-item context menu via `<ContextMenu />` (per `src/components/workspace/ContextMenu.tsx`): 1. Select All (`Ctrl+A`) 2. Duplicate (`Ctrl+D`) 3. Delete (`Del`) 4. Group (`Ctrl+G`) 5. Ungroup (`Ctrl+Shift+G`, only when a group member is selected) 6. Bring to Front 7. Send to Back The editor's canvas (`src/components/editor/EditorCanvas.tsx`) has no `onContextMenu` handler. `grep -n 'ContextMenu\|onContextMenu' src/components/editor/` returns 0 hits. A user editing a path in the Editor can't right-click for a quick "Duplicate this path" or "Delete this node" — they have to find the buttons in the right panel or use keyboard shortcuts. `grep -n 'handleDuplicate\|onDuplicate' src/components/editor/` returns 0 hits too — there's no duplicate path action at all (see also #187). The right-click affordance for path operations is missing. ## Where - Workspace context menu: `src/components/workspace/ContextMenu.tsx` (full 7-item menu) - Workspace trigger: `src/components/workspace/CanvasArea.tsx:365` (`onContextMenu={handleContextMenu}`) - Editor: `src/components/editor/EditorCanvas.tsx` (no onContextMenu handler) - Editor file list: `ls src/components/editor/` shows no ContextMenu component ## Suggested fix shape 1. Create `src/components/editor/EditorContextMenu.tsx` with editor-appropriate items: - Add Node (when a segment is hovered) - Delete Node / Path - Duplicate Path - Convert Node Type (corner / smooth / symmetric submenu) - Path Color (open the color picker from the right panel) - Hide / Show Path - Fit to View (this path) 2. Wire `onContextMenu` on the editor canvas. The handler opens the menu with the appropriate items based on: - What's under the cursor (a node? a segment? nothing?) - The current tool mode (add_node vs. select_nodes vs. draw_path) 3. Plumb the actions through the existing `onAddNodeToSelection`, `onDeleteSelectedNodes`, `onDuplicateSelectedPath` (the latter is a new prop needed for #187). ## Severity Medium. Power users with multi-path designs feel the friction; new users don't notice. ## Discovered by Gap analysis (2026-10-02) of editor right-click affordances. ## Related - #187 (open) — Editor path duplicate. Context menu duplicate is the discoverable entry point. - #188 (open) — Editor multi-path selection. Context menu items should respect multi-select.

Mark added the

feature-request

triage-approved

labels 2026-10-03 23:47:50 +00:00

Mark referenced this issue 2026-10-03 23:51:18 +00:00

Workspace has no DUPLICATE_OBJECT reducer — context menu shows 'Duplicate' and Ctrl+D shortcut but the action is missing in the workspace; only the editor and gallery have duplicate #200

Mark referenced this issue 2026-10-04 00:02:07 +00:00

Editor has no 'duplicate path' shortcut — user with 10 mirrored petals must draw each one individually even though the Edit menu has no Duplicate Path entry #213

Mark referenced this issue from a commit 2026-10-04 00:36:49 +00:00

fix(#191): editor right-click context menu — Add Node, Delete, Duplicate, Convert, Hide, Fit

Mark commented 2026-10-04 00:41:50 +00:00

Author

Owner

Copy link

Fixed in cf9d558.

Added EditorContextMenu mirroring the workspace's pattern. Hit-aware items:

• Empty + selected path -> Delete Path / Duplicate Path / Hide/Show / Fit to View
• Segment hit -> Add Node (uses pre-computed point)
• Node hit -> Delete Node (promotes selection)
• Nodes selected -> Convert Node Type submenu (corner / smooth / symmetric)

Right-click anywhere on the editor canvas opens it; pointerdown elsewhere or Escape closes it.

Plumbing through Editor.tsx added handleDeleteNode and handleTogglePathVisibilitySingle. 143 editor tests pass (12 new for #191, 11 for the menu + 6 canvas integration). tsc -b clean, eslint clean.

Note: Forgejo Actions on this repo are currently all cancelled since 2026-10-03 - pre-existing CI infra issue. Local vitest run is the operative gate; all 880 tests pass.

Fixed in cf9d558. Added EditorContextMenu mirroring the workspace's pattern. Hit-aware items: * Empty + selected path -> Delete Path / Duplicate Path / Hide/Show / Fit to View * Segment hit -> Add Node (uses pre-computed point) * Node hit -> Delete Node (promotes selection) * Nodes selected -> Convert Node Type submenu (corner / smooth / symmetric) Right-click anywhere on the editor canvas opens it; pointerdown elsewhere or Escape closes it. Plumbing through Editor.tsx added handleDeleteNode and handleTogglePathVisibilitySingle. 143 editor tests pass (12 new for #191, 11 for the menu + 6 canvas integration). tsc -b clean, eslint clean. Note: Forgejo Actions on this repo are currently all `cancelled` since 2026-10-03 - pre-existing CI infra issue. Local `vitest run` is the operative gate; all 880 tests pass.

Mark closed this issue 2026-10-04 00:41:56 +00:00

Mark referenced this issue 2026-10-04 02:36:16 +00:00

Gallery's RightClickMenu component exists but is not used anywhere — DesignCard's onContextMenu only calls e.preventDefault(), so the menu never opens, the user has no right-click affordance on designs #242

Mark referenced this issue 2026-10-04 03:35:00 +00:00

Editor has no Bezier handles on smooth/symmetric nodes — user can only drag the node itself, no way to adjust the curve's control handles (Illustrator-style handles are the standard for vector editing) #251

Mark referenced this issue 2026-10-04 03:37:35 +00:00

Editor has no 'align' or 'distribute' operations for paths — user with 5 paths in a design has to manually drag each to align, no Figma-style 'align left' or 'distribute horizontally' #258

Mark referenced this issue 2026-10-04 03:37:35 +00:00

Editor has no 'group' or 'ungroup' operations — user with 5 paths forming one logical shape (e.g., a flower: stem + 5 petals) has no way to treat them as a single unit; multi-select exists but no persistent group identity #259

Mark referenced this issue 2026-10-04 03:42:40 +00:00

Editor has no 'boolean operations' (union, subtract, intersect) between two paths — user wanting to combine two overlapping paths into one, or cut a shape out of another, has no tool for it #281

Mark referenced this issue 2026-10-04 03:46:45 +00:00

Editor has no 'lock path' option — user wanting to keep a path from being accidentally edited has to use 'Hide' (which removes the path from rendering) or move it out of the way; no separate 'lock for editing' state #289

Mark referenced this issue 2026-10-04 03:46:45 +00:00

Editor has no 'bring to front' / 'send to back' / 'z-order' operations for paths — user with overlapping paths (e.g., a circle behind a star) can't reorder which is drawn on top, only the array order (draw order) is in effect #290

Mark referenced this issue 2026-10-04 03:47:23 +00:00

Editor has no 'set as background' / 'use as reference' for a path — user wanting to trace over an existing path has to use the visibility toggle (hide/unhide to compare) or the lock, no separate 'background' state #293

Mark referenced this issue 2026-10-04 03:47:39 +00:00

Editor's Bottom Thread Bar's thread stop order is the sewing order (per #222 / #190) but there's no drag-reorder for the user to fix the order manually — user wanting to reorder threads has to go to the workspace or use the editor's context menu (if … #295

Mark referenced this issue 2026-10-04 03:51:07 +00:00

Editor's path 'close path' is not visible as an action — user with an open path (line) wanting to make it a closed path (polygon) has to either delete the last node or no documented way to do it #315

Mark referenced this issue 2026-10-04 03:51:07 +00:00

Editor has no 'reverse path direction' operation — user with a path drawn right-to-left who wants it left-to-right (e.g., for stitch direction) has to redraw or no documented way to reverse #316

Mark referenced this issue 2026-10-04 03:54:28 +00:00

Editor's Path Properties section has no 'convert all nodes' button — user with 30 corner nodes wanting to make them all smooth has to select each one and convert (or no bulk operation) #339

Mark referenced this issue 2026-10-04 03:54:29 +00:00

Editor's path operations are scattered between the right panel, the EditorContextMenu, and keyboard shortcuts — no unified 'Operations' menu to discover all path operations in one place #340

Mark referenced this issue 2026-10-04 03:57:16 +00:00

Editor's Path Properties section has 'Convert Node Type' (corner / smooth / symmetric) but the symmetric/smooth distinction is unclear in the UI — user clicks 'smooth' and gets 'symmetric' (or vice versa) #359

Mark referenced this issue 2026-10-04 03:57:34 +00:00

Editor's Node Properties has no 'break handles' or 'link handles' toggle — user with a smooth node wanting to make the two handles independent (smooth) or mirrored (symmetric) has no UI to toggle this #361

Mark referenced this issue from a commit 2026-10-04 03:59:52 +00:00

fix(#213): Editor Cmd/Ctrl+D duplicates the selected path

Mark referenced this issue 2026-10-04 04:00:09 +00:00

Editor has no 'duplicate path' shortcut — user with 10 mirrored petals must draw each one individually even though the Edit menu has no Duplicate Path entry #213

Mark referenced this issue from a commit 2026-10-04 07:48:05 +00:00

docs(#236): editor right-click context menu — implementation already on main (#191)

Mark referenced this issue from a commit 2026-10-04 20:48:28 +00:00

fix(#300): editor Duplicate Path now has a 0/1/2.5/5/10 mm offset picker

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

No results found.

Labels

Clear labels   

blocked:commit-ready-failed

  

blocked:gate-fetch

  

blocked:gate-lint

  

blocked:gate-plan

  

blocked:gate-research

  

blocked:needs-attention

Worker halted; needs human/janitor inspection

  

blocked:needs-decision

  

blocked:needs-human

  

blocked:no-changes

  

blocked:verify-failed

  

bug

  

deferred

  

feature-request

  

in-progress

  

needs-decompose

  

needs-triage

  

quickfix

  

security/medium

  

triage-approved

No labels

blocked:commit-ready-failed

blocked:gate-fetch

blocked:gate-lint

blocked:gate-plan

blocked:gate-research

blocked:needs-attention

blocked:needs-decision

blocked:needs-human

blocked:no-changes

blocked:verify-failed

bug

deferred

feature-request

in-progress

needs-decompose

needs-triage

quickfix

security/medium

triage-approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Mark/Kimi_Agent_Brother_10_Digitizing_App#191

No description provided.