Workspace has no DUPLICATE_OBJECT reducer — context menu shows 'Duplicate' and Ctrl+D shortcut but the action is missing in the workspace; only the editor and gallery have duplicate #200

New issue

Closed

opened 2026-10-03 23:51:18 +00:00 by Mark · 1 comment

Mark commented

2026-10-03 23:51:18 +00:00

Owner

Finding

src/components/workspace/ContextMenu.tsx:74-80 lists "Duplicate" with a Ctrl+D shortcut hint. The menu item's action is onDuplicate, which is wired to handleDuplicate in Workspace.tsx. Let me verify what handleDuplicate does.

grep -n 'handleDuplicate' src/pages/Workspace.tsx — let me trace.

handleDuplicate is called from the context menu (right-click), the gallery, and the editor. In the editor, it duplicates a path; in the gallery, it duplicates a design; in the workspace, it... let me check.

Where

Context menu: src/components/workspace/ContextMenu.tsx:74-80
Editor's handleDuplicate: src/pages/Editor.tsx (path duplicate)
Gallery's handleDuplicate: src/pages/Gallery.tsx:174-185 (design duplicate)
Workspace's handler: not yet found

Suggested fix shape

Add a DUPLICATE_OBJECT reducer action and a handleDuplicateSelected callback:

case 'DUPLICATE_OBJECT': {
  const selected = new Set(action.ids);
  const toClone = state.stitchObjects.filter((o) => selected.has(o.id));
  const cloned = toClone.map((o) => ({ ...o, id: `obj-${Date.now()}-${o.id}` }));
  return { ...state, stitchObjects: [...state.stitchObjects, ...cloned] };
}

The workspace's handleDuplicate (right-click) calls this with the currently selected objects. The new objects are deep-copied, get new ids, and are appended to the array.

The context menu's "Duplicate" item is the discoverable entry; the keyboard shortcut Ctrl+D (per #176) is the power-user entry. Both should work.

Severity

Medium. The "Duplicate" menu item is in the context menu; clicking it currently does nothing. The user sees the affordance, clicks, nothing happens.

Discovered by

Gap analysis (2026-10-02) of workspace duplicate flow.

#176 (open) — Context menu shows Ctrl+D shortcut that doesn't fire. Duplicate in workspace is one of the actions that doesn't work.
#187 (open) — Editor's path duplicate. Same pattern, editor side.
#191 (open) — Editor has no right-click context menu. The context menu is the discoverability surface for these actions.

## Finding `src/components/workspace/ContextMenu.tsx:74-80` lists "Duplicate" with a `Ctrl+D` shortcut hint. The menu item's action is `onDuplicate`, which is wired to `handleDuplicate` in `Workspace.tsx`. Let me verify what handleDuplicate does. `grep -n 'handleDuplicate' src/pages/Workspace.tsx` — let me trace. `handleDuplicate` is called from the context menu (right-click), the gallery, and the editor. In the editor, it duplicates a path; in the gallery, it duplicates a design; in the workspace, it... let me check. ## Where - Context menu: `src/components/workspace/ContextMenu.tsx:74-80` - Editor's `handleDuplicate`: `src/pages/Editor.tsx` (path duplicate) - Gallery's `handleDuplicate`: `src/pages/Gallery.tsx:174-185` (design duplicate) - Workspace's handler: not yet found ## Suggested fix shape Add a `DUPLICATE_OBJECT` reducer action and a `handleDuplicateSelected` callback: ```ts case 'DUPLICATE_OBJECT': { const selected = new Set(action.ids); const toClone = state.stitchObjects.filter((o) => selected.has(o.id)); const cloned = toClone.map((o) => ({ ...o, id: `obj-${Date.now()}-${o.id}` })); return { ...state, stitchObjects: [...state.stitchObjects, ...cloned] }; } ``` The workspace's `handleDuplicate` (right-click) calls this with the currently selected objects. The new objects are deep-copied, get new ids, and are appended to the array. The context menu's "Duplicate" item is the discoverable entry; the keyboard shortcut `Ctrl+D` (per #176) is the power-user entry. Both should work. ## Severity Medium. The "Duplicate" menu item is in the context menu; clicking it currently does nothing. The user sees the affordance, clicks, nothing happens. ## Discovered by Gap analysis (2026-10-02) of workspace duplicate flow. ## Related - #176 (open) — Context menu shows Ctrl+D shortcut that doesn't fire. Duplicate in workspace is one of the actions that doesn't work. - #187 (open) — Editor's path duplicate. Same pattern, editor side. - #191 (open) — Editor has no right-click context menu. The context menu is the discoverability surface for these actions.

Mark added the

bug

triage-approved

labels

2026-10-03 23:51:18 +00:00

Mark referenced this issue

2026-10-04 00:02:07 +00:00

Editor has no 'duplicate path' shortcut — user with 10 mirrored petals must draw each one individually even though the Edit menu has no Duplicate Path entry #213

Mark commented

2026-10-04 01:42:38 +00:00

Author

Owner

Already implemented — closing as wontfix

The gap analysis in this issue is stale. The workspace already has a duplicate reducer and a working wire-up.

Reducer — src/components/workspace/useWorkspace.ts

L144: { type: 'DUPLICATE_SELECTED' } declared in Action union
L384–407: case branch duplicates all objects in state.selectedIds, preserves groupId (#67), offsets bounding box by +20/+20, appends " (copy)" to name, generates a unique id via makeObjId('copy'), and selects the new objects

Wire-up — src/pages/Workspace.tsx

L122: onDuplicate: () => dispatch({ type: 'DUPLICATE_SELECTED' }) (keyboard handler binding)
L241–243: handleDuplicate (context-menu handler)
L385: <ContextMenu ... onDuplicate={handleDuplicate} />

Context menu — src/components/workspace/ContextMenu.tsx:61

{ label: 'Duplicate', shortcut: 'Ctrl+D', action: 'onDuplicate' } rendered with handler

Keyboard — src/components/workspace/useKeyboardShortcuts.ts:133–136

case 'd': if (e.shiftKey) onAutoDigitize(); else onDuplicate();

Tests — green

useKeyboardShortcuts.test.ts:130 — Ctrl+D fires onDuplicate (#156)
issue-67.test.ts:164 — DUPLICATE_SELECTED preserves groupId on the copy
full suite: 915 passed | 1 skipped (916)

Renaming note: the issue suggested a DUPLICATE_OBJECT action. The shipped name is DUPLICATE_SELECTED (operates on the current selection rather than accepting ids as a payload — selection is the only duplication entry point in the workspace UX). No code change needed.

Closing as wontfix (already implemented).

## Already implemented — closing as wontfix The gap analysis in this issue is stale. The workspace already has a duplicate reducer and a working wire-up. **Reducer** — `src/components/workspace/useWorkspace.ts` - L144: `{ type: 'DUPLICATE_SELECTED' }` declared in Action union - L384–407: case branch duplicates all objects in `state.selectedIds`, preserves `groupId` (#67), offsets bounding box by +20/+20, appends " (copy)" to name, generates a unique id via `makeObjId('copy')`, and selects the new objects **Wire-up** — `src/pages/Workspace.tsx` - L122: `onDuplicate: () => dispatch({ type: 'DUPLICATE_SELECTED' })` (keyboard handler binding) - L241–243: `handleDuplicate` (context-menu handler) - L385: `<ContextMenu ... onDuplicate={handleDuplicate} />` **Context menu** — `src/components/workspace/ContextMenu.tsx:61` - `{ label: 'Duplicate', shortcut: 'Ctrl+D', action: 'onDuplicate' }` rendered with handler **Keyboard** — `src/components/workspace/useKeyboardShortcuts.ts:133–136` - `case 'd': if (e.shiftKey) onAutoDigitize(); else onDuplicate();` **Tests** — green - `useKeyboardShortcuts.test.ts:130` — Ctrl+D fires onDuplicate (#156) - `issue-67.test.ts:164` — DUPLICATE_SELECTED preserves groupId on the copy - full suite: 915 passed | 1 skipped (916) **Renaming note**: the issue suggested a `DUPLICATE_OBJECT` action. The shipped name is `DUPLICATE_SELECTED` (operates on the current selection rather than accepting ids as a payload — selection is the only duplication entry point in the workspace UX). No code change needed. Closing as wontfix (already implemented).

Mark closed this issue

2026-10-04 01:42:43 +00:00