fix(mypy): clear Real-bug bucket for in-scope codes (resolves #116) #124

Merged

Mark merged 2 commits from fix/116-mypy-real-bug-bucket into main 2026-09-11 18:18:07 +00:00

Conversation 0 Commits 2 Files changed 58 +303 -148

Mark commented 2026-09-11 17:40:23 +00:00

Owner

Copy link

Resolves Mark/osint-hub#116 — fix all Real-bug mypy errors in the Mark/osint-hub backend across codes [assignment], [arg-type], [return-value], [attr-defined], [misc], [valid-type], [call-arg].

Scope. 145 real-bug rows fixed across 58 files. The card body reported 335 at the @9931443 snapshot; 190 were incidentally cleared by PR #119 (annotation-debt bucket, landed before this fix) and 145 still remained on origin/main @abdf87d — those are all now resolved.

Rebase notes (2026-09-11). Rebased onto origin/main @ c5b75e1 (post-PR #122/#123). Dropped the local copy of PR #119's annotation-debt commit (5ccbd61) since it's functionally identical to main's abdf87d — only formatting differences. Resolved one merge conflict in backend/app/services/investigations/async_executor.py:load_tasks by combining the #116 cast on InvestigationTask.status.in_(...) (attr-defined fix) with the #119 multi-line order_by style, with casts on both priority.desc() and created_at per the #116 pattern. Verification post-rebase: mypy app/ shows 139 errors total, 0 in in-scope codes (var-annotated 38, union-attr 24, unreachable 20, no-any-return 15, index 10, redundant-cast 9, dict-item 7, operator 7, unused-ignore 6, no-redef 1, override 1, truthy-function 1 — all out-of-scope, owned by other fixit cards).

Resolves Mark/osint-hub#116 — fix all Real-bug mypy errors in the Mark/osint-hub backend across codes [assignment], [arg-type], [return-value], [attr-defined], [misc], [valid-type], [call-arg]. **Scope.** 145 real-bug rows fixed across 58 files. The card body reported 335 at the @9931443 snapshot; 190 were incidentally cleared by PR #119 (annotation-debt bucket, landed before this fix) and 145 still remained on origin/main @abdf87d — those are all now resolved. **Rebase notes (2026-09-11).** Rebased onto origin/main @ c5b75e1 (post-PR #122/#123). Dropped the local copy of PR #119's annotation-debt commit (5ccbd61) since it's functionally identical to main's abdf87d — only formatting differences. Resolved one merge conflict in backend/app/services/investigations/async_executor.py:load_tasks by combining the #116 cast on InvestigationTask.status.in_(...) (attr-defined fix) with the #119 multi-line order_by style, with casts on both priority.desc() and created_at per the #116 pattern. Verification post-rebase: mypy app/ shows 139 errors total, 0 in in-scope codes (var-annotated 38, union-attr 24, unreachable 20, no-any-return 15, index 10, redundant-cast 9, dict-item 7, operator 7, unused-ignore 6, no-redef 1, override 1, truthy-function 1 — all out-of-scope, owned by other fixit cards).

Mark added 2 commits 2026-09-11 17:40:24 +00:00

fix(mypy): clear Annotation-debt bucket for in-scope codes (closes #117, refs #118) ... 5ccbd61699

- app/modules/base.py: declare name/description/requires_config as ClassVar so
  EvidenceModule subclass redeclarations stop tripping '[misc] Cannot override
  instance variable with class variable' (clears 158 [misc] errors).
- Six SQLAlchemy order_by() sites: cast(ColumnElement[Any], <model_column>)
  at the use site to bridge stub/runtime disagreement in
  app/services/investigations/state_machine.py:149,
  app/services/investigations/async_executor.py:98,
  app/services/investigations/orchestrator_enhanced.py:327,
  app/services/investigations/orchestrator_v3_llm.py:767,
  app/routers/investigations.py:861, :889.
- app/modules/registry.py:237: replace builtin 'any' with typing 'Any' in
  list_module_details return type annotation.

Out of scope (Real-bucket / sibling card #116): [assignment], [return-value],
[attr-defined], [call-arg]; PK-column nullability ([arg-type] int | None -> int)
lives in the Real-bug bucket and is owned by #116.

Refs #109, #117

fix(mypy): clear Real-bug bucket for in-scope codes (resolves #116) ... 6a9e27e694

Drives in-scope mypy error codes (assignment, arg-type, return-value,
attr-defined, misc, call-arg, valid-type) to 0 across the Mark/osint-hub
backend. 145 real-bug rows fixed across 58 files (vs 335 reported at the
@9931443 snapshot — 190 were incidentally cleared by PR #119 annotation
work that landed before this fix).

Each fix carries an inline justification comment naming the mypy code
and the reason for the change. Patterns applied:

- assert x.id is not None  # nosec B101 - <runtime invariant>
  (SQLModel PKs are typed Optional[int]; runtime invariants guarantee
   they are populated after session.refresh / session.get / .first())
- typing_cast(ColumnElement, Model.col).asc()/.desc()/.in_(...)
  (SQLAlchemy column accessors on typed model fields)
- typing_cast(dict, params) at aiohttp/httpx boundary
  (stricter Mapping[str, str|SupportsInt|...] in newer client stubs)
- session.query(...).filter(...) -> session.exec(select(...).where(...))
  (consistency with the rest of the codebase, also avoids the
   Query.filter() ColumnElement[bool] gap)
- typing: dict[str, Any] = {} when accumulating heterogeneous values
- Module-level typing_cast(Any, ...) for duck-typed third-party APIs
  (playwright async_playwright return, mcp.Server stub gaps)
- Rename reused local (existing -> existing_org) to avoid cross-type
  unification in adjacent loops

Skip [misc] bucket ClassVar pattern (separate fixit card t_e352cc9a).
Skip [import-untyped] / [no-untyped-def] (out of scope per #116).

Verification: `cd backend && mypy app/ --config-file ../pyproject.toml`
shows 0 errors in the in-scope codes (was 166 at snapshot, 305 at
origin/main @abdf87d).

Mark added 1 commit 2026-09-11 18:17:21 +00:00

noop: trigger Forgejo merge_base recompute f119215d92

Mark merged commit 0963d67aca into main 2026-09-11 18:18:07 +00:00

Mark deleted branch fix/116-mypy-real-bug-bucket 2026-09-11 18:18:07 +00:00

Mark referenced this pull request from a commit 2026-09-11 18:18:09 +00:00

Merge PR #124 (fix #116): clear Real-bug mypy bucket

Mark referenced this pull request 2026-09-11 18:47:51 +00:00

fix(#100): residual ruff violations (PLR0917 / F401 / PLC0415 / I001) — rebased onto current main #126

Mark referenced this pull request from a commit 2026-09-11 19:32:08 +00:00

fix(mypy): add type annotations for var-annotated bucket (closes #117 subset)

Mark referenced this pull request 2026-09-11 19:32:25 +00:00

fix(mypy): clear var-annotated bucket (closes #117 subset) #127

Mark referenced this pull request 2026-09-14 21:27:48 +00:00

fix(mypy): clear Optional/None + union-type bucket (closes #117 subset) #151

Mark referenced this pull request from a commit 2026-09-14 23:05:17 +00:00

fix(mypy): replace 6 unjustified in-scope type: ignore masks with code fixes

Mark referenced this pull request 2026-09-14 23:05:24 +00:00

fix(mypy): replace 6 unjustified in-scope type: ignore masks with code fixes #156

Mark referenced this pull request 2026-09-18 14:01:32 +00:00

ci(backend-lint): add mypy as a gating step (closes #109) #158

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agentic-osint

Agentic OSINT features

  

audit

  

blocked:commit-ready-failed

  

blocked:gate-fetch

  

blocked:gate-fetch

  

blocked:gate-lint

  

blocked:gate-plan

  

blocked:gate-research

  

blocked:needs-decision

  

blocked:needs-human

  

blocked:no-changes

  

blocked:preflight

Repo has dirty lint; kilo-gsd preflight refuses to dispatch until lint-cleanup lands

  

blocked:verify-failed

  

bug

Something is not working

  

chore

Config/cleanup item

  

deferred

Deferred — will revisit later

  

enhancement

Enhancement request

  

feature-request

  

in-progress

  

lint-baseline

  

lint-cleanup

kilo-gsd preflight lint gate: repo has dirty ruff state, cleanup required before fixer dispatch

  

needs-decompose

Issue needs decompose processing

  

needs-triage

  

performance

  

quickfix

  

security/medium

Medium severity security issue

  

triage-approved

Approved by triage

No labels

agentic-osint

audit

blocked:commit-ready-failed

blocked:gate-fetch

blocked:gate-fetch

blocked:gate-lint

blocked:gate-plan

blocked:gate-research

blocked:needs-decision

blocked:needs-human

blocked:no-changes

blocked:preflight

blocked:verify-failed

bug

chore

deferred

enhancement

feature-request

in-progress

lint-baseline

lint-cleanup

needs-decompose

needs-triage

performance

quickfix

security/medium

triage-approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Mark/osint-hub!124

No description provided.