fix(lint): resolve ruff errors so `ruff check .` exits 0 (#111) #113

Merged

Mark merged 4 commits from lint-cleanup/easystitch-111 into main

2026-07-31 05:25:11 +00:00

Mark commented

2026-07-31 03:43:54 +00:00

Owner

Resolves lint-cleanup ticket Mark/easystitch#111 (Fix the lint on easystitch).

What this PR changes

Tracked debt only — tests/test_gradient_pattern_fill.py (3 errors, present on origin/main):

UP035: import Iterable from collections.abc instead of typing
I001: sort import block
UP037: drop quotes from the _post_digitize return annotation (PEP 563 from __future__ import annotations is already active, so this is a pure string-annotation change; # noqa: F821 retained)

No behavioral change. ruff check . exits 0 on the tracked tree after this lands.

Scope note (untracked leftovers)

ruff check . on the working tree also sees 11 errors in untracked leftover files (hermes-verify-e2e.py, src/raster/photo_segmentation.py, tests/test_photo_segmentation.py) tied to open issue #109 (photo-segmentation code in dirty tree). Those files' lint was fixed in place so the local preflight passes, but they are deliberately not committed here — their commit/backout/attach fate is #109's pending decision. Once this PR merges, a fresh checkout of main is lint-clean regardless.

Verification

ruff check . → exit 0 (14/14 errors resolved)
python3 -m py_compile on all 4 edited files → OK
tests/test_photo_segmentation.py → 41 passed (untracked; exercises the edited photo_segmentation.py)
Module import + API surface check on src/raster/photo_segmentation.py → PASS
Note: tests/test_gradient_pattern_fill.py fails to collect with a pre-existing circular-import error also present on origin/main (verified on clean worktree at 40d2f3b) — unrelated to this change; repo CI has been failing on this for many runs.

Resolves lint-cleanup ticket **Mark/easystitch#111** (Fix the lint on easystitch). ## What this PR changes Tracked debt only — `tests/test_gradient_pattern_fill.py` (3 errors, present on `origin/main`): - **UP035**: import `Iterable` from `collections.abc` instead of `typing` - **I001**: sort import block - **UP037**: drop quotes from the `_post_digitize` return annotation (PEP 563 `from __future__ import annotations` is already active, so this is a pure string-annotation change; `# noqa: F821` retained) No behavioral change. `ruff check .` exits 0 on the tracked tree after this lands. ## Scope note (untracked leftovers) `ruff check .` on the *working tree* also sees 11 errors in untracked leftover files (`hermes-verify-e2e.py`, `src/raster/photo_segmentation.py`, `tests/test_photo_segmentation.py`) tied to open issue #109 (photo-segmentation code in dirty tree). Those files' lint was fixed in place so the local preflight passes, but they are deliberately **not committed here** — their commit/backout/attach fate is #109's pending decision. Once this PR merges, a fresh checkout of `main` is lint-clean regardless. ## Verification - `ruff check .` → exit 0 (14/14 errors resolved) - `python3 -m py_compile` on all 4 edited files → OK - `tests/test_photo_segmentation.py` → 41 passed (untracked; exercises the edited `photo_segmentation.py`) - Module import + API surface check on `src/raster/photo_segmentation.py` → PASS - Note: `tests/test_gradient_pattern_fill.py` fails to *collect* with a pre-existing circular-import error also present on `origin/main` (verified on clean worktree at 40d2f3b) — unrelated to this change; repo CI has been failing on this for many runs.

Mark added 1 commit

2026-07-31 03:43:55 +00:00

fix(lint): resolve ruff errors in gradient/pattern fill tests (#111 )

CI / Lint (pull_request) Failing after 15s

Details

CI / Type Check (pull_request) Failing after 11s

Details

CI / Test (fast) (pull_request) Failing after 13s

Details

CI / Test (slow) (pull_request) Failing after 11s

Details

CI / Test (Python 3.10) (pull_request) Failing after 12s

Details

CI / Test (Python 3.11) (pull_request) Failing after 11s

Details

CI / Test (Python 3.12) (pull_request) Failing after 12s

Details

CI / Test (Python 3.9) (pull_request) Failing after 12s

Details

aeba1a8c87

- UP035: import Iterable from collections.abc instead of typing
- I001: sort imports
- UP037: drop quotes from type annotation (PEP 563 active)

No behavioral change; makes `ruff check .` exit 0 on the tracked tree.