Decide fate of backed-up photo-segmentation leftovers (single-file cv2 variant + scratch verify script) — delete or keep as historical prototype #116

New issue

Closed

opened 2026-07-31 04:51:26 +00:00 by Mark · 1 comment

Mark commented

2026-07-31 04:51:26 +00:00

Owner

Finding

Issue #112 (photo segmentation review-tracking) flags 3 out-of-scope leftovers in the easystitch worktree and explicitly defers the decision: "Decide: delete or keep as historical prototype." No Forgejo issue tracks this decision — the physical files were moved out of the repo by a kanban executor (issue #109 KEEP remediation), so the decision is invisible to anyone working from the repo or the issue tracker. The backup copy still sits on disk with no tracked owner.

Actual behavior

3 files existed as untracked leftovers in the easystitch worktree, predating the modular src/segmentation/ package (canonical implementation on PR #114):
- src/raster/photo_segmentation.py (~40 KB — earlier single-file cv2-based variant, redundant with src/segmentation/)
- tests/test_photo_segmentation.py (~23 KB — tests for the single-file variant)
- hermes-verify-e2e.py (~3 KB — scratch verification script at repo root)
These untracked paths blocked the kilo-gsd pre-dispatch gate (?? hermes-verify-e2e.py, ?? src/raster/photo_segmentation.py, ?? tests/test_photo_segmentation.py), per the gate output recorded on kanban card t_0ba18761.
2026-07-30 ~20:38 local: the #109 KEEP executor moved the 3 files out of the worktree into a backup dir: /home/b/.hermes/kanban/boards/fixit/workspaces/t_0ba18761/leftover-backup/. They were never committed: git log --all has no history for any of the 3 paths, and they are absent from main and from branch photo-segmentation/t_218724de (commit 4709f09).
A kanban triage memo (t_0ba18761) recommended "delete", but that recommendation was never surfaced to the Forgejo tracker, and the backup copy remains on disk (only machine-local state).

Expected behavior

A recorded, tracked decision, one of:

DELETE — confirm the files are obsolete (the modular src/segmentation/ package on PR #114 supersedes them; #115 already covers the tracked test-collection bug that shared root cause territory) and remove the backup copy, or
KEEP — commit them under a clearly-labeled legacy path (e.g. docs/prototypes/ or src/raster/_legacy/) as a historical prototype with a note.

Until then, the backup dir is orphaned machine-local state with no owner.

Reproduction steps

cd /home/b/Projects/easystitch && git status --porcelain — the 3 paths are absent (moved out 2026-07-30 20:38); the worktree is clean of them.
ls -la /home/b/.hermes/kanban/boards/fixit/workspaces/t_0ba18761/leftover-backup/ — the 3 files exist only here (hermes-verify-e2e.py 2957b, photo_segmentation.py 40536b, test_photo_segmentation.py 23892b).
git log --all --oneline -- src/raster/photo_segmentation.py tests/test_photo_segmentation.py hermes-verify-e2e.py — no commits ever referenced them.
git -C /home/b/Projects/easystitch branch -a — photo-segmentation/t_218724de (4709f09) holds the canonical modular package; the single-file variant duplicates it.

References

Kanban card: t_bdb9d8cd (reporter lane, 2026-07-30) — source of this finding
Issue #112 — photo segmentation pipeline review-tracking (flags these leftovers, defers the decision as out-of-scope)
Issue #109 — dirty-tree incident report (KEEP decision executed; executor moved the files out)
PR #114 — canonical modular implementation (feat(#112))
PR #113 — lint fix (#111)
Backup dir: /home/b/.hermes/kanban/boards/fixit/workspaces/t_0ba18761/leftover-backup/

## Finding Issue #112 (photo segmentation review-tracking) flags 3 out-of-scope leftovers in the easystitch worktree and explicitly defers the decision: *"Decide: delete or keep as historical prototype."* No Forgejo issue tracks this decision — the physical files were moved out of the repo by a kanban executor (issue #109 KEEP remediation), so the decision is invisible to anyone working from the repo or the issue tracker. The backup copy still sits on disk with no tracked owner. ## Actual behavior - 3 files existed as untracked leftovers in the easystitch worktree, predating the modular `src/segmentation/` package (canonical implementation on PR #114): - `src/raster/photo_segmentation.py` (~40 KB — earlier single-file cv2-based variant, redundant with `src/segmentation/`) - `tests/test_photo_segmentation.py` (~23 KB — tests for the single-file variant) - `hermes-verify-e2e.py` (~3 KB — scratch verification script at repo root) - These untracked paths blocked the kilo-gsd pre-dispatch gate (`?? hermes-verify-e2e.py`, `?? src/raster/photo_segmentation.py`, `?? tests/test_photo_segmentation.py`), per the gate output recorded on kanban card t_0ba18761. - 2026-07-30 ~20:38 local: the #109 KEEP executor moved the 3 files out of the worktree into a backup dir: `/home/b/.hermes/kanban/boards/fixit/workspaces/t_0ba18761/leftover-backup/`. They were never committed: `git log --all` has no history for any of the 3 paths, and they are absent from `main` and from branch `photo-segmentation/t_218724de` (commit 4709f09). - A kanban triage memo (t_0ba18761) recommended "delete", but that recommendation was never surfaced to the Forgejo tracker, and the backup copy remains on disk (only machine-local state). ## Expected behavior A recorded, tracked decision, one of: 1. **DELETE** — confirm the files are obsolete (the modular `src/segmentation/` package on PR #114 supersedes them; #115 already covers the tracked test-collection bug that shared root cause territory) and remove the backup copy, or 2. **KEEP** — commit them under a clearly-labeled legacy path (e.g. `docs/prototypes/` or `src/raster/_legacy/`) as a historical prototype with a note. Until then, the backup dir is orphaned machine-local state with no owner. ## Reproduction steps 1. `cd /home/b/Projects/easystitch && git status --porcelain` — the 3 paths are absent (moved out 2026-07-30 20:38); the worktree is clean of them. 2. `ls -la /home/b/.hermes/kanban/boards/fixit/workspaces/t_0ba18761/leftover-backup/` — the 3 files exist only here (`hermes-verify-e2e.py` 2957b, `photo_segmentation.py` 40536b, `test_photo_segmentation.py` 23892b). 3. `git log --all --oneline -- src/raster/photo_segmentation.py tests/test_photo_segmentation.py hermes-verify-e2e.py` — no commits ever referenced them. 4. `git -C /home/b/Projects/easystitch branch -a` — `photo-segmentation/t_218724de` (4709f09) holds the canonical modular package; the single-file variant duplicates it. ## References - Kanban card: t_bdb9d8cd (reporter lane, 2026-07-30) — source of this finding - Issue #112 — photo segmentation pipeline review-tracking (flags these leftovers, defers the decision as out-of-scope) - Issue #109 — dirty-tree incident report (KEEP decision executed; executor moved the files out) - PR #114 — canonical modular implementation (feat(#112)) - PR #113 — lint fix (#111) - Backup dir: `/home/b/.hermes/kanban/boards/fixit/workspaces/t_0ba18761/leftover-backup/`

Mark added the

chore

triage-approved

labels

2026-07-31 04:51:26 +00:00

Mark commented

2026-07-31 05:17:52 +00:00

Author

Owner

Decision: DELETE (recorded 2026-07-30 by tasker-worker, kanban card t_e095f41e)

The 3 backed-up leftovers are obsolete and have been removed. Evidence:

Never committed — git log --all -- src/raster/photo_segmentation.py tests/test_photo_segmentation.py hermes-verify-e2e.py is empty; absent from main and from photo-segmentation/t_218724de (4709f09). Zero git history, zero review trail.
100% API redundancy with canonical package — the single-file variant's full public surface (auto_classify, dog_edges, snap_edges, felzenszwalb_segment, detect_fill_type, extract_gradient_stops, region_to_pathdata, regions_to_pathdatas, extract_shared_boundaries, allocate_weighted_palette, spectral_saliency, PhotoSegmenter, segment_pil_image, PathData, SegmentedRegion, SegmentedPhoto) is 1:1 covered by src/segmentation/ (10 modules, 9 test files) on PR #114, verified 95/95 tests + ruff clean (per #112 verification run 2026-07-30).
Scratch script is machine-specific — hermes-verify-e2e.py hardcodes sys.path.insert(0, '/home/b/Projects/easystitch') and imports the CANONICAL package, not the single-file variant.
Triage memo (kanban t_6e79674c) recommended delete — 'Delete the 3 leftover untracked files... They are superseded (single-file prototype) / scratch.'
Historical record already exists — design doc docs/photo-segmentation-design-state.md + canonical commit 4709f09 + PR #114 are the tracked history; the single-file variant adds no unique value.

Executed: backup dir /home/b/.hermes/kanban/boards/fixit/workspaces/t_0ba18761/leftover-backup/ removed (2026-07-30 ~22:17 local); verified gone. The kilo-gsd pre-dispatch gate stays unblocked (paths already out of the worktree). Closing this issue as resolved.

Ref: #109, #112, PR #114

## Decision: DELETE (recorded 2026-07-30 by tasker-worker, kanban card t_e095f41e) The 3 backed-up leftovers are obsolete and have been removed. Evidence: 1. **Never committed** — `git log --all -- src/raster/photo_segmentation.py tests/test_photo_segmentation.py hermes-verify-e2e.py` is empty; absent from `main` and from `photo-segmentation/t_218724de` (4709f09). Zero git history, zero review trail. 2. **100% API redundancy with canonical package** — the single-file variant's full public surface (`auto_classify`, `dog_edges`, `snap_edges`, `felzenszwalb_segment`, `detect_fill_type`, `extract_gradient_stops`, `region_to_pathdata`, `regions_to_pathdatas`, `extract_shared_boundaries`, `allocate_weighted_palette`, `spectral_saliency`, `PhotoSegmenter`, `segment_pil_image`, `PathData`, `SegmentedRegion`, `SegmentedPhoto`) is 1:1 covered by `src/segmentation/` (10 modules, 9 test files) on PR #114, verified 95/95 tests + ruff clean (per #112 verification run 2026-07-30). 3. **Scratch script is machine-specific** — `hermes-verify-e2e.py` hardcodes `sys.path.insert(0, '/home/b/Projects/easystitch')` and imports the CANONICAL package, not the single-file variant. 4. **Triage memo (kanban t_6e79674c) recommended delete** — 'Delete the 3 leftover untracked files... They are superseded (single-file prototype) / scratch.' 5. **Historical record already exists** — design doc `docs/photo-segmentation-design-state.md` + canonical commit 4709f09 + PR #114 are the tracked history; the single-file variant adds no unique value. **Executed:** backup dir `/home/b/.hermes/kanban/boards/fixit/workspaces/t_0ba18761/leftover-backup/` removed (2026-07-30 ~22:17 local); verified gone. The kilo-gsd pre-dispatch gate stays unblocked (paths already out of the worktree). Closing this issue as resolved. Ref: #109, #112, PR #114

Mark closed this issue

2026-07-31 05:17:58 +00:00

Mark referenced this issue

2026-07-31 05:18:00 +00:00

Photo segmentation pipeline: implementation exists on branch, needs review #112