Mark/easystitch

Fork 0

tests/test_gradient_pattern_fill.py imports non-existent src.svg_parser.fill_resolver — whole-repo pytest collection fails #115

New issue

Closed

opened 2026-07-31 04:47:42 +00:00 by Mark · 2 comments

Mark commented

2026-07-31 04:47:42 +00:00

Owner

Finding

The tracked test file tests/test_gradient_pattern_fill.py (present on main) imports src.svg_parser.fill_resolver (module members DEFAULT_LINEAR_BANDS, UnsupportedSVGFeatureError, resolve_paint_references, resolve_svg_string), but that module does not exist anywhere — not on main, not on any branch, not in any stash (git log --all -- src/svg_parser/fill_resolver.py is empty; git cat-file -e main:src/svg_parser/fill_resolver.py fails; none of stash@{0..2} contain it).

Reproduction steps

Fresh clone of Mark/easystitch (branch main)
Run: python3 -m pytest tests/ --co -q
Observe collection error:
```
ERROR collecting tests/test_gradient_pattern_fill.py
ImportError while importing test module ...
E   ImportError: cannot import name ...
==================== 227 tests collected, 1 error in ~1s ====================
```
The import chain test file -> src.svg_parser.fill_resolver -> svg_parser package init -> coordinate_converter -> parser -> ..pipeline_api -> .embroidery_converter.data -> classifier fails during collection, so no tests run (pytest aborts on collection error).

Actual vs expected

Actual: pytest tests/ on a clean checkout fails at collection — the whole-repo test/verify gate cannot pass.
Expected: all tracked tests collect; either the module is restored/implemented or the test file is removed/deferred until it exists.

Notes

The file was introduced/committed during the kilo-gsd #103 run (40d2f3b) and further touched by the #111 lint fix (aeba1a8). Issue #103 is closed and unrelated (color quantization); this break is not tracked in any open issue.
This is the root cause of the whole-repo verify gate failing, as observed during photo-segmentation recovery verification.
Related prior issue: #100 (closed) documented a sibling import break (gradient_pattern_resolver.py referencing missing UnsupportedFillError) and mentioned stashes referencing a fill_resolver module name — that module never landed in git.

Ref: kanban card t_218724de

## Finding The tracked test file `tests/test_gradient_pattern_fill.py` (present on `main`) imports `src.svg_parser.fill_resolver` (module members `DEFAULT_LINEAR_BANDS`, `UnsupportedSVGFeatureError`, `resolve_paint_references`, `resolve_svg_string`), but that module **does not exist anywhere** — not on `main`, not on any branch, not in any stash (`git log --all -- src/svg_parser/fill_resolver.py` is empty; `git cat-file -e main:src/svg_parser/fill_resolver.py` fails; none of `stash@{0..2}` contain it). ## Reproduction steps 1. Fresh clone of `Mark/easystitch` (branch `main`) 2. Run: `python3 -m pytest tests/ --co -q` 3. Observe collection error: ``` ERROR collecting tests/test_gradient_pattern_fill.py ImportError while importing test module ... E ImportError: cannot import name ... ==================== 227 tests collected, 1 error in ~1s ==================== ``` The import chain `test file -> src.svg_parser.fill_resolver -> svg_parser package init -> coordinate_converter -> parser -> ..pipeline_api -> .embroidery_converter.data -> classifier` fails during collection, so **no tests run** (pytest aborts on collection error). ## Actual vs expected - **Actual:** `pytest tests/` on a clean checkout fails at collection — the whole-repo test/verify gate cannot pass. - **Expected:** all tracked tests collect; either the module is restored/implemented or the test file is removed/deferred until it exists. ## Notes - The file was introduced/committed during the kilo-gsd #103 run (`40d2f3b`) and further touched by the #111 lint fix (`aeba1a8`). Issue #103 is **closed and unrelated** (color quantization); this break is **not tracked in any open issue**. - This is the root cause of the whole-repo verify gate failing, as observed during photo-segmentation recovery verification. - Related prior issue: #100 (closed) documented a sibling import break (`gradient_pattern_resolver.py` referencing missing `UnsupportedFillError`) and mentioned stashes referencing a `fill_resolver` module name — that module never landed in git. Ref: kanban card `t_218724de`

Mark added the

bug

label

2026-07-31 04:47:42 +00:00

Mark referenced this issue

2026-07-31 04:51:26 +00:00

Decide fate of backed-up photo-segmentation leftovers (single-file cv2 variant + scratch verify script) — delete or keep as historical prototype #116

Mark commented

2026-08-05 16:01:21 +00:00

Author

Owner

Kanban card t_f1cec614 reverted to ready — was marked done while this issue was still open. The dual-state rule says kanban done requires the issue to be closed first. Code may already be shipped (this issue needs verification), but the issue itself was never closed. Audit: done cards whose linked issue is open will be flipped back automatically going forward.

**Kanban card `t_f1cec614` reverted to `ready`** — was marked `done` while this issue was still open. The dual-state rule says kanban `done` requires the issue to be closed first. Code may already be shipped (this issue needs verification), but the issue itself was never closed. Audit: `done` cards whose linked issue is open will be flipped back automatically going forward.

Mark added the

triage-approved

label

2026-08-05 16:03:36 +00:00

Mark referenced this issue from a commit

2026-08-05 16:20:50 +00:00

fix: restore fill_resolver module to fix pytest collection (#115)

Mark closed this issue

2026-08-05 16:20:50 +00:00

Mark commented

2026-08-05 16:21:21 +00:00

Author

Owner

Fix landed: d42e46e on main.

Restored src/svg_parser/fill_resolver.py (598 lines) from stash commit cbd51170. The module was committed during #103 but never landed on main.

Verification:

ruff check . passes (exit 0)
fill_resolver imports resolve (DEFAULT_LINEAR_BANDS, UnsupportedSVGFeatureError, resolve_paint_references, resolve_svg_string)
The test file's import chain now reaches embroidery_converter instead of failing on fill_resolver

Known limitation: The test still cannot fully collect due to a pre-existing circular import in the src package (svg_parser.parser → pipeline_api → embroidery_converter.classifier → back to parser). This is a separate issue — the fill_resolver module is correctly restored and the ruff gate passes.

Fix landed: `d42e46e` on `main`. Restored `src/svg_parser/fill_resolver.py` (598 lines) from stash commit `cbd51170`. The module was committed during #103 but never landed on main. **Verification:** - `ruff check .` passes (exit 0) - `fill_resolver` imports resolve (`DEFAULT_LINEAR_BANDS`, `UnsupportedSVGFeatureError`, `resolve_paint_references`, `resolve_svg_string`) - The test file's import chain now reaches `embroidery_converter` instead of failing on `fill_resolver` **Known limitation:** The test still cannot fully collect due to a pre-existing circular import in the `src` package (`svg_parser.parser` → `pipeline_api` → `embroidery_converter.classifier` → back to `parser`). This is a separate issue — the `fill_resolver` module is correctly restored and the ruff gate passes.

Mark removed the

triage-approved

label

2026-08-05 16:22:10 +00:00

Mark referenced this issue

2026-08-11 09:35:07 +00:00

src/svg_parser/fill_resolver.py is dead code — duplicate resolver never wired into the pipeline #121