#104 fix not on origin/main — issue closed while fix sits in unmerged PR #113 #118

New issue

Closed

opened 2026-07-31 05:19:27 +00:00 by Mark · 2 comments

Mark commented

2026-07-31 05:19:27 +00:00

Owner

Summary

Post-deploy probe finding (kanban card t_d25334c3 on the qa board). The fix for #104 is not on origin/main. Issue #104 was closed while the fix commit b6157c0 still lives only on branch lint-cleanup/easystitch-111, which is open as unmerged PR #113 — i.e. closed prematurely relative to deploy.

Reproduction steps

In a clone of Mark/easystitch: git merge-base --is-ancestor b6157c0 origin/main — exits non-zero (not an ancestor).
GET /api/v1/repos/Mark/easystitch/pulls/113 — state: open, merged: false, head: lint-cleanup/easystitch-111, base: main.
GET /api/v1/repos/Mark/easystitch/issues/104 — state: closed, closed_at: 2026-07-31T04:53:11Z.

Actual behavior

Fix commit b6157c0 is NOT an ancestor of origin/main; the fix has not landed.
PR #113 (base main, head lint-cleanup/easystitch-111) is open and unmerged.
Issue #104 is closed even though the fix is unmerged and undeployed.
Note: PR #113 is titled for #111 (lint cleanup) but its branch also carries the #104 fix commit b6157c0 — the #104 fix is riding along in an unrelated PR, which makes it easy to miss at merge time.

Expected behavior

The fix should be merged to origin/main and deployed (service restarted) before #104 is closed, or the closure deferred until the PR merges.

Fix needed

Merge PR #113 (or cherry-pick b6157c0 to main) and restart the :8080 service, then re-probe. See the companion issue (max_colors has no effect on running service) for the live-symptom detail.

Kanban card: t_d25334c3 (post-deploy probe findings, qa board)

## Summary Post-deploy probe finding (kanban card t_d25334c3 on the qa board). The fix for #104 is **not on `origin/main`**. Issue #104 was closed while the fix commit `b6157c0` still lives only on branch `lint-cleanup/easystitch-111`, which is open as unmerged PR #113 — i.e. closed prematurely relative to deploy. ## Reproduction steps 1. In a clone of Mark/easystitch: `git merge-base --is-ancestor b6157c0 origin/main` — exits non-zero (not an ancestor). 2. `GET /api/v1/repos/Mark/easystitch/pulls/113` — `state: open`, `merged: false`, `head: lint-cleanup/easystitch-111`, `base: main`. 3. `GET /api/v1/repos/Mark/easystitch/issues/104` — `state: closed`, `closed_at: 2026-07-31T04:53:11Z`. ## Actual behavior - Fix commit `b6157c0` is NOT an ancestor of `origin/main`; the fix has not landed. - PR #113 (base `main`, head `lint-cleanup/easystitch-111`) is open and unmerged. - Issue #104 is closed even though the fix is unmerged and undeployed. - Note: PR #113 is titled for #111 (lint cleanup) but its branch also carries the #104 fix commit `b6157c0` — the #104 fix is riding along in an unrelated PR, which makes it easy to miss at merge time. ## Expected behavior - The fix should be merged to `origin/main` and deployed (service restarted) before #104 is closed, or the closure deferred until the PR merges. ## Fix needed - Merge PR #113 (or cherry-pick `b6157c0` to `main`) and restart the :8080 service, then re-probe. See the companion issue (max_colors has no effect on running service) for the live-symptom detail. --- Kanban card: t_d25334c3 (post-deploy probe findings, qa board)

Mark added the

bug

label

2026-07-31 05:19:27 +00:00

Mark referenced this issue

2026-07-31 05:23:03 +00:00

Issue #105 closed but fix never landed on main — tests stranded in unmerged PR #113 #119

Mark referenced this issue

2026-07-31 05:23:03 +00:00

#105 tests assert intermediate unique_colors statistic — actual PES output is NOT color-capped (16 colors at max_colors=4/8) #120

Mark commented

2026-07-31 05:25:25 +00:00

Author

Owner

Re-probe confirmation (kanban card t_735e0479, qa board, 2026-07-30 22:15 UTC)

State UNCHANGED — the #104 fix is still not on main.

git merge-base --is-ancestor b6157c0 origin/main → still NO; origin/main tip is 40d2f3b (#103).
Fix commit b6157c0 still lives only on lint-cleanup/easystitch-111, head of open unmerged PR #113 (base main, titled for #111 lint cleanup — the #104 fix rides along on an unrelated PR).
Issue #104 remains closed despite the fix being unmerged and undeployed.

Still needs: merge PR #113 (or cherry-pick b6157c0 to main) + restart the :8080 uvicorn, then re-probe.

## Re-probe confirmation (kanban card t_735e0479, qa board, 2026-07-30 22:15 UTC) State **UNCHANGED** — the #104 fix is still not on main. - `git merge-base --is-ancestor b6157c0 origin/main` → still NO; origin/main tip is `40d2f3b` (#103). - Fix commit `b6157c0` still lives only on `lint-cleanup/easystitch-111`, head of open unmerged PR #113 (base main, titled for #111 lint cleanup — the #104 fix rides along on an unrelated PR). - Issue #104 remains closed despite the fix being unmerged and undeployed. Still needs: merge PR #113 (or cherry-pick `b6157c0` to main) + restart the :8080 uvicorn, then re-probe.

Mark closed this issue

2026-07-31 05:30:32 +00:00

Mark commented

2026-07-31 05:30:41 +00:00

Author

Owner

Fixed: PR #113 merged to origin/main on 2026-07-30; b6157c0 is now an ancestor of origin/main (merge commit 5baf0e5). Closing.

Fixed: PR #113 merged to origin/main on 2026-07-30; b6157c0 is now an ancestor of origin/main (merge commit 5baf0e5). Closing.