Mark/Kimi_Agent_Brother_10_Digitizing_App

Fork 0

Editor has no default-stitch-type setting — workspace has color simplification + thread library settings, but no setting to set the default stitch type for new paths #198

New issue

Closed

opened 2026-10-03 23:50:14 +00:00 by Mark · 1 comment

Mark commented

2026-10-03 23:50:14 +00:00

Owner

Finding

src/components/workspace/SettingsModal.tsx renders two settings sections:

ColorSimplificationSection (color count target, similarity threshold, etc.)
ThreadLibrarySection (CRUD for the user's thread library)

It does NOT render a "Default Stitch Type" or "Default Path Density" section. A new path drawn in the Editor starts with stitchType: 'satin' (per src/components/editor/constants.ts:57); the user can change it in the right panel after drawing, but the default is hard-coded.

grep -n 'defaultStitch\|stitchType.*default' src/components/editor/ returns 0 hits.

A user who designs 10 paths and wants them all to be fill (not satin) has to:

Draw path 1 (satin default)
Change to fill in the right panel
Draw path 2 (satin default)
Change to fill
... 6 more times

Or use the bulk select after #188 lands.

Where

Settings modal: src/components/workspace/SettingsModal.tsx (2 sections)
No default section: grep -n 'Default Stitch' src/components/workspace/SettingsModal.tsx returns 0 hits
Hard-coded default: src/components/editor/constants.ts:57 (stitchType: 'satin')
AutoDigitizeSettings exists: src/components/workspace/types.ts:208 (could host a defaultStitchType field)

Suggested fix shape

Add a "Path Defaults" section to the Settings modal:

<CollapsibleSection title="Path Defaults">
  <SelectRow
    label="Default stitch type"
    value={settings.defaultStitchType}
    options={['satin', 'fill', 'running', 'cross-stitch', 'zigzag']}
    onChange={(v) => setDefaultStitchType(v)}
  />
  <SliderRow
    label="Default density"
    value={settings.defaultDensity}
    min={0.1} max={1.0} step={0.1}
    onChange={(v) => setDefaultDensity(v)}
  />
</CollapsibleSection>

The settings persist in localStorage (the Settings modal already uses useLocalStorage). The Editor's handleFinishPath reads the default from localStorage when creating a new path.

Severity

Low. The user can change per-path. Power users with many paths of the same type notice.

Discovered by

Gap analysis (2026-10-02) of editor defaults.

#125 (open) — Settings modal: add Optional defaults sections. This is the same family of issue, scoped to the editor's path defaults specifically.
#188 (open) — Editor multi-path selection. Bulk apply vs per-path default are competing solutions; both are valid.

## Finding `src/components/workspace/SettingsModal.tsx` renders two settings sections: - `ColorSimplificationSection` (color count target, similarity threshold, etc.) - `ThreadLibrarySection` (CRUD for the user's thread library) It does NOT render a "Default Stitch Type" or "Default Path Density" section. A new path drawn in the Editor starts with `stitchType: 'satin'` (per `src/components/editor/constants.ts:57`); the user can change it in the right panel after drawing, but the default is hard-coded. `grep -n 'defaultStitch\|stitchType.*default' src/components/editor/` returns 0 hits. A user who designs 10 paths and wants them all to be fill (not satin) has to: 1. Draw path 1 (satin default) 2. Change to fill in the right panel 3. Draw path 2 (satin default) 4. Change to fill 5. ... 6 more times Or use the bulk select after #188 lands. ## Where - Settings modal: `src/components/workspace/SettingsModal.tsx` (2 sections) - No default section: `grep -n 'Default Stitch' src/components/workspace/SettingsModal.tsx` returns 0 hits - Hard-coded default: `src/components/editor/constants.ts:57` (`stitchType: 'satin'`) - AutoDigitizeSettings exists: `src/components/workspace/types.ts:208` (could host a `defaultStitchType` field) ## Suggested fix shape Add a "Path Defaults" section to the Settings modal: ```tsx <CollapsibleSection title="Path Defaults"> <SelectRow label="Default stitch type" value={settings.defaultStitchType} options={['satin', 'fill', 'running', 'cross-stitch', 'zigzag']} onChange={(v) => setDefaultStitchType(v)} /> <SliderRow label="Default density" value={settings.defaultDensity} min={0.1} max={1.0} step={0.1} onChange={(v) => setDefaultDensity(v)} /> </CollapsibleSection> ``` The settings persist in localStorage (the Settings modal already uses `useLocalStorage`). The Editor's `handleFinishPath` reads the default from localStorage when creating a new path. ## Severity Low. The user can change per-path. Power users with many paths of the same type notice. ## Discovered by Gap analysis (2026-10-02) of editor defaults. ## Related - #125 (open) — Settings modal: add Optional defaults sections. This is the same family of issue, scoped to the editor's path defaults specifically. - #188 (open) — Editor multi-path selection. Bulk apply vs per-path default are competing solutions; both are valid.

Mark added the

feature-request

triage-approved

labels

2026-10-03 23:50:14 +00:00

Mark referenced this issue

2026-10-04 00:02:06 +00:00

Editor has no 'apply same settings to all paths' — user with 10 paths that should all be fill / red / density 0.5 must edit each path one at a time #212

Mark referenced this issue

2026-10-04 00:04:20 +00:00

Workspace right panel's Object List has no per-object rename — user can't name a stitch object (e.g., 'flower' or 'border') so the Object List shows the generated default like 'Object 1' #218

Mark referenced this issue from a commit

2026-10-04 01:21:11 +00:00

fix(#198): Editor Path Defaults — Settings modal section + Editor reads default stitch type/density for new paths

Mark closed this issue

2026-10-04 01:21:11 +00:00

Mark commented

2026-10-04 01:23:04 +00:00

Author

Owner

Shipped via commit b556049 (fix(#198): Editor Path Defaults). Closing summary:

New src/components/workspace/pathDefaults.ts — versioned localStorage layer (tc_path_defaults_v1) with a usePathDefaults() hook (cross-tab storage event sync, mirrors the useThreadLibrary pattern from #126). Sanitize step clamps density to [0.1, 1.0] and rejects any stitch type that isn't in the editor's user-facing dropdown, so a hand-edited localStorage blob can't leave the Settings select showing a missing <option>.
New src/components/workspace/PathDefaultsSection.tsx — collapsible section matching the existing Thread Library / Color Simplification pattern. <select> for default stitch type (5 user-facing options: satin, fill, running, cross-stitch, zigzag) + the editor's same <Slider> for default density (0.1..1.0, step 0.05).
SettingsModal renders the new section as a third collapsible in the existing top-level border (default-open, like the other two).
Editor.tsx handleFinishPath now reads pathDefaults.defaultStitchType and pathDefaults.defaultDensity from the hook instead of the hard-coded 'satin' / 0.4. Dep array updated to include pathDefaults so a Settings-modal change propagates on the next drawn path.

Tests: 17 in pathDefaults.test.ts (load/save/sanitize/clamp/cross-tab sync) + 4 new in SettingsModal.test.tsx (section renders with in-code baseline, edits persist, persisted defaults reload, malformed payloads sanitize). Full vitest run: 551 passed in workspace + pages after rebase; the 3 pre-existing EditorCanvas (#170) snap-drag failures are unrelated. tsc -b clean, eslint clean.

A power user who designs 10 fill paths can now flip the default once in Settings instead of editing each path in the right panel — and the right-panel per-path controls still override per-path, so existing designs and workflows are unaffected.

Shipped via commit b556049 (`fix(#198): Editor Path Defaults`). Closing summary: - New `src/components/workspace/pathDefaults.ts` — versioned localStorage layer (`tc_path_defaults_v1`) with a `usePathDefaults()` hook (cross-tab `storage` event sync, mirrors the `useThreadLibrary` pattern from #126). Sanitize step clamps density to [0.1, 1.0] and rejects any stitch type that isn't in the editor's user-facing dropdown, so a hand-edited localStorage blob can't leave the Settings select showing a missing `<option>`. - New `src/components/workspace/PathDefaultsSection.tsx` — collapsible section matching the existing Thread Library / Color Simplification pattern. `<select>` for default stitch type (5 user-facing options: satin, fill, running, cross-stitch, zigzag) + the editor's same `<Slider>` for default density (0.1..1.0, step 0.05). - `SettingsModal` renders the new section as a third collapsible in the existing top-level border (default-open, like the other two). - `Editor.tsx` `handleFinishPath` now reads `pathDefaults.defaultStitchType` and `pathDefaults.defaultDensity` from the hook instead of the hard-coded `'satin'` / `0.4`. Dep array updated to include `pathDefaults` so a Settings-modal change propagates on the next drawn path. Tests: 17 in `pathDefaults.test.ts` (load/save/sanitize/clamp/cross-tab sync) + 4 new in `SettingsModal.test.tsx` (section renders with in-code baseline, edits persist, persisted defaults reload, malformed payloads sanitize). Full vitest run: 551 passed in workspace + pages after rebase; the 3 pre-existing `EditorCanvas (#170)` snap-drag failures are unrelated. `tsc -b` clean, eslint clean. A power user who designs 10 fill paths can now flip the default once in Settings instead of editing each path in the right panel — and the right-panel per-path controls still override per-path, so existing designs and workflows are unaffected.

Mark referenced this issue

2026-10-04 03:34:19 +00:00

Editor has no way to add a Path Defaults section's defaults to a path that already exists — user changes the default stitch type in Settings, but existing paths keep their old type, no 'apply defaults to all' button #249

Mark referenced this issue

2026-10-04 03:48:00 +00:00

Editor's Path Properties section's 'stitch type' dropdown is set per-path but not visually previewed — user picking 'satin' vs 'fill' sees no preview of what each type looks like, just the names #297

Mark referenced this issue

2026-10-04 03:48:22 +00:00

Editor has no 'reset to initial state' for path properties — user wanting to revert a path to its initial state has to Cmd+Z multiple times or manually change each field back #299

Mark referenced this issue

2026-10-04 03:49:23 +00:00

Editor's settings modal opens from the toolbar's gear icon but is named 'Settings' — confusing because the workspace has its own Settings modal that's identical; user opening it in the editor sees the workspace's thread library (which is correct) but… #306