Mark/Kimi_Agent_Brother_10_Digitizing_App

Fork 0

Editor's settings modal opens from the toolbar's gear icon but is named 'Settings' — confusing because the workspace has its own Settings modal that's identical; user opening it in the editor sees the workspace's thread library (which is correct) but… #306

New issue

Closed

opened 2026-10-04 03:49:23 +00:00 by Mark · 1 comment

Mark commented

2026-10-04 03:49:23 +00:00

Owner

Finding

The editor's toolbar has a Settings button that opens the same SettingsModal component as the workspace (per the snippet I saw earlier in EditorToolbar.tsx).

The two surfaces are:

Workspace's Settings: opens from the workspace's top bar
Editor's Settings: opens from the editor's toolbar

The component is the same (SettingsModal.tsx). The user can see:

Thread Library (custom thread colors)
Color Simplification Preview
Path Defaults (per #198)

All three are workspace-relevant (Color Simplification is for digitizing, not editing). Some of these don't make sense in the editor's context.

A user opens Settings in the editor:

Sees "Color Simplification Preview"
Wonders "I'm not in the workspace, why am I seeing this?"
Confused

The fix is either:

Filter the editor's Settings to only show editor-relevant sections (Thread Library, Path Defaults)
OR rename it to "Editor Preferences" or similar to make the context clear
OR add a sub-header showing which context the Settings is in

Where

Editor's Settings button: src/components/editor/EditorToolbar.tsx (gear icon)
SettingsModal: src/components/workspace/SettingsModal.tsx (same component, used in both places)
3 sections: ColorSimplificationSection, ThreadLibrarySection, PathDefaultsSection

Suggested fix shape

Contextual sections: add a context: 'workspace' | 'editor' prop to SettingsModal:

<SettingsModal open={showSettings} onClose={...} context="editor" />

In the modal, filter sections by context:

Editor: Thread Library, Path Defaults
Workspace: Thread Library, Color Simplification, Path Defaults

OR rename the modal's title:

Editor: "Editor Preferences" or "Thread Library & Defaults"
Workspace: "Workspace Settings"

OR add a sub-header: "Editor settings" / "Workspace settings" in the modal's title.

The most user-friendly is the contextual sections. The user doesn't see "Color Simplification" in the editor because it's not relevant.

Severity

Low. The user can ignore the irrelevant sections. New users notice the confusion.

Discovered by

Gap analysis (2026-10-02) of editor settings.

The SettingsModal is shared between editor and workspace (per the snippet). The context-aware behavior is the addition.
The 3 sections have different relevance: Thread Library is universal, Path Defaults is editor-specific, Color Simplification is workspace-specific.
Most apps have a context-aware Settings; this is a parity improvement.

## Finding The editor's toolbar has a Settings button that opens the same `SettingsModal` component as the workspace (per the snippet I saw earlier in `EditorToolbar.tsx`). The two surfaces are: - Workspace's Settings: opens from the workspace's top bar - Editor's Settings: opens from the editor's toolbar The component is the same (`SettingsModal.tsx`). The user can see: - Thread Library (custom thread colors) - Color Simplification Preview - Path Defaults (per #198) All three are workspace-relevant (Color Simplification is for digitizing, not editing). Some of these don't make sense in the editor's context. A user opens Settings in the editor: - Sees "Color Simplification Preview" - Wonders "I'm not in the workspace, why am I seeing this?" - Confused The fix is either: - Filter the editor's Settings to only show editor-relevant sections (Thread Library, Path Defaults) - OR rename it to "Editor Preferences" or similar to make the context clear - OR add a sub-header showing which context the Settings is in ## Where - Editor's Settings button: `src/components/editor/EditorToolbar.tsx` (gear icon) - SettingsModal: `src/components/workspace/SettingsModal.tsx` (same component, used in both places) - 3 sections: ColorSimplificationSection, ThreadLibrarySection, PathDefaultsSection ## Suggested fix shape 1. **Contextual sections**: add a `context: 'workspace' | 'editor'` prop to SettingsModal: ```tsx <SettingsModal open={showSettings} onClose={...} context="editor" /> ``` In the modal, filter sections by context: - Editor: Thread Library, Path Defaults - Workspace: Thread Library, Color Simplification, Path Defaults 2. **OR** rename the modal's title: - Editor: "Editor Preferences" or "Thread Library & Defaults" - Workspace: "Workspace Settings" 3. **OR** add a sub-header: "Editor settings" / "Workspace settings" in the modal's title. The most user-friendly is the contextual sections. The user doesn't see "Color Simplification" in the editor because it's not relevant. ## Severity Low. The user can ignore the irrelevant sections. New users notice the confusion. ## Discovered by Gap analysis (2026-10-02) of editor settings. ## Related - The SettingsModal is shared between editor and workspace (per the snippet). The context-aware behavior is the addition. - The 3 sections have different relevance: Thread Library is universal, Path Defaults is editor-specific, Color Simplification is workspace-specific. - Most apps have a context-aware Settings; this is a parity improvement.

Mark added the

feature-request

triage-approved

labels

2026-10-04 03:49:23 +00:00

Mark referenced this issue

2026-10-04 03:52:16 +00:00

Editor has no 'handle size' preference — small handles for fine work, large handles for fast interaction; the editor's node handles are a fixed size #323

Mark referenced this issue

2026-10-04 03:54:13 +00:00

Editor has no 'autosave' toggle — user can lose work to a crash with no autosave (only the session-restore per #161, which is best-effort), no explicit autosave preference #338

Mark referenced this issue from a commit

2026-10-04 21:46:35 +00:00

fix(#306): editor Settings modal filters out workspace-only Color Simplification section

Mark commented

2026-10-04 21:50:17 +00:00

Author

Owner

Closed by fix(#306) at commit 57dec27 on origin/main.

The editor's toolbar Settings button now passes context="editor" to SettingsModal. The modal:

Hides the Color Simplification Preview section (workspace-only — operates on an uploaded design image that the editor never has).
Renames the title to "Editor Preferences" so the user knows which surface they're configuring.
Keeps Thread Library (universal) and Path Defaults (controls new paths drawn in the editor).

The workspace passes no context and keeps its full three-section list.

Adds 3 tests pinning the new behavior (workspace-default keeps Color Simplification, editor hides it AND renames the title, editor keeps Thread Library + Path Defaults). All 20 SettingsModal tests pass; all 6 EditorToolbar tests pass.

Closed by fix(#306) at commit 57dec27 on origin/main. The editor's toolbar Settings button now passes `context="editor"` to SettingsModal. The modal: - Hides the Color Simplification Preview section (workspace-only — operates on an uploaded design image that the editor never has). - Renames the title to "Editor Preferences" so the user knows which surface they're configuring. - Keeps Thread Library (universal) and Path Defaults (controls new paths drawn in the editor). The workspace passes no context and keeps its full three-section list. Adds 3 tests pinning the new behavior (workspace-default keeps Color Simplification, editor hides it AND renames the title, editor keeps Thread Library + Path Defaults). All 20 SettingsModal tests pass; all 6 EditorToolbar tests pass.

Mark closed this issue

2026-10-04 21:50:20 +00:00

Mark referenced this issue from a commit

2026-10-05 01:48:52 +00:00

feat(#324): Light/Dark theme toggle via next-themes + Appearance section in Settings modal