#317 - Editor's Path Properties has a 'Density' slider (0-1) but no 'Spacing' input (in mm) — embroidery software typically shows density as mm-spacing (e.g., 0.4mm), not as a 0-1 ratio, the units are unfamiliar to embroidery users - Mark/Kimi_Agent_Brother_10_Digitizing_App - cyguin git: Adlerian Hierarchical Self-Actualization Syllogism

Mark commented

2026-10-04 03:51:23 +00:00

Owner

Finding

src/components/editor/EditorRightPanel.tsx's Path Properties section has a Density slider with values 0.0-1.0 (per the snippet earlier). The unit is unitless.

grep -n 'spacing\|mm.*spacing' src/components/editor/ returns 0. No mm-spacing input.

Embroidery convention is:

Density in stitches per mm (e.g., 4 stitches/mm for a satin column)
Spacing in mm (e.g., 0.4mm between stitches in a fill)
Coverage: the ratio (e.g., 0.4 = 40% covered)

The editor's "density" 0-1 maps to "spacing" mm, but the unit shown is unfamiliar. A user trained in embroidery sees "0.4" and thinks "what does that mean?"

The fix is to show the density in mm-spacing (e.g., "0.4mm" instead of "0.4"), or to add a unit toggle.

Where

Density slider: src/components/editor/EditorRightPanel.tsx (per the snippet)
No mm-spacing: grep -rn 'spacing' src/components/editor/ returns 0
PathDefaultsSection: src/components/workspace/PathDefaultsSection.tsx (also has density 0-1)

Suggested fix shape

UI: change the density slider's label and value display:

<SliderField
  label="Stitch spacing"
  value={1 - density}  // 0.0 density = 1.0 mm spacing
  onChange={(v) => onChangeDensity(1 - v)}
  min={0.1}
  max={1.0}
  step={0.05}
  unit="mm"
/>

density (0-1) maps to spacing (mm) via: spacing = 1 - density + 0.1 (e.g., 0.4 density = 0.7mm spacing; 0.8 density = 0.3mm spacing).

OR: keep the 0-1 density but add a "Show in mm" toggle that displays the equivalent mm spacing.
Help text: a small "0.4 = 0.7mm spacing" tooltip on the slider.
Default: the default of 0.4 maps to 0.7mm spacing, which is a reasonable satin spacing.

Severity

Low. The user can learn the unit. Power users with embroidery experience notice.

Discovered by

Gap analysis (2026-10-02) of editor path properties.

#314 (open) — Satin width. Same path properties; both are embroidery-specific parameters.
The PathDefaultsSection (per #198) is in the same boat; the units are unfamiliar.
Wilcom/Hatch use mm-spacing; the editor's 0-1 ratio is the abstraction.

## Finding `src/components/editor/EditorRightPanel.tsx`'s Path Properties section has a Density slider with values 0.0-1.0 (per the snippet earlier). The unit is unitless. `grep -n 'spacing\|mm.*spacing' src/components/editor/` returns 0. No mm-spacing input. Embroidery convention is: - Density in stitches per mm (e.g., 4 stitches/mm for a satin column) - Spacing in mm (e.g., 0.4mm between stitches in a fill) - Coverage: the ratio (e.g., 0.4 = 40% covered) The editor's "density" 0-1 maps to "spacing" mm, but the unit shown is unfamiliar. A user trained in embroidery sees "0.4" and thinks "what does that mean?" The fix is to show the density in mm-spacing (e.g., "0.4mm" instead of "0.4"), or to add a unit toggle. ## Where - Density slider: `src/components/editor/EditorRightPanel.tsx` (per the snippet) - No mm-spacing: `grep -rn 'spacing' src/components/editor/` returns 0 - PathDefaultsSection: `src/components/workspace/PathDefaultsSection.tsx` (also has density 0-1) ## Suggested fix shape 1. **UI**: change the density slider's label and value display: ```tsx <SliderField label="Stitch spacing" value={1 - density} // 0.0 density = 1.0 mm spacing onChange={(v) => onChangeDensity(1 - v)} min={0.1} max={1.0} step={0.05} unit="mm" /> ``` `density` (0-1) maps to `spacing` (mm) via: `spacing = 1 - density + 0.1` (e.g., 0.4 density = 0.7mm spacing; 0.8 density = 0.3mm spacing). 2. **OR**: keep the 0-1 density but add a "Show in mm" toggle that displays the equivalent mm spacing. 3. **Help text**: a small "0.4 = 0.7mm spacing" tooltip on the slider. 4. **Default**: the default of 0.4 maps to 0.7mm spacing, which is a reasonable satin spacing. ## Severity Low. The user can learn the unit. Power users with embroidery experience notice. ## Discovered by Gap analysis (2026-10-02) of editor path properties. ## Related - #314 (open) — Satin width. Same path properties; both are embroidery-specific parameters. - The PathDefaultsSection (per #198) is in the same boat; the units are unfamiliar. - Wilcom/Hatch use mm-spacing; the editor's 0-1 ratio is the abstraction.

Mark added the

feature-request

triage-approved

labels

2026-10-04 03:51:23 +00:00

Mark referenced this issue

2026-10-04 03:56:11 +00:00

Editor's Path Properties has a 'Density' slider but no 'Stitch length' field — embroidery exports typically specify stitch length in mm (e.g., 3.0 mm), the editor's 0-1 density doesn't expose this #351

Mark referenced this issue

2026-10-04 03:58:20 +00:00

Editor's Path Properties has 'Path length' but no 'stitch length per path' — user wanting different stitch lengths for different paths (e.g., 3mm for outlines, 2.5mm for fills) has no per-path setting #368

Mark referenced this issue

2026-10-04 03:58:58 +00:00

Editor's Path Properties has 'Stitch type' but the 'satin' path's satin width is not visible as a number — user wanting to see the current width in mm has to navigate to a hidden setting #371

Mark referenced this issue

2026-10-04 03:59:16 +00:00

Editor's Path Properties has 'Stitch type' but the 'fill' path's fill parameters (angle, spacing) are not exposed — user with a fill path wanting to set the fill angle (e.g., 45°) has no UI #373

Mark referenced this issue

2026-10-04 04:00:21 +00:00

Editor's Path Properties has 'Path length' but no 'stitches per mm' / 'stitch density' — user with an embroidery background thinks in stitches per mm (e.g., 4 stitches/mm), the editor's 0-1 density doesn't expose this #379

Mark referenced this issue

2026-10-04 04:12:50 +00:00

Editor's Path Properties has a 'Density' slider but no 'Stitch length' field — embroidery exports typically specify stitch length in mm (e.g., 3.0 mm), the editor's 0-1 density doesn't expose this #351

Mark referenced this issue

2026-10-04 04:13:01 +00:00

Editor's Path Properties has 'Path length' but no 'stitch length per path' — user wanting different stitch lengths for different paths (e.g., 3mm for outlines, 2.5mm for fills) has no per-path setting #368

Mark referenced this issue

2026-10-04 04:13:13 +00:00

Editor's Path Properties has 'Path length' but no 'stitches per mm' / 'stitch density' — user with an embroidery background thinks in stitches per mm (e.g., 4 stitches/mm), the editor's 0-1 density doesn't expose this #379

Mark referenced this issue from a commit

2026-10-04 23:34:33 +00:00

fix(#317): editor Path Properties density slider now shows mm spacing

Mark commented

2026-10-04 23:35:08 +00:00

Author

Owner

Closed by fix commit 88743fc on main — Path Properties density row is now labelled "Stitch spacing" with the value suffixed by mm (e.g. Stitch spacing: 0.40mm), plus a tooltip explaining the convention and a screen-reader aria-label that names the unit. Same change applied to the Settings modal's Path Defaults row (Default stitch spacing: 0.40mm).

The underlying data shape (density 0.10..1.00 used as spacing_mm in estimateThreadUsageMeters / estimateStitchTimeMinutes) is unchanged — only the user-visible label, the tooltip, and the aria-label were touched. Persisted JSON shape (PathDefaults.defaultDensity) is also unchanged.

Tests:

src/components/editor/issue-317.test.tsx (new) — pins the new label, aria-label, and Mixed (primary 0.30mm) placeholder for the right-panel slider.
src/components/workspace/issue-317-path-defaults.test.tsx (new) — pins the same shape for the Settings modal Path Defaults row.
src/components/editor/EditorRightPanel.test.tsx — two assertions updated to match the new label/aria-label wording.

Full suite: 1921 passed / 3 pre-existing failures (issue-275 testid collisions with Color Simplification Preview's subtitle; unrelated to this fix).

Closed by fix commit 88743fc on `main` — Path Properties density row is now labelled "Stitch spacing" with the value suffixed by `mm` (e.g. `Stitch spacing: 0.40mm`), plus a tooltip explaining the convention and a screen-reader aria-label that names the unit. Same change applied to the Settings modal's Path Defaults row (`Default stitch spacing: 0.40mm`). The underlying data shape (density 0.10..1.00 used as spacing_mm in `estimateThreadUsageMeters` / `estimateStitchTimeMinutes`) is unchanged — only the user-visible label, the tooltip, and the aria-label were touched. Persisted JSON shape (`PathDefaults.defaultDensity`) is also unchanged. Tests: - `src/components/editor/issue-317.test.tsx` (new) — pins the new label, aria-label, and `Mixed (primary 0.30mm)` placeholder for the right-panel slider. - `src/components/workspace/issue-317-path-defaults.test.tsx` (new) — pins the same shape for the Settings modal Path Defaults row. - `src/components/editor/EditorRightPanel.test.tsx` — two assertions updated to match the new label/aria-label wording. Full suite: 1921 passed / 3 pre-existing failures (issue-275 testid collisions with Color Simplification Preview's subtitle; unrelated to this fix).

Mark closed this issue

2026-10-04 23:35:15 +00:00

Mark referenced this issue

2026-10-04 23:56:56 +00:00

Editor's path list shows path name but no preview thumbnail — user with 30 paths can't tell what each path looks like without clicking it; the only visual is the canvas itself #320

Mark referenced this issue

2026-10-05 00:42:42 +00:00

Gallery has no 'compare two designs side-by-side' view — user with two design variants wanting to see the differences at a glance has to flip between them #321

Mark referenced this issue from a commit

2026-10-05 13:07:30 +00:00

feat(#357): Per-path estimated stitch count in Path Info

Mark referenced this issue from a commit