Mark/Kimi_Agent_Brother_10_Digitizing_App

Fork 0

Editor has no 'pull compensation' setting per path — pull compensation is a critical embroidery parameter (compensates for thread tension), but the editor doesn't expose it #318

New issue

Closed

opened 2026-10-04 03:51:23 +00:00 by Mark · 1 comment

Mark commented

2026-10-04 03:51:23 +00:00

Owner

Finding

grep -rn 'pullCompensation\|pullComp' src/components/editor/ returns 0. The editor has no pull compensation.

Pull compensation: embroidery thread "pulls" the fabric as it stitches, causing the design to shrink or distort. To compensate, the digitizer slightly enlarges the design (typically 0.2-0.5mm).

Most embroidery software has a pull compensation setting per path or per design.

A user designing a logo:

Knows the design will pull in 0.3mm
Wants to add 0.3mm to all path sizes
Currently: can't; would have to manually adjust each node

The fix is a pull compensation input.

Where

Path Properties: src/components/editor/EditorRightPanel.tsx
No pull comp: grep -rn 'pullComp' src/components/editor/ returns 0
The export: src/lib/easystitch-client.ts:exportPES (might have pull comp)

Suggested fix shape

Type: add pullCompensation: number to the StitchPath type (default 0).
UI: an input in the Path Properties section:

<NumberField
  label="Pull compensation"
  value={p.pullCompensation}
  onChange={(v) => onUpdatePullCompensation(p.id, v)}
  min={-1}
  max={1}
  step={0.05}
  unit="mm"
/>

Behavior: at export time, the path's geometry is offset outward by pullCompensation mm.
Default: 0 (no compensation). The user can set per-path or as a design-wide default.
Design-wide default: a setting in Path Defaults (per #198) for "Default pull compensation."

Severity

Medium. Pull compensation is a critical parameter for production embroidery. Power users notice.

Discovered by

Gap analysis (2026-10-02) of editor path properties.

#314 (open) — Satin width. Same embroidery-specific parameters.
#316 (open) — Stitch spacing in mm. Same units concern.
Wilcom/Hatch have pull comp; the editor's gap is a parity issue.

## Finding `grep -rn 'pullCompensation\|pullComp' src/components/editor/` returns 0. The editor has no pull compensation. Pull compensation: embroidery thread "pulls" the fabric as it stitches, causing the design to shrink or distort. To compensate, the digitizer slightly enlarges the design (typically 0.2-0.5mm). Most embroidery software has a pull compensation setting per path or per design. A user designing a logo: - Knows the design will pull in 0.3mm - Wants to add 0.3mm to all path sizes - Currently: can't; would have to manually adjust each node The fix is a pull compensation input. ## Where - Path Properties: `src/components/editor/EditorRightPanel.tsx` - No pull comp: `grep -rn 'pullComp' src/components/editor/` returns 0 - The export: `src/lib/easystitch-client.ts:exportPES` (might have pull comp) ## Suggested fix shape 1. **Type**: add `pullCompensation: number` to the StitchPath type (default 0). 2. **UI**: an input in the Path Properties section: ```tsx <NumberField label="Pull compensation" value={p.pullCompensation} onChange={(v) => onUpdatePullCompensation(p.id, v)} min={-1} max={1} step={0.05} unit="mm" /> ``` 3. **Behavior**: at export time, the path's geometry is offset outward by `pullCompensation` mm. 4. **Default**: 0 (no compensation). The user can set per-path or as a design-wide default. 5. **Design-wide default**: a setting in Path Defaults (per #198) for "Default pull compensation." ## Severity Medium. Pull compensation is a critical parameter for production embroidery. Power users notice. ## Discovered by Gap analysis (2026-10-02) of editor path properties. ## Related - #314 (open) — Satin width. Same embroidery-specific parameters. - #316 (open) — Stitch spacing in mm. Same units concern. - Wilcom/Hatch have pull comp; the editor's gap is a parity issue.

Mark added the

feature-request

triage-approved

labels

2026-10-04 03:51:23 +00:00

Mark referenced this issue

2026-10-04 03:51:42 +00:00

Editor has no 'underlay' settings per path — underlay is a critical embroidery parameter (the base layer of stitches that stabilizes the main stitches), but the editor doesn't expose it #319

Mark referenced this issue

2026-10-04 04:13:14 +00:00

Editor's Path Properties has 'Stitch type' but the 'cross-stitch' type has no per-stitch size input (cross-stitch X-size) — user wanting to control the cross-stitch size has no UI #390

Mark referenced this issue from a commit

2026-10-05 00:42:33 +00:00

fix(#318): editor pull-compensation input — right-panel mm offset per path

Mark referenced this issue from a commit

2026-10-05 00:42:33 +00:00

test(#319): lock down editor underlay controls — panel rendering + Editor wiring

Mark referenced this issue from a commit

2026-10-05 00:42:33 +00:00

Apply changes from kilo-gsd.py run for Mark/Kimi_Agent_Brother_10_Digitizing_App#318

Mark referenced this issue from a commit

2026-10-05 11:32:48 +00:00

feat(#352): precise rotation input in Path Properties Transform section

Mark referenced this issue

2026-10-05 11:33:57 +00:00

Editor has no 'rotate path' input — user with a path at a specific angle (e.g., 30°) wanting to set it precisely has to drag-and-rotate (slow) or no input #352

Mark referenced this issue

2026-10-05 13:46:28 +00:00

Editor's Node Properties section has 'X' and 'Y' displays but no 'X input' / 'Y input' to type a precise position — user wanting to nudge a node by 0.5mm has to drag (low precision) #360

Mark commented

2026-10-05 14:42:08 +00:00

Author

Owner

Closed retroactively after fix landed on main in 39d71dd ("fix(#318): editor pull-compensation input — right-panel mm offset per path"). That commit's diff: types.ts gained pullCompensation?: number on StitchPath; EditorRightPanel.tsx got the new NumberField in Path Properties (range −1..1 mm, 0.05 step) plus the apply-to-all button mirroring the #212 density / #314 satin-width pattern; Editor.tsx wired the selection-scoped handler and forwarded the value through pathsToStitchObjects into WorkspaceStitchObject.pullCompensation so exportPES sees the user's mm offset end-to-end. New test files: src/components/editor/issue-318.test.tsx (10 panel tests — render, live value, legacy fallback, apply-to-all, Mixed label, range clamp, conditional rendering) and an Editor.test.tsx block driving the panel callback and asserting the tc_workspace_snapshot's stitchObject carries the user-set pullCompensation. The kilo-gsd run for #318 hit push-rejected (fetch first) on the bugfix-recovery push and left a salvage marker; the fix had already landed via the earlier review-pass commit 39d71dd before the recovery push attempted the second 416 "Apply changes" commit. Watcher t_b85af413 closing #318 with this comment.

Closed retroactively after fix landed on main in 39d71dd ("fix(#318): editor pull-compensation input — right-panel mm offset per path"). That commit's diff: types.ts gained `pullCompensation?: number` on StitchPath; EditorRightPanel.tsx got the new NumberField in Path Properties (range −1..1 mm, 0.05 step) plus the apply-to-all button mirroring the #212 density / #314 satin-width pattern; Editor.tsx wired the selection-scoped handler and forwarded the value through pathsToStitchObjects into WorkspaceStitchObject.pullCompensation so exportPES sees the user's mm offset end-to-end. New test files: src/components/editor/issue-318.test.tsx (10 panel tests — render, live value, legacy fallback, apply-to-all, Mixed label, range clamp, conditional rendering) and an Editor.test.tsx block driving the panel callback and asserting the tc_workspace_snapshot's stitchObject carries the user-set pullCompensation. The kilo-gsd run for #318 hit push-rejected (`fetch first`) on the bugfix-recovery push and left a salvage marker; the fix had already landed via the earlier review-pass commit 39d71dd before the recovery push attempted the second 416 "Apply changes" commit. Watcher t_b85af413 closing #318 with this comment.

Mark closed this issue

2026-10-05 14:42:15 +00:00

Mark referenced this issue

2026-10-05 20:45:06 +00:00

Editor's Path Properties has 'Stitch type' but the 'cross-stitch' type has no per-stitch size input (cross-stitch X-size) — user wanting to control the cross-stitch size has no UI #390