Mark/transcriber
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

EnhancementQueueWorker is a no-op: no code path ever enqueues an EnhancementJob #135

New issue
Closed
opened 2026-08-14 06:06:05 +00:00 by Mark · 1 comment
Mark commented 2026-08-14 06:06:05 +00:00
Owner
Copy link

The enhancement queue shipped in #133 (commit 39af1b3) can never process anything: EnhancementJobRepository.queueJob() has zero call sites in app code. Verified on origin/main (1b1c329, 2026-08-14): grep for queueJob( across app/src/main matches only EnhancementJobRepository.kt itself; the only EnhancementJob( constructor reference outside entity/repo/dao is the entity data class declaration (EnhancementJob.kt:34).

Actual behavior:

  1. Cloud diarization / LLM topic extraction / summarization / title generation are skipped when the device is offline (per EnhancementJob KDoc: "Created when a cloud feature ... is skipped because the device is offline").
  2. No offline path was changed to call queueJob() — the worker's getPendingJobsList() always returns empty.
  3. EnhancementQueueWorker runs on schedule but finds nothing to do; offline-skipped features are never re-processed.

Expected: any cloud feature that is skipped while offline enqueues an EnhancementJob so the worker re-processes it once connectivity returns.

Reproduction:

  • grep -rn "queueJob(" app/src/main/ --include="*.kt" -> only EnhancementJobRepository.kt
  • grep -rn "EnhancementJob(" app/src/main/ --include="*.kt" -> only the entity data class

Filed from kanban card t_a946c33c (post-deploy probe of Mark/transcriber#133). Issue #133 was closed 2026-08-13 without addressing this; it was kilo-gsd's own review-phase blocking issue #1, unaddressed.

The enhancement queue shipped in #133 (commit 39af1b3) can never process anything: `EnhancementJobRepository.queueJob()` has zero call sites in app code. Verified on origin/main (1b1c329, 2026-08-14): grep for `queueJob(` across app/src/main matches only EnhancementJobRepository.kt itself; the only `EnhancementJob(` constructor reference outside entity/repo/dao is the entity data class declaration (EnhancementJob.kt:34). Actual behavior: 1. Cloud diarization / LLM topic extraction / summarization / title generation are skipped when the device is offline (per EnhancementJob KDoc: "Created when a cloud feature ... is skipped because the device is offline"). 2. No offline path was changed to call queueJob() — the worker's getPendingJobsList() always returns empty. 3. EnhancementQueueWorker runs on schedule but finds nothing to do; offline-skipped features are never re-processed. Expected: any cloud feature that is skipped while offline enqueues an EnhancementJob so the worker re-processes it once connectivity returns. Reproduction: - `grep -rn "queueJob(" app/src/main/ --include="*.kt"` -> only EnhancementJobRepository.kt - `grep -rn "EnhancementJob(" app/src/main/ --include="*.kt"` -> only the entity data class Filed from kanban card t_a946c33c (post-deploy probe of Mark/transcriber#133). Issue #133 was closed 2026-08-13 without addressing this; it was kilo-gsd's own review-phase blocking issue #1, unaddressed.
Mark 2026-08-14 06:06:05 +00:00
  • closed this issue
  • added the
    bug
         label
Mark 2026-08-14 18:08:43 +00:00
Mark commented 2026-08-14 18:09:48 +00:00
Author
Owner
Copy link

Reopened: false-positive close — fix never landed on main; bug is still live.

Post-deploy probe (kanban card t_81cc963e) confirmed this issue was closed while the fix commit was stranded on a branch and never merged. Verified live against the Forgejo API on 2026-08-14.

Summary

  • Issue closed: 2026-08-14T14:14:36Z
  • Fix commit bd5521c863 ("fix: enqueue EnhancementJobs when cloud features are skipped offline (#135)") exists ONLY on branch feat/enhancement-queue-tests-139.
  • git merge-base --is-ancestor bd5521c origin/main -> NO. No commit on main references #135.
  • The bug symptom described in this issue is still present on main.

Timeline (UTC)

  1. 2026-08-14T06:06:05Z — this issue filed: "EnhancementQueueWorker is a no-op: no code path ever enqueues an EnhancementJob".
  2. 2026-08-14T14:00:01Z — PR #141 merged to main at 9a8d9efe97 (merged branch tip 6abb7a35fe, tests for #139).
  3. 2026-08-14T14:02:00Z — fix commit bd5521c863 authored, pushed ON TOP of 6abb7a35fe AFTER the branch was already merged. Branch head is now f93823f011 (see related note).
  4. 2026-08-14T14:14:36Z — this issue closed (12 min after the fix was authored, but the fix was never merged).
  5. CI: run 5721 (sha=bd5521c) status=cancelled; run 5720 (main merge 9a8d9ef) status=success.

Reproduction steps

  1. git clone (or fetch) Mark/transcriber and check out main (tip 9a8d9efe97).
  2. Grep for call sites of queueJob(: only the repo declaration itself exists (EnhancementJobRepository.kt:13). Zero call sites in app code.
  3. Grep for EnhancementJob(: only the entity data class (EnhancementJob.kt:34).
  4. Run any offline flow where cloud features are skipped — no EnhancementJob is ever enqueued, so EnhancementQueueWorker has nothing to process.

Actual vs expected

  • Expected: when cloud features are skipped (offline), an EnhancementJob is enqueued so EnhancementQueueWorker can process it. Fix commit bd5521c863 implements exactly this.
  • Actual (on main): no code path ever enqueues an EnhancementJob — the worker is a no-op. The fix exists only on branch feat/enhancement-queue-tests-139.

Evidence

  • bd5521c863 is the direct child of 6abb7a35fe on the feature branch; 6abb7a35fe was already merged to main via PR #141 at 14:00:01Z, so bd5521c863 was pushed after the merge.
  • No open PR carries bd5521c863: open PRs are only #142 (feat/credential-regression-tests-138 -> main, for #138).
  • The fix branch's CI run (5721) was cancelled — never green.
  • Branch feat/enhancement-queue-tests-139 currently has head f93823f011 (a #140 verification commit) with bd5521c863 as its parent — both commits are absent from main.

Action needed

Land bd5521c863 on main — open a new PR from feat/enhancement-queue-tests-139 (or cherry-pick) into main, get CI green on main, then re-close this issue. Reopened with triage-approved + bug labels so the fixit pipeline routes it back.

Related note (dispatcher)

Branch head f93823f011 ("EnhancementQueueSchedulerTest compile fix verified for #140") is also stranded on the same branch, but its own message states the #140 compile errors were already resolved on main by f4346e6639 + d976dd9301 — both present in main's log, with main CI green (run 5720). #140's close at 2026-08-14T14:41:51Z therefore appears legitimate; the stranded commit is a redundant verification, not a missing fix. No action needed on #140 beyond awareness.

Kanban source card: t_81cc963e (qa board).

**Reopened: false-positive close — fix never landed on main; bug is still live.** Post-deploy probe (kanban card `t_81cc963e`) confirmed this issue was closed while the fix commit was stranded on a branch and never merged. Verified live against the Forgejo API on 2026-08-14. ## Summary - Issue closed: 2026-08-14T14:14:36Z - Fix commit `bd5521c863` ("fix: enqueue EnhancementJobs when cloud features are skipped offline (#135)") exists ONLY on branch `feat/enhancement-queue-tests-139`. - `git merge-base --is-ancestor bd5521c origin/main` -> NO. No commit on `main` references #135. - The bug symptom described in this issue is still present on `main`. ## Timeline (UTC) 1. 2026-08-14T06:06:05Z — this issue filed: "EnhancementQueueWorker is a no-op: no code path ever enqueues an EnhancementJob". 2. 2026-08-14T14:00:01Z — PR #141 merged to main at `9a8d9efe97` (merged branch tip `6abb7a35fe`, tests for #139). 3. 2026-08-14T14:02:00Z — fix commit `bd5521c863` authored, pushed ON TOP of `6abb7a35fe` AFTER the branch was already merged. Branch head is now `f93823f011` (see related note). 4. 2026-08-14T14:14:36Z — this issue closed (12 min after the fix was authored, but the fix was never merged). 5. CI: run 5721 (sha=bd5521c) status=cancelled; run 5720 (main merge 9a8d9ef) status=success. ## Reproduction steps 1. `git clone` (or fetch) `Mark/transcriber` and check out `main` (tip `9a8d9efe97`). 2. Grep for call sites of `queueJob(`: only the repo declaration itself exists (`EnhancementJobRepository.kt:13`). **Zero call sites in app code.** 3. Grep for `EnhancementJob(`: only the entity data class (`EnhancementJob.kt:34`). 4. Run any offline flow where cloud features are skipped — no `EnhancementJob` is ever enqueued, so `EnhancementQueueWorker` has nothing to process. ## Actual vs expected - **Expected:** when cloud features are skipped (offline), an `EnhancementJob` is enqueued so `EnhancementQueueWorker` can process it. Fix commit `bd5521c863` implements exactly this. - **Actual (on main):** no code path ever enqueues an `EnhancementJob` — the worker is a no-op. The fix exists only on branch `feat/enhancement-queue-tests-139`. ## Evidence - `bd5521c863` is the direct child of `6abb7a35fe` on the feature branch; `6abb7a35fe` was already merged to main via PR #141 at 14:00:01Z, so `bd5521c863` was pushed after the merge. - No open PR carries `bd5521c863`: open PRs are only #142 (`feat/credential-regression-tests-138` -> main, for #138). - The fix branch's CI run (5721) was cancelled — never green. - Branch `feat/enhancement-queue-tests-139` currently has head `f93823f011` (a #140 verification commit) with `bd5521c863` as its parent — both commits are absent from `main`. ## Action needed Land `bd5521c863` on `main` — open a new PR from `feat/enhancement-queue-tests-139` (or cherry-pick) into `main`, get CI green on `main`, then re-close this issue. Reopened with `triage-approved` + `bug` labels so the fixit pipeline routes it back. ## Related note (dispatcher) Branch head `f93823f011` ("EnhancementQueueSchedulerTest compile fix verified for #140") is also stranded on the same branch, but its own message states the #140 compile errors were already resolved on main by `f4346e6639` + `d976dd9301` — both present in main's log, with main CI green (run 5720). #140's close at 2026-08-14T14:41:51Z therefore appears legitimate; the stranded commit is a redundant verification, not a missing fix. No action needed on #140 beyond awareness. Kanban source card: `t_81cc963e` (qa board).
Mark closed this issue 2026-09-08 22:44:41 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
blocked:children

Blocked by child issues

  
blocked:needs-decision

   
blocked:needs-human

   
blocked:verify-failed

   
bug

Something is broken

  
deferred

Deferred — will revisit later

  
enhancement

New feature or request

  
feature-request

   
in-progress

   
needs-decompose

   
needs-triage

   
quickfix

   
triage-approved

Approved by triage — ready for fixer pipeline

No labels
blocked:children
blocked:needs-decision
blocked:needs-human
blocked:verify-failed
bug
deferred
enhancement
feature-request
in-progress
needs-decompose
needs-triage
quickfix
triage-approved
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Mark/transcriber#135
No description provided.