Stop silent STT credential fallback for LLM/diarization (#138) #142

Merged

Mark merged 1 commit from feat/credential-regression-tests-138 into main

2026-09-10 13:05:40 +00:00

Mark commented

2026-08-14 14:25:21 +00:00

Owner

Fixes #138

Stops EnhancementQueueWorker from silently falling back to STT credentials (cloudSettings.apiKey / endpointUrl) when LLM or diarization provider settings are blank. The implementation fix landed on main via the kilo-gsd pipeline (commit 35eeb93); this PR carries the regression tests that lock the behavior in, and the branch history includes the fix commit.

Changes (1 file, +75 lines):

app/src/test/java/com/voicetranscriber/service/EnhancementQueueWorkerTest.kt — two new worker-level regression tests
- doWork_diarizationJob_sttOnlyCredentials_diarizationSkippedAndMessageNamesDiarizationKey: blank diarizationApiKey -> "Diarization API key not configured", provider repos never contacted
- doWork_topicExtractionJob_sttOnlyCredentials_noLlmCallAndMessageNamesMissingLlmSetting: blank LLM fields -> "No LLM configured for topic extraction", Mockito spies prove no LLM call occurred
Existing EnhancementQueueWorkerConfigTest.kt (7 tests) already covers all-populated behavior unchanged.

Test evidence: full suite green — 214 tests, 0 failures, 0 errors (./gradlew :app:test).

Scope: only EnhancementQueueWorkerTest.kt is touched. No STT behavior, config loader, or other providers were changed.

References kanban card t_a946c33c.

Fixes #138 Stops EnhancementQueueWorker from silently falling back to STT credentials (cloudSettings.apiKey / endpointUrl) when LLM or diarization provider settings are blank. The implementation fix landed on main via the kilo-gsd pipeline (commit 35eeb93); this PR carries the regression tests that lock the behavior in, and the branch history includes the fix commit. Changes (1 file, +75 lines): - app/src/test/java/com/voicetranscriber/service/EnhancementQueueWorkerTest.kt — two new worker-level regression tests - doWork_diarizationJob_sttOnlyCredentials_diarizationSkippedAndMessageNamesDiarizationKey: blank diarizationApiKey -> "Diarization API key not configured", provider repos never contacted - doWork_topicExtractionJob_sttOnlyCredentials_noLlmCallAndMessageNamesMissingLlmSetting: blank LLM fields -> "No LLM configured for topic extraction", Mockito spies prove no LLM call occurred - Existing EnhancementQueueWorkerConfigTest.kt (7 tests) already covers all-populated behavior unchanged. Test evidence: full suite green — 214 tests, 0 failures, 0 errors (./gradlew :app:test). Scope: only EnhancementQueueWorkerTest.kt is touched. No STT behavior, config loader, or other providers were changed. References kanban card t_a946c33c.

Mark added 1 commit

2026-08-14 14:25:21 +00:00