test(#280): integration test for full Discord delivery pipeline (#234 + #270/#271/#272/#273) #283

Merged

Mark merged 8 commits from wt/integration-verify into master 2026-08-20 10:14:20 +00:00

Conversation 0 Commits 8 Files changed 4 +1248

Mark commented 2026-08-14 17:30:21 +00:00

Owner

Copy link

Summary

Drives a synthetic MeshIntentResult payload through DiscordBotService._run_intent for each of the four canonical result shapes, exercising the full end-to-end pipeline:

typing indicator (open) -> run intent (poll loop) -> render embed (or plain text)
  -> split() if > 2000 chars -> attach file if > attachment_threshold -> typing (close)

The test confirms every sibling component landed in its deliverable shape:

• #270 splitter — split() is invoked inside the chat formatter; long prose produces multiple ResponseParts, each at or below Discord's 2000-char message limit; nested code-fence integrity is preserved across the split stream.
• #271 embed builder — EmbedBuilder is exercised via the typed MeshIntentResult path; IntentType.RESEARCH produces a research embed with title/description/fields/footer/color within the 6000-char total budget.
• #272 progress indicator — async with progress(channel, intent_id) opens the typing context manager before the poll loop and exits cleanly on completion or error.
• #273 attachment handler — attachment_threshold triggers _format_chat_attachment; a discord.File is uploaded and a summary message references the attachment.

Test scenarios

Scenario	Shape tested
test_short_chat_response_*	short
test_long_prose_response_*	long prose (split)
test_response_with_code_blocks_*	with code blocks (fences)
test_oversized_response_is_*	with file (attachment)
test_research_intent_runs_full_*	full pipeline + embed

Plus four TestComponentsPresent.* tests that import each component directly from runtime to prove they're package-exported and individually usable.

Verification

• pytest tests/unit/test_delivery_pipeline_integration.py -> 9 passed in 0.25s
• pytest tests/unit/{test_delivery_pipeline_integration,test_discord_response,test_discord_commands,test_discord_progress,test_embed_builder_intents,test_discord_bot}.py -> 136/136 passed
• ruff check tests/unit/test_delivery_pipeline_integration.py -> clean
• black tests/unit/test_delivery_pipeline_integration.py -> formatted
• Pre-commit hooks all passed

References

• Forgejo #280 (this work)
• #234 (base response delivery formatter, closed)
• #270 (splitter delta, closed)
• #271 (embed builder delta, closed)
• #272 (progress indicator + bot wiring, closed)
• #273 (attachment handler delta, closed)

Kanban

Closes t_b702138a (verifier integration verification).

## Summary Drives a synthetic `MeshIntentResult` payload through `DiscordBotService._run_intent` for each of the four canonical result shapes, exercising the full end-to-end pipeline: ``` typing indicator (open) -> run intent (poll loop) -> render embed (or plain text) -> split() if > 2000 chars -> attach file if > attachment_threshold -> typing (close) ``` The test confirms every sibling component landed in its deliverable shape: - **#270 splitter** — `split()` is invoked inside the chat formatter; long prose produces multiple `ResponsePart`s, each at or below Discord's 2000-char message limit; nested code-fence integrity is preserved across the split stream. - **#271 embed builder** — `EmbedBuilder` is exercised via the typed `MeshIntentResult` path; `IntentType.RESEARCH` produces a research embed with title/description/fields/footer/color within the 6000-char total budget. - **#272 progress indicator** — `async with progress(channel, intent_id)` opens the typing context manager before the poll loop and exits cleanly on completion or error. - **#273 attachment handler** — `attachment_threshold` triggers `_format_chat_attachment`; a `discord.File` is uploaded and a summary message references the attachment. ## Test scenarios | Scenario | Shape tested | | ------------------------------------- | ------------------------- | | `test_short_chat_response_*` | short | | `test_long_prose_response_*` | long prose (split) | | `test_response_with_code_blocks_*` | with code blocks (fences) | | `test_oversized_response_is_*` | with file (attachment) | | `test_research_intent_runs_full_*` | full pipeline + embed | Plus four `TestComponentsPresent.*` tests that import each component directly from `runtime` to prove they're package-exported and individually usable. ## Verification - `pytest tests/unit/test_delivery_pipeline_integration.py` -> **9 passed in 0.25s** - `pytest tests/unit/{test_delivery_pipeline_integration,test_discord_response,test_discord_commands,test_discord_progress,test_embed_builder_intents,test_discord_bot}.py` -> **136/136 passed** - `ruff check tests/unit/test_delivery_pipeline_integration.py` -> clean - `black tests/unit/test_delivery_pipeline_integration.py` -> formatted - Pre-commit hooks all passed ## References - Forgejo #280 (this work) - #234 (base response delivery formatter, closed) - #270 (splitter delta, closed) - #271 (embed builder delta, closed) - #272 (progress indicator + bot wiring, closed) - #273 (attachment handler delta, closed) ## Kanban Closes `t_b702138a` (verifier integration verification).

Mark added 1 commit 2026-08-14 17:30:21 +00:00

test(#280): integration test for full Discord delivery pipeline (#234 + #270/#271/#272/#273) ... f9a130fbba

Drives a synthetic MeshIntentResult payload through DiscordBotService._run_intent
for each of the four canonical result shapes: short, long prose, code blocks,
and with file. Plus a research-intent scenario exercising every component.

Refs: #234, #270, #271, #272, #273, #280
Kanban: closes t_b702138a (verifier integration verification).

Mark added 1 commit 2026-08-20 08:51:30 +00:00

test(#280): extract shared attachment constants into tests/unit/_constants.py (sourced from #273 allowlist rules) ... 0b6dcf30e0

Centralize the attachment_threshold (4000) and 8MB cap (8*1024*1024) magic
numbers pulled from the Forgejo #273 allowlist rules, implemented as
DEFAULT_ATTACHMENT_THRESHOLD / DEFAULT_ATTACHMENT_SIZE_CAP in
runtime/discord_response.py. Add a comment linking back to #273 so a future
maintainer can audit the source.

Acceptance: from tests.unit._constants import ATTACHMENT_THRESHOLD_BYTES,
MAX_DISCORD_FILE_BYTES; ruff check tests/unit/ clean.

Mark referenced this pull request from a commit 2026-08-20 08:57:19 +00:00

test(#280): add deterministic MeshIntentResult factory helpers for five shapes

Mark added 1 commit 2026-08-20 08:57:20 +00:00

test(#280): add deterministic MeshIntentResult factory helpers for five shapes ... d4a9ad629a

Exposes short / long_prose / code_block / with_file / research factory
functions in tests/unit/factories.py, each returning a fully-formed
MeshIntentResult with a fixed epoch clock, hardcoded IDs/channel/message
bodies, and a real bytes attachment + filename for the with-file shape.
Rides the existing scaffolding PR #283 (issue #280); fixture-only, no
src/ changes. Smoke tests construct all five and assert pairwise
distinctness; ruff check clean.

Mark added 1 commit 2026-08-20 09:05:11 +00:00

test(#280): add reusable Discord HTTP boundary mock with outgoing-call recorder ... 28c5660d5f

Provides tests/unit/discord_boundary.py: a FakeChannel plus FakeResponseTarget
and FakeGateway that mock Discord's HTTP boundary so DiscordBotService._run_intent
can be driven with zero network. Captures every outgoing call into a recorder:
("send", text), ("send_file", filename, bytes), ("send_embed", title, desc),
("typing",). Fake send returns a Message with deterministic id/channel_id and
never raises. boundary() assembles a fully-wired service; acceptance smoke
drives a factories.short() result through _run_intent and asserts the recorder
captured at least one entry.

Refs: #280
Kanban: t_c43efdf5

Mark added 1 commit 2026-08-20 09:09:16 +00:00

test(#280): back delivery-pipeline scaffolding to single smoke test (scenario tests stay on sibling cards) c376b7d92e

Mark added 1 commit 2026-08-20 09:44:36 +00:00

test(#280): parametrized text-only scenarios for short, long-prose, code-block d24492c0af

Mark added 1 commit 2026-08-20 09:54:53 +00:00

test(#280): parametrized with-file scenarios for oversized attachment path (#273) e7827cb867

Mark added 1 commit 2026-08-20 10:03:17 +00:00

test(#280): parametrized research-intent scenario for embed path (#271, #272) 39ad081175

Mark merged commit 350478c2cf into master 2026-08-20 10:14:20 +00:00

Mark referenced this pull request from a commit 2026-08-20 10:14:22 +00:00

Merge pull request 'test(#280): integration test for full Discord delivery pipeline (#234 + #270/#271/#272/#273)' (#283) from wt/integration-verify into master

Mark referenced this pull request 2026-08-20 10:14:48 +00:00

integration test: drive synthetic MeshIntentResult through full delivery pipeline #280

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

blocked:children

  

blocked:commit-ready-failed

  

blocked:depends-231

Depends on #231 (Discord Bot Foundation) landing first. Do not pick until #231 is closed.

  

blocked:depends-236

Depends on #236 (Phase 1) landing first. Do not pick until #236 is closed.

  

blocked:depends-237

Depends on #237 (Phase 2) landing first. Do not pick until #237 is closed.

  

blocked:depends-238

Depends on #238 (Phase 3) landing first. Do not pick until #238 is closed.

  

blocked:depends-239

Depends on #239 (Phase 4) landing first. Do not pick until #239 is closed.

  

blocked:gate-fetch

  

blocked:gate-fetch

  

blocked:gate-lint

  

blocked:gate-research

  

blocked:needs-attention

Janitor escalated: pipeline terminated without producing expected changes. Human review required.

  

blocked:needs-decision

  

blocked:no-changes

  

blocked:no-procedure

  

blocked:preflight

Preflight check failed

  

blocked:verify-failed

  

bug

Something is broken

  

enhancement

New feature or request

  

feature-request

  

high-priority

Critical path items

  

in-progress

Issue is currently being worked on by a quickfix runner

  

lint-cleanup

Repo lint baseline is dirty

  

needs-decompose

  

needs-triage

  

ops-retry

  

ops-task

Operations task — install, configure, deploy, API calls

  

phase-5

Phase 5 Self-Building Infrastructure

  

quickfix

Pipe to opencode for direct fix

  

security/medium

Medium severity security issue

  

self-building

Autonomous code generation and self-improvement

  

triage-approved

Approved by triage — queued for fixer pipeline

No labels

blocked:children

blocked:commit-ready-failed

blocked:depends-231

blocked:depends-236

blocked:depends-237

blocked:depends-238

blocked:depends-239

blocked:gate-fetch

blocked:gate-fetch

blocked:gate-lint

blocked:gate-research

blocked:needs-attention

blocked:needs-decision

blocked:no-changes

blocked:no-procedure

blocked:preflight

blocked:verify-failed

bug

enhancement

feature-request

high-priority

in-progress

lint-cleanup

needs-decompose

needs-triage

ops-retry

ops-task

phase-5

quickfix

security/medium

self-building

triage-approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Mark/mesh-seed!283

No description provided.