[qa] attachments.spec.ts still tagged @quarantine — #49 closed without un-tag; e2e never runs un-quarantined #60

New issue

Closed

opened 2026-08-14 03:32:48 +00:00 by Mark · 0 comments

Mark commented

2026-08-14 03:32:48 +00:00

Owner

Summary

QA post-deploy probe (kanban card t_ff03332f) verified that the Mark/nodedesk#51 fix landed on main (commit 9cc0c75, legit close 2026-08-05T04:37:42Z, unit tests 27/27 green, typecheck clean). However, the e2e test that motivated #51 is still quarantined and has never run un-quarantined.

Finding

tests/attachments.spec.ts line 10 still carries { tag: "@quarantine" }.
Fix commit 9cc0c75 explicitly deferred un-tagging to "PR #49 once CI is green".
Tracking issue #49 ("Quarantine flaky e2e tests") was closed 2026-08-05 without the un-tag ever happening.
#55 (CI e2e never green on main) remains open, which explains why the un-quarantine never occurred.

Reproduction

cd nodedesk && git fetch origin && git checkout origin/main
grep -n quarantine tests/attachments.spec.ts → shows tag: "@quarantine" on the only test.
Run the e2e suite; the attachments test is excluded from the default run.

Actual vs expected

Actual: attachments e2e never executes un-quarantined; the #51 fix is verified only by code inspection + unit tests, not by the e2e that originally caught the gap.
Expected: once #55 (CI runner/e2e on main) is resolved, un-tag @quarantine in tests/attachments.spec.ts and confirm the test passes against the wired edit page.

Reference

Originated from kanban card t_ff03332f (QA board, reporter lane).
Related: Mark/nodedesk#49 (closed prematurely), Mark/nodedesk#51 (fixed), Mark/nodedesk#55 (CI e2e broken, still open).

## Summary QA post-deploy probe (kanban card `t_ff03332f`) verified that the Mark/nodedesk#51 fix landed on main (commit `9cc0c75`, legit close 2026-08-05T04:37:42Z, unit tests 27/27 green, typecheck clean). **However, the e2e test that motivated #51 is still quarantined and has never run un-quarantined.** ## Finding - `tests/attachments.spec.ts` line 10 still carries `{ tag: "@quarantine" }`. - Fix commit `9cc0c75` explicitly deferred un-tagging to "PR #49 once CI is green". - Tracking issue #49 ("Quarantine flaky e2e tests") was closed 2026-08-05 **without the un-tag ever happening**. - #55 (CI e2e never green on main) remains open, which explains why the un-quarantine never occurred. ## Reproduction 1. `cd nodedesk && git fetch origin && git checkout origin/main` 2. `grep -n quarantine tests/attachments.spec.ts` → shows `tag: "@quarantine"` on the only test. 3. Run the e2e suite; the attachments test is excluded from the default run. ## Actual vs expected - **Actual:** attachments e2e never executes un-quarantined; the #51 fix is verified only by code inspection + unit tests, not by the e2e that originally caught the gap. - **Expected:** once #55 (CI runner/e2e on main) is resolved, un-tag `@quarantine` in `tests/attachments.spec.ts` and confirm the test passes against the wired edit page. ## Reference - Originated from kanban card `t_ff03332f` (QA board, reporter lane). - Related: Mark/nodedesk#49 (closed prematurely), Mark/nodedesk#51 (fixed), Mark/nodedesk#55 (CI e2e broken, still open).