[quarantine] attachments.spec.ts — stale assertion for unwired NoteAttachments UI #51

New issue

Closed

opened 2026-08-05 02:26:36 +00:00 by Mark · 0 comments

Mark commented

2026-08-05 02:26:36 +00:00

Owner

Quarantined under Mark/nodedesk#49 (Phase 2 quality gates).

Test location

File: tests/attachments.spec.ts
Test: "attachments UI exists" (whole file — single test)
Assertion failing: lines 20-24 expect heading "Attachments" on /app/notes/[id]/edit

Reproduction

npm run test:e2e:all -- tests/attachments.spec.ts

Failure mode

Deterministic failure (not a flake). The test expects a heading "Attachments" on /app/notes/[id]/edit, but src/app/app/notes/[id]/edit/page.tsx renders no attachments section.

Root cause

src/components/NoteAttachments.tsx exists but is never imported by any page. ND-010 built the API + storage + tests but never wired the UI into the note edit/view page. This is a feature gap, not a test bug — the test correctly caught an unwired component.

Acceptance criteria for un-quarantine

Wire NoteAttachments component into note view/edit pages, OR
Remove the stale assertion and gate it behind a feature flag, OR
Delete the test if the feature is abandoned.

References

Parent: #49 (quarantine tracking)
Epic: #38 (quality gates)
Audit: docs/ci/audit.md §3.1

Quarantined under Mark/nodedesk#49 (Phase 2 quality gates). ## Test location - File: `tests/attachments.spec.ts` - Test: "attachments UI exists" (whole file — single test) - Assertion failing: lines 20-24 expect heading "Attachments" on `/app/notes/[id]/edit` ## Reproduction ```bash npm run test:e2e:all -- tests/attachments.spec.ts ``` ## Failure mode Deterministic failure (not a flake). The test expects a heading "Attachments" on `/app/notes/[id]/edit`, but `src/app/app/notes/[id]/edit/page.tsx` renders no attachments section. ## Root cause `src/components/NoteAttachments.tsx` exists but is **never imported by any page**. ND-010 built the API + storage + tests but never wired the UI into the note edit/view page. This is a **feature gap, not a test bug** — the test correctly caught an unwired component. ## Acceptance criteria for un-quarantine - [ ] Wire `NoteAttachments` component into note view/edit pages, OR - [ ] Remove the stale assertion and gate it behind a feature flag, OR - [ ] Delete the test if the feature is abandoned. ## References - Parent: #49 (quarantine tracking) - Epic: #38 (quality gates) - Audit: `docs/ci/audit.md` §3.1