fix(#100): apply ruff format to clear backend/app/ format-debt (117 files) #152

Closed

Mark wants to merge 4 commits from fix/100-format-debt into main

pull from: fix/100-format-debt

merge into: Mark:main

Mark:main

Conversation 0 Commits 4 Files changed 117 +1647 -573

Mark commented 2026-09-14 22:21:51 +00:00

Owner

Copy link

Closes Mark/osint-hub#100 (format-debt subset).
kanban: t_30ff698d (parent verdict t_39eae918)

Context

PR #128 (open) addressed the lint side of #100 and pinned ruff to 0.16.7 in both .forgejo/workflows/ci.yml and pyproject.toml. Its issuecomment-54759 explicitly defers the ruff format --check step as a follow-up:

The unrelated ruff format --check app/ failures on 128 files predate this commit (verified on e1f41af too) and are out of scope for the manual-rule-violation card.

This PR is that follow-up.

What this PR does

Runs ruff format app/ --config ../pyproject.toml against main HEAD (bf6a0fb). 117 files reformatted, 67 already-formatted files unchanged. Diff is +1647 / -573 lines, all formatter-driven:

• Long argument lists split onto separate lines (line-length 100)
• Long ClassVar[...] annotations wrapped when they exceed line-length
• No semantic changes; no functional behavior change

Verification

$ cd backend
$ ruff check .                                  # All checks passed! (exit 0)
$ ruff check app/ --config ../pyproject.toml    # All checks passed! (exit 0)
$ ruff format --check app/ --config ../pyproject.toml
                                                # 184 files already formatted (exit 0)

All three CI gate steps exit 0. Combined with PR #128 (ruff pin), the backend-lint job should go green.

Out of scope

• mypy (separate lane; see PRs #127, #151)
• Lint-rule violations (separate lane; PR #128)
• Tests / golden fixtures / performance / e2e jobs (separate lanes)

Refs #100

Closes Mark/osint-hub#100 (format-debt subset). kanban: t_30ff698d (parent verdict t_39eae918) ## Context PR #128 (open) addressed the lint side of #100 and pinned ruff to 0.16.7 in both `.forgejo/workflows/ci.yml` and `pyproject.toml`. Its issuecomment-54759 explicitly defers the `ruff format --check` step as a follow-up: > The unrelated `ruff format --check app/` failures on 128 files predate this commit (verified on e1f41af too) and are out of scope for the manual-rule-violation card. This PR is that follow-up. ## What this PR does Runs `ruff format app/ --config ../pyproject.toml` against `main` HEAD (bf6a0fb). 117 files reformatted, 67 already-formatted files unchanged. Diff is +1647 / -573 lines, all formatter-driven: - Long argument lists split onto separate lines (line-length 100) - Long `ClassVar[...]` annotations wrapped when they exceed line-length - No semantic changes; no functional behavior change ## Verification ``` $ cd backend $ ruff check . # All checks passed! (exit 0) $ ruff check app/ --config ../pyproject.toml # All checks passed! (exit 0) $ ruff format --check app/ --config ../pyproject.toml # 184 files already formatted (exit 0) ``` All three CI gate steps exit 0. Combined with PR #128 (ruff pin), the `backend-lint` job should go green. ## Out of scope - mypy (separate lane; see PRs #127, #151) - Lint-rule violations (separate lane; PR #128) - Tests / golden fixtures / performance / e2e jobs (separate lanes) Refs #100

Mark added 1 commit 2026-09-14 22:21:51 +00:00

fix(#100): apply ruff format to clear backend/app/ format-debt (117 files) ... 7852d59236

Following the parent verdict (t_39eae918 -> t_30ff698d) and the explicit
deferral note in PR #128 (issuecomment-54759): the CI `ruff format --check`
step has been red on origin/main since ruff 0.16.x's formatter diverged
from the previous formatting baseline. Lint gates (`ruff check .` and
`ruff check app/ --config ../pyproject.toml`) were already green per the
PR #126/127/128 lineage; only the format step remained.

This commit runs `ruff format app/ --config ../pyproject.toml` against
main HEAD (bf6a0fb), which re-flows 117 files. The diff is purely
formatter-driven:
  - Long argument lists split onto separate lines (line-length 100)
  - ClassVar[...] annotations wrapped when they exceed line-length
  - No semantic changes; no functional behavior change

Verified locally after this commit:
  $ cd backend
  $ ruff check .                                  # All checks passed! (exit 0)
  $ ruff check app/ --config ../pyproject.toml    # All checks passed! (exit 0)
  $ ruff format --check app/ --config ../pyproject.toml
                                                  # 184 files already formatted (exit 0)

CI gate unblocks once this lands; combined with PR #128 (ruff pin to
0.16.7) the `backend-lint` job will go green.

Refs #100
kanban: t_30ff698d

Mark added 1 commit 2026-09-14 22:28:29 +00:00

noop: trigger Forgejo Actions retry (wedge re-run) 07ab159f29

Mark added 1 commit 2026-09-14 22:34:12 +00:00

noop: trigger second Forgejo Actions retry (wedge self-heal probe) a30c2a68b1

Mark added 1 commit 2026-09-14 22:38:09 +00:00

noop: trigger CI after runner restart 51e5041402

Mark closed this pull request 2026-09-21 01:08:57 +00:00

Some checks failed

Hide all checks

CI / Backend Lint & Format (pull_request) Failing after 5s

Details

CI / Golden Fixture Validation (pull_request) Has been skipped

Details

CI / Backend Tests (pull_request) Has been skipped

Details

CI / Backend Security Tests (pull_request) Has been skipped

Details

Stress Tests / Stress & Pipeline Tests (pull_request) Failing after 6s

Details

Stress Tests / Full Data Pipeline Validation (pull_request) Has been skipped

Details

CI / Frontend Lint (pull_request) Failing after 51s

Details

CI / Frontend Tests (pull_request) Has been skipped

Details

CI / Dependency Security Scan (pull_request) Has been skipped

Details

CI / Frontend E2E Tests (pull_request) Has been skipped

Details

CI / All Checks Passed (pull_request) Failing after 1s

Details

Performance Regression Tests / Performance Regression Detection (pull_request) Failing after 2m12s

Details

Performance Regression Tests / Compare with Baseline (pull_request) Has been skipped

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agentic-osint

Agentic OSINT features

  

audit

  

blocked:commit-ready-failed

  

blocked:gate-fetch

  

blocked:gate-fetch

  

blocked:gate-lint

  

blocked:gate-plan

  

blocked:gate-research

  

blocked:needs-decision

  

blocked:needs-human

  

blocked:no-changes

  

blocked:preflight

Repo has dirty lint; kilo-gsd preflight refuses to dispatch until lint-cleanup lands

  

blocked:verify-failed

  

bug

Something is not working

  

chore

Config/cleanup item

  

deferred

Deferred — will revisit later

  

enhancement

Enhancement request

  

feature-request

  

in-progress

  

lint-baseline

  

lint-cleanup

kilo-gsd preflight lint gate: repo has dirty ruff state, cleanup required before fixer dispatch

  

needs-decompose

Issue needs decompose processing

  

needs-triage

  

performance

  

quickfix

  

security/medium

Medium severity security issue

  

triage-approved

Approved by triage

No labels

agentic-osint

audit

blocked:commit-ready-failed

blocked:gate-fetch

blocked:gate-fetch

blocked:gate-lint

blocked:gate-plan

blocked:gate-research

blocked:needs-decision

blocked:needs-human

blocked:no-changes

blocked:preflight

blocked:verify-failed

bug

chore

deferred

enhancement

feature-request

in-progress

lint-baseline

lint-cleanup

needs-decompose

needs-triage

performance

quickfix

security/medium

triage-approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Mark/osint-hub!152

No description provided.