Merge fix/100-ruff-imports -> main #144

Closed

Mark wants to merge 9 commits from fix/100-ruff-imports into main

pull from: fix/100-ruff-imports

merge into: Mark:main

Mark:main

Conversation 0 Commits 9 Files changed 131 +581 -565

Mark commented 2026-09-12 18:01:53 +00:00

Owner

Copy link

Auto-opened batch merger.

Auto-opened batch merger.

Mark added 9 commits 2026-09-12 18:01:53 +00:00

fix(lint): hoist json import in change_detector (closes #97) 3daffae583

fix(lint): hoist logging/time imports in main (closes #97) fb5dee81a6

fix(lint): hoist inline imports in abuseipdb and dark_web_monitor (closes #97) b1b0e1b014

fix(lint): resolve remaining PLC0415 + ruff errors so ruff check . exits 0 (refs #97) ... 86cd3d3434

Full-repo cleanup beyond the 5 violations listed in #97 (preflight output was
truncated to 1500 chars; repo actually had 219 ruff errors across 50 files):
- Hoisted safe stdlib/local imports to top-level (no behavior change)
- Left deliberately-guarded lazy imports (optional deps, circular-import
  avoiders, app.db.engine test seam) with justified # noqa: PLC0415
- registry.py: file-level # ruff: noqa: PLC0415 (guarded optional-module
  registration by design)
- Non-PLC fixes: UP042 StrEnum, UP047 PEP695 type params, PT028 noqa,
  alembic merge migration import cleanup
- Fixed latent broken relative import in llm/tools/evidence_extraction.py
  (from ...models -> from ....models; original lazy import would have failed
  at call time)

Verified: ruff check . && ruff check backend/ && ruff check backend/app/ all
exit 0; 945 unit tests pass; app.main/app.tasks/all routers/modules import
cleanly (no circular imports introduced).

lint: ruff auto-fix I001 unsorted imports (-14 errors) e13b6b3766

lint: clear import-bucket residuals (E402 in tests + app files, I001 after marker moves) (issue #100) 4e4db61a09

lint: keep imports-bucket scope only — revert modernize-bucket (UP042/UP047) hunks pulled in by cherry-pick, retain PLC0415 hoists in entity_module_map (issue #100) d080adc328

style: ruff-format touched import-hoisted files (pre-commit gate) + format orchestrator_v3_llm import block (issue #100) 9bf40c36f0

style: normalize formatting on import-hoisted files (pre-commit ruff-format, issue #100) c2750c5fd2

Mark closed this pull request 2026-09-21 01:09:03 +00:00

Some checks failed

Hide all checks

CI / Backend Lint & Format (pull_request) Failing after 4s

Details

CI / Golden Fixture Validation (pull_request) Has been skipped

Details

CI / Backend Tests (pull_request) Has been skipped

Details

CI / Backend Security Tests (pull_request) Has been skipped

Details

CI / Frontend Lint (pull_request) Failing after 1m4s

Details

CI / Frontend Tests (pull_request) Has been skipped

Details

CI / Dependency Security Scan (pull_request) Has been skipped

Details

Stress Tests / Stress & Pipeline Tests (pull_request) Failing after 31s

Details

Stress Tests / Full Data Pipeline Validation (pull_request) Has been skipped

Details

Performance Regression Tests / Performance Regression Detection (pull_request) Failing after 2m16s

Details

CI / Frontend E2E Tests (pull_request) Has been skipped

Details

Performance Regression Tests / Compare with Baseline (pull_request) Has been skipped

Details

CI / All Checks Passed (pull_request) Failing after 1s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agentic-osint

Agentic OSINT features

  

audit

  

blocked:commit-ready-failed

  

blocked:gate-fetch

  

blocked:gate-fetch

  

blocked:gate-lint

  

blocked:gate-plan

  

blocked:gate-research

  

blocked:needs-decision

  

blocked:needs-human

  

blocked:no-changes

  

blocked:preflight

Repo has dirty lint; kilo-gsd preflight refuses to dispatch until lint-cleanup lands

  

blocked:verify-failed

  

bug

Something is not working

  

chore

Config/cleanup item

  

deferred

Deferred — will revisit later

  

enhancement

Enhancement request

  

feature-request

  

in-progress

  

lint-baseline

  

lint-cleanup

kilo-gsd preflight lint gate: repo has dirty ruff state, cleanup required before fixer dispatch

  

needs-decompose

Issue needs decompose processing

  

needs-triage

  

performance

  

quickfix

  

security/medium

Medium severity security issue

  

triage-approved

Approved by triage

No labels

agentic-osint

audit

blocked:commit-ready-failed

blocked:gate-fetch

blocked:gate-fetch

blocked:gate-lint

blocked:gate-plan

blocked:gate-research

blocked:needs-decision

blocked:needs-human

blocked:no-changes

blocked:preflight

blocked:verify-failed

bug

chore

deferred

enhancement

feature-request

in-progress

lint-baseline

lint-cleanup

needs-decompose

needs-triage

performance

quickfix

security/medium

triage-approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Mark/osint-hub!144

No description provided.