Fix the lint on osint-hub

Mark commented

2026-08-12 03:49:05 +00:00

Owner

Pre-flight lint check for Mark/osint-hub failed. Kilo-GSD is hard-gated on clean lint and refuses to start work on this repo until the debt is resolved.

What is dirty

PLC0415 `import` should be at the top-level of a file
  --> backend/app/change_detector.py:75:9
   |
73 |     @staticmethod
74 |     def detect_json_changes(old_data: dict | None, new_data: dict) -> ChangeDetectionResult:
75 |         import json
   |         ^^^^^^^^^^^
76 |
77 |         old_str = json.dumps(old_data, sort_keys=True, indent=2) if old_data else ""
   |

PLC0415 `import` should be at the top-level of a file
  --> backend/app/main.py:48:9
   |
46 |             mapper.configured = True
47 |     except Exception as e:
48 |         import logging
   |         ^^^^^^^^^^^^^^
49 |
50 |         logging.getLogger(__name__).warning(f"Failed to configure mappers: {e}")
   |

PLC0415 `import` should be at the top-level of a file
  --> backend/app/main.py:97:5
   |
95 |         return await call_next(request)
96 |
97 |     import time
   |     ^^^^^^^^^^^
98 |
99 |     start = time.time()
   |

PLC0415 `import` should be at the top-level of a file
  --> backend/app/modules/abuseipdb.py:25:9
   |
23 |             - max_age_days: int - Max age of reports (default: 30)
24 |         """
25 |         from ..settings import settings
   |         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
26 |
27 |         api_key = options.get("api_key") or getattr(settings, "abuseipdb_api_key", None)
   |

PLC0415 `import` should be at the top-level of a file
   --> backend/app/modules/dark_web_monitor.py:103:13
    |
101 |         """Fetch content from .onion site"""
102 |         try:
103 |

Why this issue exists

Kilo-GSD was attempting Mark/osint-hub#96 but the preflight ruff check . returned 1. We do not knowingly pass along lint errors; the original ticket is held until this one is resolved and the lint is clean.

Scope

Fix every lint error reported above so ruff check . exits 0 against Mark/osint-hub. Do not change behavior — only fix style/dead-code/safety issues that lint flags. Commit on a branch and open a PR. Once merged, kilo-gsd will resume the held tickets.

Pre-flight lint check for `Mark/osint-hub` failed. Kilo-GSD is hard-gated on clean lint and refuses to start work on this repo until the debt is resolved. ## What is dirty ``` PLC0415 `import` should be at the top-level of a file --> backend/app/change_detector.py:75:9 | 73 | @staticmethod 74 | def detect_json_changes(old_data: dict | None, new_data: dict) -> ChangeDetectionResult: 75 | import json | ^^^^^^^^^^^ 76 | 77 | old_str = json.dumps(old_data, sort_keys=True, indent=2) if old_data else "" | PLC0415 `import` should be at the top-level of a file --> backend/app/main.py:48:9 | 46 | mapper.configured = True 47 | except Exception as e: 48 | import logging | ^^^^^^^^^^^^^^ 49 | 50 | logging.getLogger(__name__).warning(f"Failed to configure mappers: {e}") | PLC0415 `import` should be at the top-level of a file --> backend/app/main.py:97:5 | 95 | return await call_next(request) 96 | 97 | import time | ^^^^^^^^^^^ 98 | 99 | start = time.time() | PLC0415 `import` should be at the top-level of a file --> backend/app/modules/abuseipdb.py:25:9 | 23 | - max_age_days: int - Max age of reports (default: 30) 24 | """ 25 | from ..settings import settings | ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ 26 | 27 | api_key = options.get("api_key") or getattr(settings, "abuseipdb_api_key", None) | PLC0415 `import` should be at the top-level of a file --> backend/app/modules/dark_web_monitor.py:103:13 | 101 | """Fetch content from .onion site""" 102 | try: 103 | ``` ## Why this issue exists Kilo-GSD was attempting `Mark/osint-hub#96` but the preflight `ruff check .` returned 1. We do not knowingly pass along lint errors; the original ticket is held until this one is resolved and the lint is clean. ## Scope Fix every lint error reported above so `ruff check .` exits 0 against `Mark/osint-hub`. Do not change behavior — only fix style/dead-code/safety issues that lint flags. Commit on a branch and open a PR. Once merged, kilo-gsd will resume the held tickets.

Mark added the

lint-cleanup

triage-approved

labels

2026-08-12 03:49:05 +00:00

Mark added the

blocked:preflight

label

2026-08-13 10:32:33 +00:00

Mark referenced this issue from a commit

2026-08-13 21:02:58 +00:00

fix(lint): hoist json import in change_detector (closes #97)

Mark referenced this issue from a commit

2026-08-13 21:06:02 +00:00

fix(lint): hoist logging/time imports in main (closes #97)

Mark referenced this issue from a commit

2026-08-13 21:08:59 +00:00

fix(lint): hoist inline imports in abuseipdb and dark_web_monitor (closes #97)

Mark referenced this issue from a commit

2026-08-13 21:58:07 +00:00

fix(lint): resolve remaining PLC0415 + ruff errors so ruff check . exits 0 (refs #97)

Mark referenced this issue

2026-08-13 21:58:37 +00:00

fix(lint): resolve PLC0415 violations blocking kilo-gsd (refs #97) #98

Mark commented

2026-08-13 21:59:01 +00:00

Author

Owner

PR opened: #98 (fix/lint-plc0415 -> main)

Full-repo ruff cleanup: ruff check . now exits 0 (was 219 errors across 50 files). kilo-gsd preflight can resume held tickets #96/#95 once merged.

Verification: ruff check . / backend/ / backend/app/ all pass; 945 unit tests pass; no import cycles.

PR opened: https://forgejo.tail018ac4.ts.net/Mark/osint-hub/pulls/98 (fix/lint-plc0415 -> main) Full-repo ruff cleanup: `ruff check .` now exits 0 (was 219 errors across 50 files). kilo-gsd preflight can resume held tickets #96/#95 once merged. Verification: ruff check . / backend/ / backend/app/ all pass; 945 unit tests pass; no import cycles.

Mark referenced this issue from a commit

2026-08-14 05:54:42 +00:00

Fix #97: hoist PLC0415 imports to top-level

Mark referenced this issue from a pull request that will close it,

2026-08-14 05:54:50 +00:00

Fix #97: hoist PLC0415 imports to top-level #99

Mark referenced this issue

2026-08-14 06:13:45 +00:00

Remaining ruff violations keep CI lint gate red (ruff check . exits non-zero after PR #99) #100

Mark referenced this issue

2026-08-19 20:58:48 +00:00

fix(#101): complete case-deletion dependent-row cleanup under FK enforcement #104