Mark/osint-hub
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(lint): clear E/W style-bucket ruff debt in backend/ (issue #100) #113

Closed
Mark wants to merge 1 commit from fix/100-ruff-style into main
pull from: fix/100-ruff-style
merge into: Mark:main
Conversation 0 Commits 1 Files changed 81 +586 -332
Mark commented 2026-08-24 11:45:13 +00:00
Owner
Copy link

Clears the ruff style bucket (E/W) for #100 at CI-pinned 0.15.17.

Scope cleared (204+37+10+23+7+5 = 286 errors -> 0):

  • E501 (204): line-too-long — wrapped via implicit string concatenation, embedded JS/CSS template reflow at syntax-safe points, docstring/prose reflow
  • E722 (37): bare except -> except Exception:
  • E741 (10): ambiguous l -> lead/ln/loc/log/res (all usage sites renamed, no F821)
  • W291 (23) / W293 (7): trailing whitespace removed
  • E712 (5): == True -> truthy (SQLAlchemy-safe .where(), behavior-neutral)

Out of scope: E402 (103) is the imports bucket, already cleared on fix/100-ruff-imports (PR #112). After both merge, ruff check . --select E,W = 0.

Verification:

  • cd backend && pytest tests/ -m 'not integration and not performance and not security': 1297 passed, 5 skipped, 0 failed
  • pre-commit: all 6 hooks pass (trailing-whitespace, end-of-file, large-files, merge-conflict, ruff --fix, ruff-format)
  • ruff format --check app/: 184 files already formatted (same as sibling PR #111/#112 baseline, zero new format debt)
  • CI gate ruff check app/ --config ../pyproject.toml: 331 errors — identical to origin/main baseline (delta 0); remaining are other buckets' rules (PLC0415/F401/I001/UP042/UP047)
  • py_compile clean across all 81 changed files; no unrelated semantic changes (diff is whitespace/layout/naming only)
Clears the ruff style bucket (E/W) for #100 at CI-pinned 0.15.17. Scope cleared (204+37+10+23+7+5 = 286 errors -> 0): - E501 (204): line-too-long — wrapped via implicit string concatenation, embedded JS/CSS template reflow at syntax-safe points, docstring/prose reflow - E722 (37): bare `except` -> `except Exception:` - E741 (10): ambiguous `l` -> lead/ln/loc/log/res (all usage sites renamed, no F821) - W291 (23) / W293 (7): trailing whitespace removed - E712 (5): `== True` -> truthy (SQLAlchemy-safe .where(), behavior-neutral) Out of scope: E402 (103) is the imports bucket, already cleared on fix/100-ruff-imports (PR #112). After both merge, `ruff check . --select E,W` = 0. Verification: - `cd backend && pytest tests/ -m 'not integration and not performance and not security'`: 1297 passed, 5 skipped, 0 failed - pre-commit: all 6 hooks pass (trailing-whitespace, end-of-file, large-files, merge-conflict, ruff --fix, ruff-format) - `ruff format --check app/`: 184 files already formatted (same as sibling PR #111/#112 baseline, zero new format debt) - CI gate `ruff check app/ --config ../pyproject.toml`: 331 errors — identical to origin/main baseline (delta 0); remaining are other buckets' rules (PLC0415/F401/I001/UP042/UP047) - py_compile clean across all 81 changed files; no unrelated semantic changes (diff is whitespace/layout/naming only)
fix(lint): clear E/W style-bucket debt in backend/ (issue #100)
Some checks failed
CI / Backend Lint & Format (pull_request) Failing after 4s
Details
CI / Golden Fixture Validation (pull_request) Has been skipped
Details
CI / Backend Tests (pull_request) Has been skipped
Details
CI / Backend Security Tests (pull_request) Has been skipped
Details
CI / Frontend Lint (pull_request) Failing after 24s
Details
CI / Frontend Tests (pull_request) Has been skipped
Details
CI / Dependency Security Scan (pull_request) Has been skipped
Details
Performance Regression Tests / Performance Regression Detection (pull_request) Failing after 6s
Details
Stress Tests / Stress & Pipeline Tests (pull_request) Failing after 6s
Details
Stress Tests / Full Data Pipeline Validation (pull_request) Has been skipped
Details
CI / Frontend E2E Tests (pull_request) Has been skipped
Details
Performance Regression Tests / Compare with Baseline (pull_request) Has been skipped
Details
CI / All Checks Passed (pull_request) Failing after 1s
Details
42366aaa0f 
Clears the ruff style bucket for #100 at CI-pinned 0.15.17:
- E501 (204): wrap long lines (implicit string concat; embedded JS/CSS template
  reflow at syntax-safe points; docstring/prose reflow)
- E722 (37): bare except -> except Exception
- E741 (10): ambiguous l -> lead/ln/loc/log/res
- W291 (23) / W293 (7): trailing whitespace
- E712 (5): == True -> truthy (SQLAlchemy-safe .where())

All changes are whitespace / line layout / naming; no behavioral change.
E402 (103) is the imports bucket (PR #112).

Verified: 1297 tests pass, pre-commit green, ruff format --check app/ clean
(184 files already formatted), CI gate delta vs origin/main = 0.
Mark closed this pull request 2026-08-26 05:09:25 +00:00
Some checks failed
CI / Backend Lint & Format (pull_request) Failing after 4s
Details
CI / Golden Fixture Validation (pull_request) Has been skipped
Details
CI / Backend Tests (pull_request) Has been skipped
Details
CI / Backend Security Tests (pull_request) Has been skipped
Details
CI / Frontend Lint (pull_request) Failing after 24s
Details
CI / Frontend Tests (pull_request) Has been skipped
Details
CI / Dependency Security Scan (pull_request) Has been skipped
Details
Performance Regression Tests / Performance Regression Detection (pull_request) Failing after 6s
Details
Stress Tests / Stress & Pipeline Tests (pull_request) Failing after 6s
Details
Stress Tests / Full Data Pipeline Validation (pull_request) Has been skipped
Details
CI / Frontend E2E Tests (pull_request) Has been skipped
Details
Performance Regression Tests / Compare with Baseline (pull_request) Has been skipped
Details
CI / All Checks Passed (pull_request) Failing after 1s
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
agentic-osint

Agentic OSINT features

  
audit

   
blocked:commit-ready-failed

   
blocked:gate-fetch

   
blocked:gate-fetch

   
blocked:gate-lint

   
blocked:gate-plan

   
blocked:gate-research

   
blocked:needs-decision

   
blocked:needs-human

   
blocked:no-changes

   
blocked:preflight

Repo has dirty lint; kilo-gsd preflight refuses to dispatch until lint-cleanup lands

  
blocked:verify-failed

   
bug

Something is not working

  
chore

Config/cleanup item

  
deferred

Deferred — will revisit later

  
enhancement

Enhancement request

  
feature-request

   
in-progress

   
lint-baseline

   
lint-cleanup

kilo-gsd preflight lint gate: repo has dirty ruff state, cleanup required before fixer dispatch

  
needs-decompose

Issue needs decompose processing

  
needs-triage

   
performance

   
quickfix

   
security/medium

Medium severity security issue

  
triage-approved

Approved by triage

No labels
agentic-osint
audit
blocked:commit-ready-failed
blocked:gate-fetch
blocked:gate-fetch
blocked:gate-lint
blocked:gate-plan
blocked:gate-research
blocked:needs-decision
blocked:needs-human
blocked:no-changes
blocked:preflight
blocked:verify-failed
bug
chore
deferred
enhancement
feature-request
in-progress
lint-baseline
lint-cleanup
needs-decompose
needs-triage
performance
quickfix
security/medium
triage-approved
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Mark/osint-hub!113
No description provided.