test(security): restore security regression tests from commit 7109410 #265

Merged

Mark merged 2 commits from restore-security-tests-252 into master 2026-08-07 14:45:25 +00:00

Conversation 0 Commits 2 Files changed 4 +437 -6

Mark commented 2026-08-04 14:28:58 +00:00

Owner

Copy link

Restore the following test files that were lost:

• tests/unit/test_secrets_manager.py
• tests/unit/test_skill_secrets_redaction.py
• tests/unit/test_node_provision_skill_integration.py

Fix import path from capabilities to primitives (directory renamed).
Fix record_secret_access() call to use contract_id parameter instead of capability_id.

Closes #252

Restore the following test files that were lost: - tests/unit/test_secrets_manager.py - tests/unit/test_skill_secrets_redaction.py - tests/unit/test_node_provision_skill_integration.py Fix import path from capabilities to primitives (directory renamed). Fix record_secret_access() call to use contract_id parameter instead of capability_id. Closes #252

Mark added 1 commit 2026-08-04 14:28:59 +00:00

test(security): restore security regression tests from commit 7109410 ... b44120a7bc

Restore the following test files that were lost:
- tests/unit/test_secrets_manager.py
- tests/unit/test_skill_secrets_redaction.py
- tests/unit/test_node_provision_skill_integration.py

Fix import path from capabilities to primitives (directory renamed).
Fix record_secret_access() call to use contract_id parameter instead of capability_id.

Closes #252

Mark referenced this pull request 2026-08-04 14:40:58 +00:00

Discord Bot Foundation #231

Mark referenced this pull request 2026-08-04 15:49:24 +00:00

skill_executor.py passes 'capability_id' to MeshLedger but refactored API expects 'contract_id' — 3 test failures, 6 call sites #253

Mark referenced this pull request 2026-08-04 17:31:57 +00:00

Security regression: dedicated security test suite from commit 7109410 missing from codebase #252

Mark referenced this pull request from a commit 2026-08-04 23:50:22 +00:00

fix: capability_id -> contract_id in ledger calls (skill_executor.py)

Mark added 1 commit 2026-08-04 23:50:23 +00:00

fix: capability_id -> contract_id in ledger calls (skill_executor.py) ... ff77abd356

Fixes Mark/mesh-seed#252: record_secret_access() and record_skill_run()
both expect contract_id, not capability_id. All 6 call sites corrected.

PR #265 restore-security-tests-252 now passes all 11 security tests.

Mark merged commit 3dd94565b3 into master 2026-08-07 14:45:25 +00:00

Mark referenced this pull request from a commit 2026-08-07 14:45:27 +00:00

Merge pull request 'test(security): restore security regression tests from commit 7109410' (#265) from restore-security-tests-252 into master

Mark referenced this pull request 2026-08-08 09:23:56 +00:00

test_legacy_nerve_hardened false positive: docstring contains 'StrictHostKeyChecking=no' #257

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

blocked:children

  

blocked:commit-ready-failed

  

blocked:depends-231

Depends on #231 (Discord Bot Foundation) landing first. Do not pick until #231 is closed.

  

blocked:depends-236

Depends on #236 (Phase 1) landing first. Do not pick until #236 is closed.

  

blocked:depends-237

Depends on #237 (Phase 2) landing first. Do not pick until #237 is closed.

  

blocked:depends-238

Depends on #238 (Phase 3) landing first. Do not pick until #238 is closed.

  

blocked:depends-239

Depends on #239 (Phase 4) landing first. Do not pick until #239 is closed.

  

blocked:gate-fetch

  

blocked:gate-fetch

  

blocked:gate-lint

  

blocked:gate-research

  

blocked:needs-attention

Janitor escalated: pipeline terminated without producing expected changes. Human review required.

  

blocked:needs-decision

  

blocked:no-changes

  

blocked:no-procedure

  

blocked:preflight

Preflight check failed

  

blocked:verify-failed

  

bug

Something is broken

  

enhancement

New feature or request

  

feature-request

  

high-priority

Critical path items

  

in-progress

Issue is currently being worked on by a quickfix runner

  

lint-cleanup

Repo lint baseline is dirty

  

needs-decompose

  

needs-triage

  

ops-retry

  

ops-task

Operations task — install, configure, deploy, API calls

  

phase-5

Phase 5 Self-Building Infrastructure

  

quickfix

Pipe to opencode for direct fix

  

security/medium

Medium severity security issue

  

self-building

Autonomous code generation and self-improvement

  

triage-approved

Approved by triage — queued for fixer pipeline

No labels

blocked:children

blocked:commit-ready-failed

blocked:depends-231

blocked:depends-236

blocked:depends-237

blocked:depends-238

blocked:depends-239

blocked:gate-fetch

blocked:gate-fetch

blocked:gate-lint

blocked:gate-research

blocked:needs-attention

blocked:needs-decision

blocked:no-changes

blocked:no-procedure

blocked:preflight

blocked:verify-failed

bug

enhancement

feature-request

high-priority

in-progress

lint-cleanup

needs-decompose

needs-triage

ops-retry

ops-task

phase-5

quickfix

security/medium

self-building

triage-approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Mark/mesh-seed!265

No description provided.