#156 - Fix for #146 (commit b4a2bde) never pushed to origin/main — Settings interactions remain broken - Mark/kimi_agent_kin_app_sync - cyguin git: Adlerian Hierarchical Self-Actualization Syllogism

Mark commented

2026-07-26 00:55:27 +00:00

Owner

Finding

The fix for Issue #146 (Settings page controls don't respond) was implemented locally as commit b4a2bde fix(#146): restore Settings interactions but was never pushed to origin/main. Issues #146 and #155 were both closed via surgical-close.py based on local verification only. The remote main branch (latest commit d5f3efd) contains no sign of the #146 fix.

Changes in the unfixed commit `b4a2bde`

File	Change
`src/components/ui/switch.tsx`	Adds `type="button"` to `<SwitchRoot>` — prevents Radix UI Switch from submitting forms
`src/pages/Settings.tsx`	Wraps store reads in `useShallow` — prevents unnecessary re-renders that break reactivity
`vite.config.ts`	Adds `resolve.dedupe` and `optimizeDeps.include` for Radix UI + React — prevents duplicate React instances
`src/pages/__tests__/Settings.interactions.test.tsx`	New test verifying Dark theme click + Vault switch toggle

Reproduction steps

Clone the repo fresh from origin/main
Run the app
Navigate to Settings page
Try toggling Dark theme or Vault switch

Expected behavior

Settings controls respond to clicks. Fix commit b4a2bde is present on origin/main.

Actual behavior

origin/main is at d5f3efd (fix #148). Settings controls remain unresponsive on any build from the remote repo.

Kanban card: t_0db6db0e

## Finding The fix for Issue #146 (Settings page controls don't respond) was implemented locally as commit `b4a2bde fix(#146): restore Settings interactions` but was **never pushed to origin/main**. Issues #146 and #155 were both closed via surgical-close.py based on local verification only. The remote main branch (latest commit `d5f3efd`) contains no sign of the #146 fix. ## Changes in the unfixed commit `b4a2bde` | File | Change | |------|--------| | `src/components/ui/switch.tsx` | Adds `type="button"` to `<SwitchRoot>` — prevents Radix UI Switch from submitting forms | | `src/pages/Settings.tsx` | Wraps store reads in `useShallow` — prevents unnecessary re-renders that break reactivity | | `vite.config.ts` | Adds `resolve.dedupe` and `optimizeDeps.include` for Radix UI + React — prevents duplicate React instances | | `src/pages/__tests__/Settings.interactions.test.tsx` | New test verifying Dark theme click + Vault switch toggle | ## Reproduction steps 1. Clone the repo fresh from origin/main 2. Run the app 3. Navigate to Settings page 4. Try toggling Dark theme or Vault switch ## Expected behavior Settings controls respond to clicks. Fix commit b4a2bde is present on origin/main. ## Actual behavior origin/main is at d5f3efd (fix #148). Settings controls remain unresponsive on any build from the remote repo. --- *Kanban card: t_0db6db0e*

Mark added the

bug

label

2026-07-26 00:55:27 +00:00

Mark referenced this issue

2026-07-26 01:02:07 +00:00

fixit automation closed #154 despite push failure — same fix(#146) never-pushed pattern as #156 #157

Mark commented

2026-07-26 01:02:19 +00:00

Author

Owner

Same pattern recurred with findit attempt #154 — filed #157 for the additional instance. This is now a confirmed recurring automation issue: the pipeline closed two separate findit iterations (#155, #154) without pushing the fix. Reference: probe card t_7bd49718

Mark commented

2026-07-26 14:43:33 +00:00

Author

Owner

Commit b4a2bde (fix(#146): restore Settings interactions) is now on origin/main. This issue was filed against a transient push failure; the fix has landed. Closing as resolved.

Commit b4a2bde (`fix(#146): restore Settings interactions`) is now on origin/main. This issue was filed against a transient push failure; the fix has landed. Closing as resolved.

Mark closed this issue

2026-07-26 14:43:33 +00:00

Rows
Columns

Fix for #146 (commit b4a2bde) never pushed to origin/main — Settings interactions remain broken #156

Finding

Changes in the unfixed commit b4a2bde

Reproduction steps

Expected behavior

Actual behavior

Fix for #146 (commit `b4a2bde`) never pushed to origin/main — Settings interactions remain broken #156

Changes in the unfixed commit `b4a2bde`