Evaluate whether this repo needs pre-commit hooks

Mark commented

2026-09-12 02:57:45 +00:00

Owner

Repository Mark/wondertales was scanned by the org-wide pre-commit hook audit (kanban t_5c4b41a5) and classified as bare/config-only — no Python, Node, or other source files were detected that would benefit from auto-installed pre-commit hooks.

If this repo has since grown source files, or if you want a universal .githooks/pre-commit guard anyway (merge conflict markers, large files, trailing whitespace), please add it manually or close this issue.

Reference: t_5c4b41a5 (pre-commit hooks rollout, 2026-09-11).

Repository `Mark/wondertales` was scanned by the org-wide pre-commit hook audit (kanban t_5c4b41a5) and classified as **bare/config-only** — no Python, Node, or other source files were detected that would benefit from auto-installed pre-commit hooks. If this repo has since grown source files, or if you want a universal `.githooks/pre-commit` guard anyway (merge conflict markers, large files, trailing whitespace), please add it manually or close this issue. Reference: t_5c4b41a5 (pre-commit hooks rollout, 2026-09-11).

Mark added the

triage-approved

label

2026-09-14 14:04:15 +00:00

Mark referenced this issue from a commit

2026-09-14 16:20:05 +00:00

chore(pre-commit): document #12 evaluation — hooks already cover this repo

Mark commented

2026-09-14 16:20:57 +00:00

Author

Owner

Closing — pre-commit hooks are already in place and cover everything this issue (and the 2026-09-11 org-wide audit t_5c4b41a5) asked for, plus Kotlin-specific guards the audit could not have suggested (it ran before project/app/ existed).

Existing config: .pre-commit-config.yaml (commits 6f4e31e + b864578 on main) covers the three universal guards the issue body names:

check-merge-conflict — universal guard #1
check-added-large-files (5 MB cap) — universal guard #2
trailing-whitespace — universal guard #3

...plus end-of-file-fixer, check-yaml, check-xml, detect-private-key, and the Kotlin/Android-aware android-lint (via gradlew) and no-non-null-assertion (greps !! in *.kt/*.kts).

Closing commit: 19aebfe on main — chore(pre-commit): document #12 evaluation — hooks already cover this repo. Adds a header comment to .pre-commit-config.yaml referencing this issue and the audit, so future readers don't have to re-derive the decision.

Other commits bundled with the push (already on main, all pre-commit-clean):

3fdab87 feat: add pre-commit hooks with lint baseline and code quality checks
a7ee257 fix: improve pre-commit config - add minimum version, check-xml, remove restrictive types from android-lint
45e712a fix: apply pre-commit auto-fixes to existing files (trailing whitespace)
0cc82a8 test: add AacDatabaseTest covering AAC DAOs and seed data
c350ec1 gitignore: exclude GSD infrastructure directories

Plan: .kilo/plans/wondertales-12-pre-commit-hooks.md.

Watcher note: kilo-gsd.py exit code was 2 (PARTIAL — fix on disk, push rejected because origin/main advanced between the runner's fetch and push). Watcher recovered: git fetch origin && git rebase origin/main && git push origin main landed cleanly because the two new origin/main commits (2e7d83f, a1e538a) touch only .forgejo/workflows/ci.yml and were disjoint from the local commits. All 9 pre-commit hooks passed during push.

Closing — pre-commit hooks are already in place and cover everything this issue (and the 2026-09-11 org-wide audit t_5c4b41a5) asked for, plus Kotlin-specific guards the audit could not have suggested (it ran before project/app/ existed). **Existing config: `.pre-commit-config.yaml`** (commits 6f4e31e + b864578 on main) covers the three universal guards the issue body names: - `check-merge-conflict` — universal guard #1 - `check-added-large-files` (5 MB cap) — universal guard #2 - `trailing-whitespace` — universal guard #3 ...plus `end-of-file-fixer`, `check-yaml`, `check-xml`, `detect-private-key`, and the Kotlin/Android-aware `android-lint` (via gradlew) and `no-non-null-assertion` (greps `!!` in `*.kt`/`*.kts`). **Closing commit:** `19aebfe` on `main` — `chore(pre-commit): document #12 evaluation — hooks already cover this repo`. Adds a header comment to `.pre-commit-config.yaml` referencing this issue and the audit, so future readers don't have to re-derive the decision. **Other commits bundled with the push** (already on main, all pre-commit-clean): - `3fdab87` feat: add pre-commit hooks with lint baseline and code quality checks - `a7ee257` fix: improve pre-commit config - add minimum version, check-xml, remove restrictive types from android-lint - `45e712a` fix: apply pre-commit auto-fixes to existing files (trailing whitespace) - `0cc82a8` test: add AacDatabaseTest covering AAC DAOs and seed data - `c350ec1` gitignore: exclude GSD infrastructure directories Plan: `.kilo/plans/wondertales-12-pre-commit-hooks.md`. Watcher note: kilo-gsd.py exit code was 2 (PARTIAL — fix on disk, push rejected because origin/main advanced between the runner's fetch and push). Watcher recovered: `git fetch origin && git rebase origin/main && git push origin main` landed cleanly because the two new origin/main commits (`2e7d83f`, `a1e538a`) touch only `.forgejo/workflows/ci.yml` and were disjoint from the local commits. All 9 pre-commit hooks passed during push.

Mark closed this issue

2026-09-14 16:21:08 +00:00

Rows
Columns

Evaluate whether this repo needs pre-commit hooks #12