Mark/vikunja-cli
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(vikunja-cli#18): use /tasks not /tasks/all for list-all endpoint #20

Closed
Mark wants to merge 2 commits from fix/issue-18-cli-api-400 into main
pull from: fix/issue-18-cli-api-400
merge into: Mark:main
Conversation 1 Commits 2 Files changed 2 +3 -3
Mark commented 2026-09-16 17:29:49 +00:00
Owner
Copy link

Summary

One-line fix for vikunja-cli#18 — Vikunja 1.0+ renamed GET /api/v1/tasks/all to GET /api/v1/tasks. The old endpoint now returns HTTP 400 code 2004 Invalid model provided: Bad Request on every call.

Root cause

Vikunja 1.0.0 renamed the "list all tasks" API endpoint from /api/v1/tasks/all to /api/v1/tasks for consistency. The CLI was still calling the old path. From the Vikunja 1.0 changelog:

/tasks/all → /tasks: The endpoint to fetch all tasks now lives at just /tasks for consistency.

Same regression affected other Vikunja clients (aimbitgmbh/vikunja-mcp#1, democratize-technology/node-vikunja#4, vikunja-mcp#40).

Fix

-        response = self._make_request("GET", "/tasks/all", params=query or {})
+        response = self._make_request("GET", "/tasks", params=query or {})

Only the list-all (no --project) path is affected. List-by-project still uses /projects/{id}/tasks which is unchanged in v1.0+.

Verification (against the live Vikunja instance on unstable)

  • GET /tasks → [] (200 OK)
  • GET /tasks/all → {"code":2004,"message":"Invalid model provided: Bad Request"} (400)
  • GET /tasks?s=test → [] (200 OK) — search now works through the new endpoint

Closes #18

## Summary One-line fix for `vikunja-cli#18` — Vikunja 1.0+ renamed `GET /api/v1/tasks/all` to `GET /api/v1/tasks`. The old endpoint now returns HTTP 400 code 2004 `Invalid model provided: Bad Request` on every call. ## Root cause Vikunja 1.0.0 renamed the "list all tasks" API endpoint from `/api/v1/tasks/all` to `/api/v1/tasks` for consistency. The CLI was still calling the old path. From the Vikunja 1.0 changelog: > `/tasks/all` → `/tasks`: The endpoint to fetch all tasks now lives at just `/tasks` for consistency. Same regression affected other Vikunja clients (aimbitgmbh/vikunja-mcp#1, democratize-technology/node-vikunja#4, vikunja-mcp#40). ## Fix ```diff - response = self._make_request("GET", "/tasks/all", params=query or {}) + response = self._make_request("GET", "/tasks", params=query or {}) ``` Only the list-all (no `--project`) path is affected. List-by-project still uses `/projects/{id}/tasks` which is unchanged in v1.0+. ## Verification (against the live Vikunja instance on unstable) - `GET /tasks` → `[]` (200 OK) - `GET /tasks/all` → `{"code":2004,"message":"Invalid model provided: Bad Request"}` (400) - `GET /tasks?s=test` → `[]` (200 OK) — search now works through the new endpoint Closes #18
fix(vikunja-cli#18): use /tasks not /tasks/all for list-all endpoint
Some checks failed
CI / Test (Python 3.11) (pull_request) Failing after 15s
Details
CI / Test (Python 3.12) (pull_request) Failing after 15s
Details
CI / Test (Python 3.10) (pull_request) Failing after 51s
Details
CI / Build (pull_request) Has been skipped
Details
8dd1645ca4 
Vikunja 1.0+ renamed /api/v1/tasks/all to /api/v1/tasks. The old endpoint
now returns 400 code 2004 'Invalid model provided: Bad Request' on every
call. Verified against live instance: /tasks returns [] (200), /tasks/all
returns the 400. Verified by web search: same regression hit other Vikunja
clients (aimbitgmbh/vikunja-mcp#1, democratize-technology/node-vikunja#4,
vikunja-mcp#40).

Only the list-all (no-project) path is affected; list-by-project still uses
/projects/{id}/tasks which is unchanged in v1.0+.
fix(vikunja-cli#18): update test mocks from /tasks/all to /tasks
Some checks failed
CI / Test (Python 3.10) (pull_request) Failing after 48s
Details
CI / Test (Python 3.11) (pull_request) Failing after 45s
Details
CI / Test (Python 3.12) (pull_request) Failing after 46s
Details
CI / Build (pull_request) Has been skipped
Details
d01a5ace7d 
The branch's client.py change (8dd1645) switched GET /tasks/all to GET /tasks
for Vikunja 1.0+, but the test mocks at tests/test_api_client.py:58 and :196
still registered /tasks/all. The responses library raised ConnectionError
because no mock matched the new endpoint, causing 2 pytest failures across
Python 3.10/3.11/3.12 in PR #20 CI.

Update the two mock URLs to match the production endpoint.

Refs #18, PR #20
Mark closed this pull request 2026-09-18 18:10:25 +00:00
Mark commented 2026-09-18 18:11:51 +00:00
Author
Owner
Copy link

Closed as superseded. The same fix has been pushed directly to origin/main per local-dev-cycle convention (no PR).

  • 4b723fd fix(vikunja-cli#18): use /tasks not /tasks/all for list-all endpoint
  • 0bfaff0 fix(vikunja-cli#18): update test mocks from /tasks/all to /tasks

Both files now reference /tasks (matching Vikunja 1.0+), and tests/test_api_client.py mocks at lines 58 and 196 are aligned.

Out-of-scope notes from triage (not addressed — separate tickets if needed):

  • AC2 create --description path
  • AC3 create --related wiring
  • AC4 HTTP logging
Closed as superseded. The same fix has been pushed directly to `origin/main` per local-dev-cycle convention (no PR). - `4b723fd` fix(vikunja-cli#18): use /tasks not /tasks/all for list-all endpoint - `0bfaff0` fix(vikunja-cli#18): update test mocks from /tasks/all to /tasks Both files now reference `/tasks` (matching Vikunja 1.0+), and `tests/test_api_client.py` mocks at lines 58 and 196 are aligned. Out-of-scope notes from triage (not addressed — separate tickets if needed): - AC2 `create --description` path - AC3 `create --related` wiring - AC4 HTTP logging
Some checks failed
CI / Test (Python 3.10) (pull_request) Failing after 48s
Details
CI / Test (Python 3.11) (pull_request) Failing after 45s
Details
CI / Test (Python 3.12) (pull_request) Failing after 46s
Details
CI / Build (pull_request) Has been skipped
Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
blocked:gate-research

   
bug

Bug report

  
feature-request

   
in-progress

Worker is actively processing this issue

  
needs-triage

   
quickfix

   
security/medium

Medium severity security issue

  
triage-approved
No labels
blocked:gate-research
bug
feature-request
in-progress
needs-triage
quickfix
security/medium
triage-approved
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Mark/vikunja-cli!20
No description provided.