Mark/pc2cad
1
0
Fork 0
Code Issues 8 Pull requests Projects Releases Packages Wiki Activity Actions

[Bot] Issue #53 fix never landed — compose_body_with_features boolean cut still missing #54

New issue
Closed
opened 2026-07-24 06:21:59 +00:00 by Mark · 2 comments
Mark commented 2026-07-24 06:21:59 +00:00
Owner
Copy link

Summary

The kilo-gsd fix pipeline for issue #53 (compose_body_with_features boolean cut never executed) completed prematurely. The fix was never deployed — no commits referencing #53 exist on any branch, and issue #53 remains OPEN.

Kanban card: t_23a907eb (QA probe → reporter)

What was found

  1. Issue #53 is still OPEN on Forgejo — fix has NOT been deployed
  2. No commit references #53 anywhere in git history on any branch
  3. Parent fixit card t_81aea089 not found on any kanban board (fixit, qa, tasker)
  4. Uncommitted WIP changes exist in working tree but are:
    • Divergent from the implementation plan (uses Solid.make_box bounding-box approximation instead of the sketch-with-placement approach described in the plan)
    • Incomplete: verification gate shows only 7 faces (= a bare box with no through-hole)
    • The boolean subtraction between body and feature cylinder doesn't produce a visible hole

Verification gate results

Check Result Detail
CLI export ✅ PASS "Exported composed reconstruction" — exit 0
Coverage >= 0.85 ✅ PASS coverage=0.969 (4847/5000 within 1.0mm)
Hole present (OCP face count) ❌ FAIL 7 faces, 30 edges — simple box, no through-hole

STEP analysis: 7 faces (a bare box has 6; a box with through-hole would have >=10), 30 edges, 1 solid. The boolean subtraction is NOT producing a through-hole in the output.

Steps to reproduce

  1. Check out the pc2cad repo working tree (uncommitted changes present)
  2. Run: python pc2cad_cli.py samples/strategy_plate_with_hole.ply --out /tmp/fix_plate.step --out-format build123d
  3. Inspect the output STEP file — face count is 7, no through-hole present
  4. Expected: the reconstructed model should have a through-hole matching the detected cylindrical feature

Expected behavior

The composited model from compose_body_with_features should produce a solid with a through-hole (>=10 faces) when the source PLY contains a plate with a hole feature. The boolean subtraction between the body and the cylinder feature should create a visible through-hole.

Actual behavior

The output is a simple 7-face box — the boolean subtraction does not produce a through-hole. The uncommitted WIP changes use a bounding-box approximation (Solid.make_box) instead of the proper sketch-with-placement approach, and the feature cylinder does not intersect the body correctly.

## Summary The kilo-gsd fix pipeline for issue #53 (compose_body_with_features boolean cut never executed) completed prematurely. The fix was never deployed — no commits referencing #53 exist on any branch, and issue #53 remains OPEN. **Kanban card:** t_23a907eb (QA probe → reporter) ## What was found 1. **Issue #53 is still OPEN** on Forgejo — fix has NOT been deployed 2. **No commit references #53** anywhere in git history on any branch 3. **Parent fixit card t_81aea089** not found on any kanban board (fixit, qa, tasker) 4. **Uncommitted WIP changes** exist in working tree but are: - Divergent from the implementation plan (uses `Solid.make_box` bounding-box approximation instead of the sketch-with-placement approach described in the plan) - Incomplete: verification gate shows only 7 faces (= a bare box with no through-hole) - The boolean subtraction between body and feature cylinder doesn't produce a visible hole ## Verification gate results | Check | Result | Detail | |-------|--------|--------| | CLI export | ✅ PASS | "Exported composed reconstruction" — exit 0 | | Coverage >= 0.85 | ✅ PASS | coverage=0.969 (4847/5000 within 1.0mm) | | Hole present (OCP face count) | ❌ FAIL | 7 faces, 30 edges — simple box, no through-hole | **STEP analysis:** 7 faces (a bare box has 6; a box with through-hole would have >=10), 30 edges, 1 solid. The boolean subtraction is NOT producing a through-hole in the output. ## Steps to reproduce 1. Check out the pc2cad repo working tree (uncommitted changes present) 2. Run: `python pc2cad_cli.py samples/strategy_plate_with_hole.ply --out /tmp/fix_plate.step --out-format build123d` 3. Inspect the output STEP file — face count is 7, no through-hole present 4. Expected: the reconstructed model should have a through-hole matching the detected cylindrical feature ## Expected behavior The composited model from `compose_body_with_features` should produce a solid with a through-hole (>=10 faces) when the source PLY contains a plate with a hole feature. The boolean subtraction between the body and the cylinder feature should create a visible through-hole. ## Actual behavior The output is a simple 7-face box — the boolean subtraction does not produce a through-hole. The uncommitted WIP changes use a bounding-box approximation (`Solid.make_box`) instead of the proper sketch-with-placement approach, and the feature cylinder does not intersect the body correctly.
Mark commented 2026-07-28 05:05:33 +00:00
Author
Owner
Copy link

Duplicate of #53. Consolidating on the original issue.

Duplicate of #53. Consolidating on the original issue.
Mark closed this issue 2026-07-28 05:05:33 +00:00
Mark commented 2026-07-28 05:23:09 +00:00
Author
Owner
Copy link

Verification sweep complete. The fix from #53 is confirmed working.

Fix commit: 88f8198 — implement boolean cut of features from body in reconstruct_to_build123d

QA reprobe results (strategy_plate_with_hole.ply → STEP):

  • Coverage: 0.964 (4822/5000 within 1.0mm, PASS)
  • Normal consistency: 0.999
  • STEP: 1 solid, 58 faces, 336 edges (bare box = 7 faces; through-hole = 58 faces ✅)
  • Boolean subtraction test (test_plate_hole_detected_and_exported): PASS

The reconstructed STEP now has a visible through-hole matching the input pointcloud. Closing this issue as fixed-by-commit-88f8198.

Verification sweep complete. The fix from #53 is confirmed working. **Fix commit:** `88f8198` — implement boolean cut of features from body in reconstruct_to_build123d **QA reprobe results** (strategy_plate_with_hole.ply → STEP): - Coverage: **0.964** (4822/5000 within 1.0mm, PASS) - Normal consistency: **0.999** - STEP: 1 solid, **58 faces**, **336 edges** (bare box = 7 faces; through-hole = 58 faces ✅) - Boolean subtraction test (`test_plate_hole_detected_and_exported`): **PASS** The reconstructed STEP now has a visible through-hole matching the input pointcloud. Closing this issue as fixed-by-commit-88f8198.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/pc2cad-83-encloses-edge
kilo-gsd-76-fix
No results found.
Labels
Clear labels   
blocked:needs-decision

   
blocked:preflight

Held by kilo-gsd preflight (lint dirty etc.)

  
bug

Bug report

  
in-progress

Pipeline is working on this issue

  
in-progress

Claimed by an active kilo-gsd pipeline run

  
lint-cleanup

Hold the repo until pre-flight lint is clean

  
needs-decompose

   
quickfix

   
triage-approved

   
wontfix

Will not be worked on

No labels
blocked:needs-decision
blocked:preflight
bug
in-progress
in-progress
lint-cleanup
needs-decompose
quickfix
triage-approved
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Mark/pc2cad#54
No description provided.