Migrate export_step / export_stl / export_brep off FreeCAD, onto build123d + OCP — Phase 5: Wire export_brep and update CLI / tests #45

New issue

Closed

opened 2026-06-24 03:24:34 +00:00 by Mark · 21 comments

Mark commented 2026-06-24 03:24:34 +00:00

Owner

Copy link

Phase 5: Wire export_brep and update CLI / tests

Goal: Ensure export_brep (already OCP-capable via BRepTools.Write_s
per pc2cad_cli.py:513) is wired into the new pipeline. Update
tests/test_pipeline.py and add a no-FreeCAD regression test.

Approach:

• Verify pc2cad_cli.py:513 export_brep uses OCP (it already imports it).
  If it relies on pc2cad.py internals, refactor to call into the new
  OCP-only export layer.
• Add tests/test_pipeline.py::test_export_without_freecad that runs the
  full STEP/BREP/STL export on samples/sample_plane_cyl.ply without
  FreeCAD installed and asserts all three files are non-placeholder.
• Wrap test_export_with_freecad (if it exists) in
  pytest.importorskip("FreeCAD", reason="FreeCAD-only test").

Files: pc2cad_cli.py:513, 530, 532, tests/test_pipeline.py.

Acceptance:

• --out-format brep writes a valid BREP file with no FreeCAD import.
• pytest tests/ -v passes with FreeCAD uninstalled in the test venv.
• The FreeCAD-only test is properly skipped, not failed, when FreeCAD is
  absent.

---

---

Decomposed from pc2cad#23

## Phase 5: Wire `export_brep` and update CLI / tests **Goal:** Ensure `export_brep` (already OCP-capable via `BRepTools.Write_s` per `pc2cad_cli.py:513`) is wired into the new pipeline. Update `tests/test_pipeline.py` and add a no-FreeCAD regression test. **Approach:** - Verify `pc2cad_cli.py:513 export_brep` uses OCP (it already imports it). If it relies on `pc2cad.py` internals, refactor to call into the new OCP-only export layer. - Add `tests/test_pipeline.py::test_export_without_freecad` that runs the full STEP/BREP/STL export on `samples/sample_plane_cyl.ply` without FreeCAD installed and asserts all three files are non-placeholder. - Wrap `test_export_with_freecad` (if it exists) in `pytest.importorskip("FreeCAD", reason="FreeCAD-only test")`. **Files:** `pc2cad_cli.py:513, 530, 532`, `tests/test_pipeline.py`. **Acceptance:** - `--out-format brep` writes a valid BREP file with no FreeCAD import. - `pytest tests/ -v` passes with FreeCAD uninstalled in the test venv. - The FreeCAD-only test is properly skipped, not failed, when FreeCAD is absent. --- --- _Decomposed from [pc2cad#23](https://forgejo.tail018ac4.ts.net/Mark/pc2cad/issues/23)_

Mark added the

triage-approved

label 2026-06-24 03:24:34 +00:00

Mark referenced this issue 2026-06-24 03:24:37 +00:00

Migrate export_step / export_stl / export_brep off FreeCAD, onto build123d + OCP #23

Mark added the

needs-decompose

label 2026-07-08 00:53:20 +00:00

Mark commented 2026-07-08 00:53:48 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 01:02:48 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 01:14:48 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 01:17:48 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 01:19:21 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 01:22:21 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 01:59:49 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 02:14:50 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 02:16:22 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 04:16:24 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 04:46:25 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 04:51:07 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 04:57:07 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 04:58:25 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 05:03:08 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 07:13:26 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 07:21:10 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 07:25:27 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 09:25:28 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 10:21:13 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark commented 2026-07-08 10:24:14 +00:00

Author

Owner

Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.

Mark 2026-07-08 10:33:58 +00:00

• closed this issue
• removed the
  triage-approved
  needs-decompose
  labels

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

fix/pc2cad-83-encloses-edge

kilo-gsd-76-fix

No results found.

Labels

Clear labels   

blocked:needs-decision

  

blocked:preflight

Held by kilo-gsd preflight (lint dirty etc.)

  

bug

Bug report

  

in-progress

Pipeline is working on this issue

  

in-progress

Claimed by an active kilo-gsd pipeline run

  

lint-cleanup

Hold the repo until pre-flight lint is clean

  

needs-decompose

  

quickfix

  

triage-approved

  

wontfix

Will not be worked on

No labels

blocked:needs-decision

blocked:preflight

bug

in-progress

in-progress

lint-cleanup

needs-decompose

quickfix

triage-approved

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Mark/pc2cad#45

No description provided.