Fix #97: hoist PLC0415 imports to top-level #99

Closed

Mark wants to merge 1 commit from fix/97-plc0415-imports into main

pull from: fix/97-plc0415-imports

merge into: Mark:main

Mark:main

Conversation 0 Commits 1 Files changed 4 +13 -16

Mark commented 2026-08-14 05:54:50 +00:00

Owner

Copy link

Closes #97

Hoists inline PLC0415 imports to top-level in the four files flagged by ruff:

• backend/app/change_detector.py — json
• backend/app/main.py — logging, time
• backend/app/modules/abuseipdb.py — settings
• backend/app/modules/dark_web_monitor.py — aiohttp.socks (try/except guard, _has_socks unchanged)

Validation:

• No circular import: fresh-interpreter import of app.main, app.change_detector, app.modules.abuseipdb, app.modules.dark_web_monitor all succeed; no module imports app.main in reverse.
• ruff check on all four touched files: All checks passed (exit 0).
• Full repo ruff check .: 270 errors on this branch vs 275 at base b81dc67 — zero new errors, exactly the 5 targeted PLC0415s removed (repo baseline is pre-existing dirty; CI lint job also reduces 373 → 368 in backend/app).
• Test suite: 1297 passed, 5 skipped, 0 failed (pytest -m "not integration and not performance and not security").

Closes #97 Hoists inline PLC0415 imports to top-level in the four files flagged by ruff: - `backend/app/change_detector.py` — `json` - `backend/app/main.py` — `logging`, `time` - `backend/app/modules/abuseipdb.py` — `settings` - `backend/app/modules/dark_web_monitor.py` — `aiohttp.socks` (try/except guard, `_has_socks` unchanged) Validation: - No circular import: fresh-interpreter import of `app.main`, `app.change_detector`, `app.modules.abuseipdb`, `app.modules.dark_web_monitor` all succeed; no module imports `app.main` in reverse. - `ruff check` on all four touched files: All checks passed (exit 0). - Full repo `ruff check .`: 270 errors on this branch vs 275 at base b81dc67 — zero new errors, exactly the 5 targeted PLC0415s removed (repo baseline is pre-existing dirty; CI lint job also reduces 373 → 368 in backend/app). - Test suite: 1297 passed, 5 skipped, 0 failed (pytest -m "not integration and not performance and not security").

Mark added 1 commit 2026-08-14 05:54:51 +00:00

Fix #97: hoist PLC0415 imports to top-level 40efd97a0f

Mark referenced this pull request 2026-08-14 06:13:45 +00:00

Remaining ruff violations keep CI lint gate red (ruff check . exits non-zero after PR #99) #100

Mark added the

blocked:preflight

label 2026-08-14 07:15:15 +00:00

Mark referenced this pull request 2026-08-19 20:58:48 +00:00

fix(#101): complete case-deletion dependent-row cleanup under FK enforcement #104

Mark referenced this pull request 2026-08-24 10:34:36 +00:00

fix(lint): clear import-bucket ruff debt — PLC0415/F401/E402/I001 (issue #100) #112

Mark closed this pull request 2026-08-26 05:09:26 +00:00

Some checks failed

Hide all checks

CI / Backend Lint & Format (pull_request) Failing after 4s

Details

CI / Golden Fixture Validation (pull_request) Has been skipped

Details

CI / Backend Tests (pull_request) Has been skipped

Details

CI / Backend Security Tests (pull_request) Has been skipped

Details

CI / Frontend Lint (pull_request) Failing after 22s

Details

CI / Frontend Tests (pull_request) Has been skipped

Details

CI / Dependency Security Scan (pull_request) Has been skipped

Details

Stress Tests / Stress & Pipeline Tests (pull_request) Failing after 6s

Details

Stress Tests / Full Data Pipeline Validation (pull_request) Has been skipped

Details

Performance Regression Tests / Performance Regression Detection (pull_request) Failing after 33s

Details

CI / Frontend E2E Tests (pull_request) Has been skipped

Details

Performance Regression Tests / Compare with Baseline (pull_request) Has been skipped

Details

CI / All Checks Passed (pull_request) Failing after 51s

Details

Pull request closed

This pull request cannot be reopened because the branch was deleted.

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

agentic-osint

Agentic OSINT features

  

audit

  

blocked:commit-ready-failed

  

blocked:gate-fetch

  

blocked:gate-fetch

  

blocked:gate-lint

  

blocked:gate-plan

  

blocked:gate-research

  

blocked:needs-decision

  

blocked:needs-human

  

blocked:no-changes

  

blocked:preflight

Repo has dirty lint; kilo-gsd preflight refuses to dispatch until lint-cleanup lands

  

blocked:verify-failed

  

bug

Something is not working

  

chore

Config/cleanup item

  

deferred

Deferred — will revisit later

  

enhancement

Enhancement request

  

feature-request

  

in-progress

  

lint-baseline

  

lint-cleanup

kilo-gsd preflight lint gate: repo has dirty ruff state, cleanup required before fixer dispatch

  

needs-decompose

Issue needs decompose processing

  

needs-triage

  

performance

  

quickfix

  

security/medium

Medium severity security issue

  

triage-approved

Approved by triage

No labels

agentic-osint

audit

blocked:commit-ready-failed

blocked:gate-fetch

blocked:gate-fetch

blocked:gate-lint

blocked:gate-plan

blocked:gate-research

blocked:needs-decision

blocked:needs-human

blocked:no-changes

blocked:preflight

blocked:verify-failed

bug

chore

deferred

enhancement

feature-request

in-progress

lint-baseline

lint-cleanup

needs-decompose

needs-triage

performance

quickfix

security/medium

triage-approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Mark/osint-hub!99

No description provided.