Mark/omp-config

Fork 0

Add pre-commit hooks to omp-config #1

New issue

Closed

opened 2026-06-04 00:37:08 +00:00 by Mark · 2 comments

Mark commented

2026-06-04 00:37:08 +00:00

Owner

Repository omp-config does not have pre-commit hooks configured. Evaluate the repo's language/tooling and add appropriate hooks (.pre-commit-config.yaml for Python, lefthook.yml for Node, or .githooks/pre-commit for simpler repos).

Repository `omp-config` does not have pre-commit hooks configured. Evaluate the repo's language/tooling and add appropriate hooks (`.pre-commit-config.yaml` for Python, `lefthook.yml` for Node, or `.githooks/pre-commit` for simpler repos).

Mark added the

enhancement

label

2026-06-04 00:38:20 +00:00

Mark added

blocked:needs-decision

and removed

enhancement

labels

2026-06-06 15:37:54 +00:00

Mark commented

2026-06-07 02:57:26 +00:00

Author

Owner

⏸ Needs Decision

What needs to be decided?

Is this issue still relevant? If yes, remove the blocked:needs-decision label to route back to triage.

Blocking factors:

Didn't meet auto-approve criteria — scope=small, risk=low, spec=partial

Scope: small Risk: low Spec: partial Type: chore
Summary: Add pre-commit hooks to omp-config for YAML validation on commit.
Suggestion: Hooks already exist — .pre-commit-config.yaml (pre-commit framework with yamllint v1.35.1) and .githooks/pre-commit (standalone shell script wired via core.hooksPath = .githooks). The .githooks approach is active; the pre-commit framework config is present but requires pre-commit install to take effect. No action needed unless the goal is to consolidate to one approach or add extra checks (e.g., trailing-whitespace, end-of-file-fixer).
Rationale: Scope: <5 files, trivially small. Risk: low — additive config change, no code paths. Spec: partial — no AGENTS.md/CONTEXT.md exists, but YAML validation is aligned for a YAML-only config repo. Type: chore — developer tooling setup. Notably, hooks are already fully configured (both .pre-commit-config.yaml and .githooks/pre-commit), making this issue potentially stale.

To unblock: Remove the blocked:needs-decision label. The triage will apply the appropriate outcome based on your choice above.

## ⏸ Needs Decision **What needs to be decided?** - **Is this issue still relevant?** If yes, remove the `blocked:needs-decision` label to route back to triage. **Blocking factors:** - **Didn't meet auto-approve criteria** — scope=small, risk=low, spec=partial --- **Scope:** small **Risk:** low **Spec:** partial **Type:** chore **Summary:** Add pre-commit hooks to omp-config for YAML validation on commit. **Suggestion:** Hooks already exist — `.pre-commit-config.yaml` (pre-commit framework with yamllint v1.35.1) and `.githooks/pre-commit` (standalone shell script wired via `core.hooksPath = .githooks`). The `.githooks` approach is active; the pre-commit framework config is present but requires `pre-commit install` to take effect. No action needed unless the goal is to consolidate to one approach or add extra checks (e.g., trailing-whitespace, end-of-file-fixer). **Rationale:** Scope: <5 files, trivially small. Risk: low — additive config change, no code paths. Spec: partial — no AGENTS.md/CONTEXT.md exists, but YAML validation is aligned for a YAML-only config repo. Type: chore — developer tooling setup. Notably, hooks are already fully configured (both `.pre-commit-config.yaml` and `.githooks/pre-commit`), making this issue potentially stale. **To unblock:** Remove the `blocked:needs-decision` label. The triage will apply the appropriate outcome based on your choice above.

Mark added

quickfix

and removed

blocked:needs-decision

labels

2026-07-27 16:31:10 +00:00

Mark added the

triage-approved

label

2026-09-14 13:57:41 +00:00

Mark added the

lint-baseline

label

2026-09-14 21:19:19 +00:00

Mark commented

2026-09-14 22:11:33 +00:00

Author

Owner

Pre-commit hooks already implemented and on origin/main — issue auto-stale-closure eligible.

Evidence:

Commit 07704e4 "Add yamllint pre-commit setup" added .githooks/pre-commit, .pre-commit-config.yaml, and .yamllint.
Commit 43e2af1 "Add .gitignore for GSD infrastructure" added .gitignore.
HEAD = origin/main = 35f4163. No work needed.

Closing as resolved. If you actually want me to remove pre-commit hooks from this repo, comment and I'll reopen with a new issue.

Pre-commit hooks already implemented and on origin/main — issue auto-stale-closure eligible. Evidence: - Commit `07704e4` "Add yamllint pre-commit setup" added `.githooks/pre-commit`, `.pre-commit-config.yaml`, and `.yamllint`. - Commit `43e2af1` "Add .gitignore for GSD infrastructure" added `.gitignore`. - HEAD = `origin/main` = `35f4163`. No work needed. Closing as resolved. If you actually want me to remove pre-commit hooks from this repo, comment and I'll reopen with a new issue.

Mark closed this issue

2026-09-14 22:11:33 +00:00