Mark/msp_c2
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

[Bug] API Contract vs Implementation Mismatch - Invoice Creation Endpoint #4

New issue
Closed
opened 2026-03-10 03:40:45 +00:00 by Mark · 35 comments
Mark commented 2026-03-10 03:40:45 +00:00
Owner
Copy link

Issue

There's a discrepancy between the API contract documentation and the actual implementation for invoice creation.

Details

API Contract (docs/api_contract.md line 87):

POST /invoices (roles: admin, billing)

Current Implementation (backend/api/v1/endpoints/invoices.py):
Looking at the router, invoices are primarily created via:

POST /invoices/from-ticket/{ticket_id}

Questions

  1. Is POST /invoices meant to be a standalone invoice creation endpoint?
  2. Should the current from-ticket endpoint remain as-is, or be refactored?
  3. What should the request body be for a standalone POST /invoices?

Proposed Resolution

Option A: Implement standalone POST /invoices for manual invoice creation
Option B: Update API contract to reflect current implementation
Option C: Support both methods with clear documentation

Acceptance Criteria

  • Resolve ambiguity in API design
  • Update implementation OR documentation
  • Ensure consistency across all API documentation
  • Update tests if needed

Priority

🟡 MEDIUM

Effort Estimate

Low (1-2 days)

## Issue There's a discrepancy between the API contract documentation and the actual implementation for invoice creation. ## Details **API Contract (`docs/api_contract.md` line 87):** ``` POST /invoices (roles: admin, billing) ``` **Current Implementation (`backend/api/v1/endpoints/invoices.py`):** Looking at the router, invoices are primarily created via: ``` POST /invoices/from-ticket/{ticket_id} ``` ## Questions 1. Is `POST /invoices` meant to be a standalone invoice creation endpoint? 2. Should the current `from-ticket` endpoint remain as-is, or be refactored? 3. What should the request body be for a standalone `POST /invoices`? ## Proposed Resolution Option A: Implement standalone `POST /invoices` for manual invoice creation Option B: Update API contract to reflect current implementation Option C: Support both methods with clear documentation ## Acceptance Criteria - [ ] Resolve ambiguity in API design - [ ] Update implementation OR documentation - [ ] Ensure consistency across all API documentation - [ ] Update tests if needed ## Priority 🟡 MEDIUM ## Effort Estimate Low (1-2 days)
Mark commented 2026-05-11 20:14:05 +00:00
Author
Owner
Copy link

Needs architectural decision: standalone POST /invoices endpoint vs only from-ticket. The two open questions in the issue need resolution before implementation.

Needs architectural decision: standalone POST /invoices endpoint vs only from-ticket. The two open questions in the issue need resolution before implementation.
Mark commented 2026-05-27 21:37:09 +00:00
Author
Owner
Copy link

🤖 Claimed by gsd-issue-fixer-msp_c2-4 — starting work

🤖 Claimed by `gsd-issue-fixer-msp_c2-4` — starting work
Mark commented 2026-05-27 21:37:10 +00:00
Author
Owner
Copy link

🤖 Claimed by gsd-issue-fixer-msp_c2-4 — starting work

🤖 Claimed by `gsd-issue-fixer-msp_c2-4` — starting work
Mark commented 2026-05-27 21:37:10 +00:00
Author
Owner
Copy link

🤖 Claimed by gsd-issue-fixer-msp_c2-4 — starting work

🤖 Claimed by `gsd-issue-fixer-msp_c2-4` — starting work
Mark commented 2026-05-27 21:37:10 +00:00
Author
Owner
Copy link

🤖 Claimed by gsd-issue-fixer-msp_c2-4 — starting work

🤖 Claimed by `gsd-issue-fixer-msp_c2-4` — starting work
Mark commented 2026-05-27 21:37:10 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-4] still working — claimed — starting pipeline

🤖 [`gsd-issue-fixer-msp_c2-4`] still working — claimed — starting pipeline
Mark commented 2026-05-27 21:37:10 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-4] still working — claimed — starting pipeline

🤖 [`gsd-issue-fixer-msp_c2-4`] still working — claimed — starting pipeline
Mark commented 2026-05-27 21:37:10 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-4] still working — claimed — starting pipeline

🤖 [`gsd-issue-fixer-msp_c2-4`] still working — claimed — starting pipeline
Mark commented 2026-05-27 21:37:10 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-4] still working — claimed — starting pipeline

🤖 [`gsd-issue-fixer-msp_c2-4`] still working — claimed — starting pipeline
Mark commented 2026-05-27 21:37:10 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-4] still working — research

🤖 [`gsd-issue-fixer-msp_c2-4`] still working — research
Mark commented 2026-05-27 21:37:10 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-4] still working — research

🤖 [`gsd-issue-fixer-msp_c2-4`] still working — research
Mark commented 2026-05-27 21:37:10 +00:00
Author
Owner
Copy link

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed.
Pipeline state needs reset. Check if another run is in progress.

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed. Pipeline state needs reset. Check if another run is in progress.
Mark commented 2026-05-27 21:37:10 +00:00
Author
Owner
Copy link

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed.
Pipeline state needs reset. Check if another run is in progress.

GSD pipeline blocked at RESEARCH: prerequisite gate (fetch) not passed. Pipeline state needs reset. Check if another run is in progress.
Mark commented 2026-05-27 21:37:30 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-4] still working — plan

🤖 [`gsd-issue-fixer-msp_c2-4`] still working — plan
Mark commented 2026-05-27 21:37:30 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-4] still working — plan

🤖 [`gsd-issue-fixer-msp_c2-4`] still working — plan
Mark commented 2026-05-27 21:37:50 +00:00
Author
Owner
Copy link

🤖 [gsd-issue-fixer-msp_c2-4] still working — implement attempt 1

🤖 [`gsd-issue-fixer-msp_c2-4`] still working — implement attempt 1
Mark commented 2026-05-27 21:38:11 +00:00
Author
Owner
Copy link

GSD VERIFY phase found no changes after implementation.
Worker output: ]11;?\API call failed after 3 retries: HTTP 404: 404 page not found

GSD VERIFY phase found no changes after implementation. Worker output: ]11;?\API call failed after 3 retries: HTTP 404: 404 page not found
Mark commented 2026-06-20 20:48:23 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 13:12:17 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 13:15:17 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 13:16:31 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 13:25:31 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 13:28:32 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 13:31:32 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 13:33:17 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 13:43:32 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 13:46:32 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 13:48:18 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 14:21:19 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 14:40:34 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 15:01:34 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 15:03:20 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 15:27:21 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 15:34:35 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-08 16:08:02 +00:00
Author
Owner
Copy link

Closed by overseer: issue already resolved by commit 86ac2a6 on main (1 commit ahead of origin).

Acceptance criteria satisfied:

  • Resolves ambiguity: adopted Option C (both POST /invoices for manual + POST /invoices/from-ticket/{ticket_id} preserved)
  • Implementation updated: standalone POST /invoices endpoint (admin/billing), 404 on unknown customer, InvoiceCreate + InvoiceLineCreate schemas
  • Documentation updated: docs/API.md documents both creation paths
  • Tests added: backend/tests/test_invoices_create.py (success, empty lines, unknown customer, RBAC, 422 validation)

Uncommitted working-tree changes relate to other issues (#32 SLA / webhooks) and are out of scope for #4.

Closed by overseer: issue already resolved by commit 86ac2a6 on main (1 commit ahead of origin). Acceptance criteria satisfied: - Resolves ambiguity: adopted Option C (both POST /invoices for manual + POST /invoices/from-ticket/{ticket_id} preserved) - Implementation updated: standalone POST /invoices endpoint (admin/billing), 404 on unknown customer, InvoiceCreate + InvoiceLineCreate schemas - Documentation updated: docs/API.md documents both creation paths - Tests added: backend/tests/test_invoices_create.py (success, empty lines, unknown customer, RBAC, 422 validation) Uncommitted working-tree changes relate to other issues (#32 SLA / webhooks) and are out of scope for #4.
Mark closed this issue 2026-07-08 16:08:05 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
blocked:gate-fetch

   
blocked:gate-fetch

   
blocked:gate-implement

   
blocked:gate-plan

   
blocked:needs-attention

   
blocked:needs-decision

   
blocked:needs-human

   
blocked:no-procedure

   
blocked:preflight

   
bug

Something is not working correctly

  
feature-request

   
in-progress

   
lint-cleanup

   
needs-decompose

Ready to be decomposed into sub-issues

  
needs-triage

   
ops-task

   
quickfix

   
security/medium

Medium severity security issue

  
triage-approved
No labels
blocked:gate-fetch
blocked:gate-fetch
blocked:gate-implement
blocked:gate-plan
blocked:needs-attention
blocked:needs-decision
blocked:needs-human
blocked:no-procedure
blocked:preflight
bug
feature-request
in-progress
lint-cleanup
needs-decompose
needs-triage
ops-task
quickfix
security/medium
triage-approved
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Mark/msp_c2#4
No description provided.