CODE QUALITY: Lazy logging violation in agentic_validator.py #213

New issue

Closed

opened 2026-05-08 23:52:47 +00:00 by Mark · 1 comment

Mark commented

2026-05-08 23:52:47 +00:00

Owner

Description

In substrate/agentic_validator.py line 64:

LOGGER.error(f"Agentic validation error: {e}")

This uses an f-string which forces string formatting even when the log level doesn't include ERROR. Should use lazy evaluation:

LOGGER.error("Agentic validation error: %s", e)

Also, the model name is hardcoded as qwen2.5-coder at line 31, and the Ollama host default is http://localhost:11434 — these should be configurable via environment variables for production deployment.

Severity

LOW - Code quality / maintainability

## Description In `substrate/agentic_validator.py` line 64: ```python LOGGER.error(f"Agentic validation error: {e}") ``` This uses an f-string which forces string formatting even when the log level doesn't include ERROR. Should use lazy evaluation: ```python LOGGER.error("Agentic validation error: %s", e) ``` Also, the model name is hardcoded as `qwen2.5-coder` at line 31, and the Ollama host default is `http://localhost:11434` — these should be configurable via environment variables for production deployment. ## Severity **LOW** - Code quality / maintainability