[Review] detectExcitementCycles bag-of-words picks up common English words ('time', 'meeting', 'just') as 'excitement keywords' #185

New issue

Closed

opened 2026-09-14 14:07:30 +00:00 by Mark · 1 comment

Mark commented

2026-09-14 14:07:30 +00:00

Owner

Finding

src/lib/intimate-state-engine.ts:328-330:

for (const word of i.notes.split(/\W+/)) {
  if (word.length >= 4) bag.add(word);
}

This takes every word ≥4 chars from notes and adds it to a topic bag that gets counted for excitement cycles. There's no stop-word list (despite the new STOP_WORDS set added in #166 to src/lib/utils.ts).

Common English words ("just", "with", "that", "have", "from", "they", "would", "could", "meeting", "their", "there") all qualify and accumulate. Combined with the positive-keyword check at line 322 (mood.includes(kw) || notes.includes(kw) for words like "great", "amazing"), if a user writes "we had a great time but I was just tired from the meeting", the bag accumulates time, just, tired, meeting, from — so "time", "meeting", "tired" all become excitement keywords. The insight surfaces as "You've been particularly energized about 'meeting' with Bob."

The 5-keyword output cap (line 354) masks the noise, but the ranking sort by intensityScore desc surfaces whichever has the highest count + recency, which is essentially random for common words.

Suggested fix

Reuse the STOP_WORDS set added in #166 (src/lib/utils.ts) for the bag filter:

import { STOP_WORDS } from "./utils";
// ...
for (const word of i.notes.split(/\W+/)) {
  if (word.length >= 4 && !STOP_WORDS.has(word.toLowerCase())) bag.add(word);
}

Or scope the bag to topics (which is curated by the user at log time) and skip the notes-token path entirely:

const bag = new Set<string>();
for (const t of i.topics) {
  if (t.length >= 3) bag.add(t);
}
// (drop the notes split loop)

Option A is more conservative (less risk of dropping legitimate excitement keywords). Option B is more aggressive (stops the noise at the source).

Severity

Medium. UX-visible bug. The insight text is user-facing and confusing when it surfaces common words.

Discovered by

Manual code review pass over #168, 2026-09-14.

## Finding `src/lib/intimate-state-engine.ts:328-330`: ```ts for (const word of i.notes.split(/\W+/)) { if (word.length >= 4) bag.add(word); } ``` This takes every word ≥4 chars from `notes` and adds it to a topic bag that gets counted for excitement cycles. There's no stop-word list (despite the new STOP_WORDS set added in #166 to `src/lib/utils.ts`). Common English words ("just", "with", "that", "have", "from", "they", "would", "could", "meeting", "their", "there") all qualify and accumulate. Combined with the positive-keyword check at line 322 (`mood.includes(kw) || notes.includes(kw)` for words like "great", "amazing"), if a user writes *"we had a great time but I was just tired from the meeting"*, the bag accumulates `time`, `just`, `tired`, `meeting`, `from` — so "time", "meeting", "tired" all become excitement keywords. The insight surfaces as *"You've been particularly energized about 'meeting' with Bob."* The 5-keyword output cap (line 354) masks the noise, but the ranking `sort by intensityScore desc` surfaces whichever has the highest count + recency, which is essentially random for common words. ## Suggested fix Reuse the `STOP_WORDS` set added in #166 (`src/lib/utils.ts`) for the bag filter: ```ts import { STOP_WORDS } from "./utils"; // ... for (const word of i.notes.split(/\W+/)) { if (word.length >= 4 && !STOP_WORDS.has(word.toLowerCase())) bag.add(word); } ``` Or scope the bag to `topics` (which is curated by the user at log time) and skip the notes-token path entirely: ```ts const bag = new Set<string>(); for (const t of i.topics) { if (t.length >= 3) bag.add(t); } // (drop the notes split loop) ``` Option A is more conservative (less risk of dropping legitimate excitement keywords). Option B is more aggressive (stops the noise at the source). ## Severity Medium. UX-visible bug. The insight text is user-facing and confusing when it surfaces common words. ## Discovered by Manual code review pass over #168, 2026-09-14.

Mark added the

in-progress

label

2026-09-14 14:07:30 +00:00

Mark referenced this issue

2026-09-14 14:37:39 +00:00

[Review] Vault-gate scrub list duplicated in src/lib/store.ts:1001 and src/pages/PersonDetail.tsx:2967 — should be a single helper #184

Mark commented

2026-09-14 14:37:39 +00:00

Author

Owner

Closing as already-fixed.

Location: uncommitted worktree + commit ccc9ce4 (Apply changes from kilo-gsd.py run for Mark/kimi_agent_kin_app_sync#188)

Change: excitement-cycle keyword noise: removed i.notes.split tokenization, bag now uses curated topics only

The chat-agent code review read against a stale HEAD and reported this issue as open. The fix was already in place (committed for #184, in the kilo-gsd worktree for #185) when the review started.

Stash + worktree state at session start:

HEAD was at 0854652 (fix #184), not 4fe2244 as the session began assuming.
stash@{0} contained leftover WIP for #183 (now redundant; #183 is committed).
Working tree held #185 fix (code + regression test) uncommitted.

No work to do. Re-classify if either fix needs to be re-merged to a different branch.

Closing as already-fixed. Location: uncommitted worktree + commit ccc9ce4 (Apply changes from kilo-gsd.py run for Mark/kimi_agent_kin_app_sync#188) Change: excitement-cycle keyword noise: removed `i.notes.split` tokenization, bag now uses curated `topics` only The chat-agent code review read against a stale HEAD and reported this issue as open. The fix was already in place (committed for #184, in the kilo-gsd worktree for #185) when the review started. Stash + worktree state at session start: - HEAD was at 0854652 (fix #184), not 4fe2244 as the session began assuming. - stash@{0} contained leftover WIP for #183 (now redundant; #183 is committed). - Working tree held #185 fix (code + regression test) uncommitted. No work to do. Re-classify if either fix needs to be re-merged to a different branch.

Mark closed this issue

2026-09-14 14:37:39 +00:00

Mark referenced this issue from a commit

2026-09-14 14:38:06 +00:00

fix(#185): drop notes-token path from detectExcitementCycles keyword bag

Mark removed the

in-progress

label

2026-09-14 14:39:21 +00:00