ci(forgejo): pin each job to catthehacker/ubuntu:act-22.04 #129

Merged

Mark merged 5 commits from wt/t_b9f42e72 into main 2026-09-12 06:21:02 +00:00

Conversation 0 Commits 5 Files changed 22 +136 -133

Mark commented 2026-09-12 04:25:52 +00:00

Owner

Copy link

Closes https://vikunja.tail018ac4.ts.net/tasks/133

Forgejo Actions run #1698 was cancelled at the initial-setup commit because runs-on: ubuntu-latest resolves to node:20-bookworm on this runner. That image ships Python 3.11 but no pip / ensurepip, so every job fails at the first pip install step with No module named pip (exit 127). Forgejo surfaces the failure as a cancelled run.

This change overrides the container for all five jobs (lint, typecheck, test, test-slow, test-matrix) to catthehacker/ubuntu:act-22.04, which has Python 3.10 + pip preinstalled. actions/setup-python@v5 will apt-install 3.11 on top. actions/checkout@v4 and actions/setup-python@v5 continue to work; only the base image changes.

Verified locally: podman run --rm catthehacker/ubuntu:act-22.04 python3 -m pip --version -> pip 22.0.2.

Closes https://vikunja.tail018ac4.ts.net/tasks/133 Forgejo Actions run #1698 was cancelled at the initial-setup commit because `runs-on: ubuntu-latest` resolves to `node:20-bookworm` on this runner. That image ships Python 3.11 but no `pip` / `ensurepip`, so every job fails at the first `pip install` step with `No module named pip` (exit 127). Forgejo surfaces the failure as a cancelled run. This change overrides the container for all five jobs (lint, typecheck, test, test-slow, test-matrix) to `catthehacker/ubuntu:act-22.04`, which has Python 3.10 + pip preinstalled. `actions/setup-python@v5` will apt-install 3.11 on top. `actions/checkout@v4` and `actions/setup-python@v5` continue to work; only the base image changes. Verified locally: `podman run --rm catthehacker/ubuntu:act-22.04 python3 -m pip --version` -> `pip 22.0.2`.

Mark added 1 commit 2026-09-12 04:25:53 +00:00

ci(forgejo): pin each job to catthehacker/ubuntu:act-22.04 ... b23d68b048

Runner maps ubuntu-latest to node:20-bookworm, which ships Python 3.11 but
no pip / ensurepip. Every job fails at the first 'pip install' step
(exit 127 'No module named pip'), which Forgejo surfaces as a cancelled
run (e.g. run #1698 on the initial-setup commit).

Override the container for all five jobs (lint, typecheck, test,
test-slow, test-matrix) to catthehacker/ubuntu:act-22.04, which has
Python 3.10 + pip preinstalled. setup-python@v5 will apt-install 3.11
on top.

Mark added 1 commit 2026-09-12 04:33:44 +00:00

style: apply ruff format to 17 src/ files ... 9c17c1b4ad

'ruff format --check src/' (CI lint job) reports 17 files would be
reformatted. Apply 'ruff format src/' so the lint job passes once the
container override lands.

Files reformatted: src/embroidery_converter/{fill_stitch_generator,
stitch_generator,thread_manager}.py, src/machine/machine_library.py,
src/{main,main_pipeline}.py, src/raster/{bitmap_tracer,
color_quantizer,raster_converter}.py, src/segmentation/{edge_snap,
mapper,mode_router}.py, src/service/{config.py,handlers/{export,
threads}.py}, src/svg_parser/{parser,text_renderer}.py. 80 +/120 -.

Mark added 1 commit 2026-09-12 04:41:40 +00:00

ci(forgejo): install libgl1 + add httpx for test collection ... 6b859f55d8

After the container override lands, pytest collection fails on every
test that imports fastapi.testclient (needs httpx) or that imports
src/main_pipeline.py (opencv-python needs libGL.so.1 / libglib2.0-0).

- requirements.txt: add httpx==0.28.1 (test dep, was missing).
- ci.yml: add an 'Install system dependencies' step to typecheck, test,
  test-slow, and test-matrix that apt-installs libgl1 + libglib2.0-0.

Lint job doesn't need either (only formats checks), so the step is
deliberately scoped to the jobs that import cv2 or fastapi.testclient.

Known remaining failures after this patch (out of scope for direct-fix):
- mypy reports 11 type errors across 6 src/ files (real source bugs
  needing source review; not infra gaps). Filed as Mark/easystitch#130.
- Some test_collection errors may persist for tests that import other
  transitively-missing modules; needs investigation after libgl1 lands.

Mark added 1 commit 2026-09-12 04:56:09 +00:00

fix(types): resolve mypy errors blocking CI typecheck ... 8cbfc5415c

Six src/ files had assignment/type-mismatch errors that the CI typecheck
job (mypy src/ --ignore-missing-imports) failed on, in addition to the
infra gaps already patched. Apply minimal, surgical fixes that match
the existing intent:

- svg_parser/parser.py:647-650: rect_elem.get() default was int (0);
  Element.get expects str. Pass "0" so _to_float() receives a string.
- segmentation/saliency.py:33: cv2.resize() return was inferred as
  ndarray[dtype[number]] but mypy's bidirectional inference expects
  float64 (because gray starts as .astype(np.float64)). Append an
  explicit .astype(np.float64) on the resize line so the inferred type
  stays float64.
- segmentation/gradient_detect.py:77, mode_router.py:170,194:
  tuple(map(int, ndarray)) is inferred as tuple[Any, ...] but the
  function signature requires tuple[int, int, int]. Wrap in cast().
- main_pipeline.py:853: _generate_stitches_from_paths returns
  tuple[list, list[int]], but the caller assigned it to a single
  'stitches' name and then reassigned to apply_pull_compensation's
  list[Any]. Unpack the tuple so 'stitches' is a list.
- service/handlers/digitize.py:350: getattr(..., None) is
  'Any | None' but the annotation was list[dict]. Pull the getattr
  into a local, check None, then bind to events: list[dict].

Mark added 1 commit 2026-09-12 05:48:31 +00:00

ci(matrix): narrow to Python 3.11/3.12 (scikit-image pin blocks 3.9/3.10) ... bd6b71ce38

scikit-image==0.26.0 (pinned in requirements.txt) has no wheels for
Python 3.9 or 3.10 — pip install fails with 'No matching distribution
found for scikit-image==0.26.0', causing those matrix jobs to error at
the Install dependencies step before any test runs.

The repo's pyproject.toml still advertises requires-python = '>=3.9',
so this is purely a CI-coverage reduction, not a runtime claim. The
minimum supported runtime should be re-evaluated separately (either
bump scikit-image to a version with 3.9/3.10 wheels, or lower
requires-python to 3.11+).

Mark merged commit 3baebcfd5c into main 2026-09-12 06:21:02 +00:00

Mark referenced this pull request from a commit 2026-09-12 06:21:03 +00:00

Merge pull request 'ci(forgejo): pin each job to catthehacker/ubuntu:act-22.04' (#129) from wt/t_b9f42e72 into main

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

blocked:children

  

blocked:depends-101

Depends on Mark/easystitch#101 landing first.

  

blocked:depends-103

Depends on corresponding issue landing first.

  

blocked:depends-104

Depends on corresponding issue landing first.

  

blocked:needs-attention

Session stuck or abandoned, needs human review

  

blocked:needs-decision

  

blocked:no-changes

  

blocked:preflight

Held by kilo-gsd preflight until lint-cleanup lands

  

bug

Something is not working correctly

  

chore

Config/cleanup items (reporter lane)

  

feature-request

  

in-progress

Claimed by kilo-gsd pipeline

  

lint-cleanup

Repo-wide lint cleanup ticket — kilo-gsd preflight hard-gate

  

needs-decompose

  

performance

  

quality

  

quickfix

  

security/medium

Medium severity security issue

  

triage-approved

Triage: approved for fixer pipeline

No labels

blocked:children

blocked:depends-101

blocked:depends-103

blocked:depends-104

blocked:needs-attention

blocked:needs-decision

blocked:no-changes

blocked:preflight

bug

chore

feature-request

in-progress

lint-cleanup

needs-decompose

performance

quality

quickfix

security/medium

triage-approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Mark/easystitch!129

No description provided.