Mark/Kimi_Agent_Brother_10_Digitizing_App
1
0
Fork 0
Code Issues 14 Pull requests Projects Releases Packages Wiki Activity Actions

follow-up: verify #23 fix (multipart) against live browser end-to-end test #23

New issue
Closed
opened 2026-07-12 23:17:39 +00:00 by Mark · 4 comments
Mark commented 2026-07-12 23:17:39 +00:00
Owner
Copy link

Verified by QA task t_ec1232b4:

  • Fix commits 0a74a67, 774e0c0, 8da6c17 all on origin/main
  • 197/197 unit tests pass (all affected suites green)
  • Already verified live on 2026-07-12; no regressions from stacked patches

Closing as confirmed verified.

Verified by QA task t_ec1232b4: - Fix commits 0a74a67, 774e0c0, 8da6c17 all on origin/main - 197/197 unit tests pass (all affected suites green) - Already verified live on 2026-07-12; no regressions from stacked patches Closing as confirmed verified.
Mark commented 2026-07-12 23:18:48 +00:00
Author
Owner
Copy link

Auto-triage: needs decompose

Marked triage-approved + needs-decompose. decompose-executor will pick this up and break it into implementable sub-issues.

## Auto-triage: needs decompose Marked `triage-approved` + `needs-decompose`. decompose-executor will pick this up and break it into implementable sub-issues.
Mark commented 2026-07-12 23:25:54 +00:00
Author
Owner
Copy link

Fixed in commit 0a74a67 (local, not pushed yet).

digitize() in src/lib/easystitch-client.ts now sends multipart/form-data with the raw blob as the image file part and a JSON-stringified payload as the settings part — exactly matching the OpenAPI Body_digitize_endpoint_v1_digitize_post schema.

Public signature is unchanged so callers (useWorkspace.ts, test mocks) need no edits.

Verification

Test Before After
npm test -- --run 196 / 196 ✅ but mocks fetch 197 / 197 ✅, with new live-integration test gated on VITE_EASYSTITCH_INTEGRATION=1
Live curl through Vite proxy 422 (JSON body) 200, 600 stitches, red tatami fill

The new digitize() happy path: sends multipart with image file part and JSON-stringified settings test asserts:

  • Content-Type: multipart/form-data; boundary=…
  • both name="image" and name="settings" field names
  • the raw image bytes between the image part headers and the closing boundary

It explicitly does NOT encode to base64.

Push?

Not pushed. Local commit on main ahead of origin by 1. Ready when you say so.

**Fixed in commit 0a74a67** (local, not pushed yet). `digitize()` in `src/lib/easystitch-client.ts` now sends multipart/form-data with the raw blob as the `image` file part and a JSON-stringified payload as the `settings` part — exactly matching the OpenAPI `Body_digitize_endpoint_v1_digitize_post` schema. Public signature is unchanged so callers (`useWorkspace.ts`, test mocks) need no edits. ### Verification | Test | Before | After | |---|---|---| | `npm test -- --run` | 196 / 196 ✅ but mocks fetch | **197 / 197** ✅, with new live-integration test gated on `VITE_EASYSTITCH_INTEGRATION=1` | | Live curl through Vite proxy | 422 (JSON body) | **200**, 600 stitches, red tatami fill | The new `digitize() happy path: sends multipart with image file part and JSON-stringified settings` test asserts: - `Content-Type: multipart/form-data; boundary=…` - both `name="image"` and `name="settings"` field names - the raw image bytes between the image part headers and the closing boundary It explicitly does NOT encode to base64. ### Push? Not pushed. Local commit on `main` ahead of origin by 1. Ready when you say so.
Mark commented 2026-07-12 23:46:04 +00:00
Author
Owner
Copy link

Follow-up: while running end-to-end Playwright tests to verify this fix, I discovered that the first 422 a user sees after my fix is still in place — it's a SECOND bug. Filed as #26 (maxColors default of 13 exceeds service cap of 10). This surfaces only with real browser automation; my Python multipart verifier happened to use max_colors: 4 which dodged it.

The multipart fix is correct, but the live UI still 422s on default settings. Until #26 is fixed, this fix alone is insufficient to make the UI round-trip successfully.

Workaround in the meantime: edit digitize-adapters.ts:40-44 to clamp at 10.

**Follow-up**: while running end-to-end Playwright tests to verify this fix, I discovered that the first 422 a user sees after my fix is still in place — it's a SECOND bug. Filed as #26 (maxColors default of 13 exceeds service cap of 10). This surfaces only with real browser automation; my Python multipart verifier happened to use `max_colors: 4` which dodged it. The multipart fix is correct, but the live UI still 422s on default settings. Until #26 is fixed, this fix alone is insufficient to make the UI round-trip successfully. Workaround in the meantime: edit `digitize-adapters.ts:40-44` to clamp at 10.
Mark commented 2026-07-13 00:05:49 +00:00
Author
Owner
Copy link

Update — fix is now end-to-end working after #26 (maxColors) and a follow-up bug (#27, null paletteIndex) were patched.

Live-browser verification just now:

  1. Open http://localhost:5173/workspace
  2. Upload SVG
  3. Click Auto-Digitize FAB
  4. Service log: POST /v1/digitize HTTP/1.1" 200 OK — engines parses, returns 600 stitches
  5. UI shows "simple.svg uploaded successfully", NO error toast
  6. Canvas rendered pixel content (data:image/png;base64,iVBORw…)

Four issues remain in flight but unrelated to the multipart fix itself: #24, #25, #27 (filed today), #28 (filed today).

**Update — fix is now end-to-end working** after #26 (maxColors) and a follow-up bug (#27, null paletteIndex) were patched. Live-browser verification just now: 1. Open http://localhost:5173/workspace 2. Upload SVG 3. Click Auto-Digitize FAB 4. Service log: `POST /v1/digitize HTTP/1.1" 200 OK` — engines parses, returns 600 stitches 5. UI shows "simple.svg uploaded successfully", NO error toast 6. Canvas rendered pixel content (data:image/png;base64,iVBORw…) Four issues remain in flight but unrelated to the multipart fix itself: #24, #25, #27 (filed today), #28 (filed today).
Mark changed title from Frontend digitize() sends JSON body, backend expects multipart — every actual upload 422s to follow-up: verify #23 fix (multipart) against live browser end-to-end test 2026-07-13 23:17:44 +00:00
Mark closed this issue 2026-07-16 05:26:53 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
blocked:commit-ready-failed

   
blocked:gate-fetch

   
blocked:gate-lint

   
blocked:gate-plan

   
blocked:gate-research

   
blocked:needs-attention

Worker halted; needs human/janitor inspection

  
blocked:needs-decision

   
blocked:needs-human

   
blocked:no-changes

   
blocked:verify-failed

   
bug

   
deferred

   
feature-request

   
in-progress

   
needs-decompose

   
needs-triage

   
quickfix

   
security/medium

   
triage-approved
No labels
blocked:commit-ready-failed
blocked:gate-fetch
blocked:gate-lint
blocked:gate-plan
blocked:gate-research
blocked:needs-attention
blocked:needs-decision
blocked:needs-human
blocked:no-changes
blocked:verify-failed
bug
deferred
feature-request
in-progress
needs-decompose
needs-triage
quickfix
security/medium
triage-approved
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Mark/Kimi_Agent_Brother_10_Digitizing_App#23
No description provided.