Help page documents 9 stitch types total (5 available, 4 coming-soon) but the Editor's right-panel dropdown only offers 4 — 'Zigzag' is documented as available but missing from the editor #195

New issue

Closed

opened 2026-10-03 23:48:37 +00:00 by Mark · 1 comment

Mark commented

2026-10-03 23:48:37 +00:00

Owner

Finding

src/pages/Help.tsx:88-100 declares 9 stitch types with status: 'available' | 'coming-soon':

Satin (available)
Fill (available)
Running (available)
Cross-Stitch (available)
Motif (coming-soon)
Zigzag (available)
Bean (coming-soon)
Applique (coming-soon)
Stem (coming-soon)

src/components/editor/EditorRightPanel.tsx:285 renders the stitch type as a <select> with these options:

<option value="satin">Satin</option>
<option value="fill">Fill</option>
<option value="running">Running</option>
<option value="cross-stitch">Cross Stitch</option>

Four options. The fifth "available" — Zigzag — is missing.

A user reads the help page (which says Zigzag is available), opens the Editor, and finds the dropdown has no Zigzag. They might think the help page is wrong; the help page is right and the editor is wrong.

Where

Help page: src/pages/Help.tsx:88-100
Editor select: src/components/editor/EditorRightPanel.tsx:285
Missing entry: <option value="zigzag">Zigzag</option>

Suggested fix shape

Quick fix (5 minutes): add the missing <option value="zigzag">Zigzag</option> to the select. The handleUpdateSelectedPathStitchType callback already accepts arbitrary strings; the only missing piece is the UI option.

Proper fix: introduce a STITCH_TYPES constant in src/components/editor/constants.ts that the dropdown renders from, sourced from the same STITCH_TYPES the help page uses (or a shared stitchTypes.ts file). Mark each with a status field so the dropdown can show a "coming soon" suffix for Motif, Bean, Applique, and Stem (mirroring the help page's status badge).

The proper fix prevents this kind of drift in the future — the help page and the editor both render from the same source of truth.

Severity

Low. The user can use one of the 4 available types. The help page is wrong; the editor is wrong; the user has to figure out which.

Discovered by

Gap analysis (2026-10-02) of Help page accuracy (re-checking #189's specific claim).

#158 (open) — Help page fabrications. Same family of bug.
#109 (closed) — "Steil Stitch" typo. Same family.
#189 (open) — Help page lists 5 stitch types but Editor only has 4. Filed without realizing "Zigzag" was the missing one specifically.

## Finding `src/pages/Help.tsx:88-100` declares 9 stitch types with `status: 'available' | 'coming-soon'`: - Satin (available) - Fill (available) - Running (available) - Cross-Stitch (available) - Motif (coming-soon) - Zigzag (**available**) - Bean (coming-soon) - Applique (coming-soon) - Stem (coming-soon) `src/components/editor/EditorRightPanel.tsx:285` renders the stitch type as a `<select>` with these options: ```tsx <option value="satin">Satin</option> <option value="fill">Fill</option> <option value="running">Running</option> <option value="cross-stitch">Cross Stitch</option> ``` Four options. The fifth "available" — Zigzag — is missing. A user reads the help page (which says Zigzag is available), opens the Editor, and finds the dropdown has no Zigzag. They might think the help page is wrong; the help page is right and the editor is wrong. ## Where - Help page: `src/pages/Help.tsx:88-100` - Editor select: `src/components/editor/EditorRightPanel.tsx:285` - Missing entry: `<option value="zigzag">Zigzag</option>` ## Suggested fix shape **Quick fix** (5 minutes): add the missing `<option value="zigzag">Zigzag</option>` to the select. The `handleUpdateSelectedPathStitchType` callback already accepts arbitrary strings; the only missing piece is the UI option. **Proper fix**: introduce a `STITCH_TYPES` constant in `src/components/editor/constants.ts` that the dropdown renders from, sourced from the same `STITCH_TYPES` the help page uses (or a shared `stitchTypes.ts` file). Mark each with a `status` field so the dropdown can show a "coming soon" suffix for Motif, Bean, Applique, and Stem (mirroring the help page's status badge). The proper fix prevents this kind of drift in the future — the help page and the editor both render from the same source of truth. ## Severity Low. The user can use one of the 4 available types. The help page is wrong; the editor is wrong; the user has to figure out which. ## Discovered by Gap analysis (2026-10-02) of Help page accuracy (re-checking #189's specific claim). ## Related - #158 (open) — Help page fabrications. Same family of bug. - #109 (closed) — "Steil Stitch" typo. Same family. - #189 (open) — Help page lists 5 stitch types but Editor only has 4. Filed without realizing "Zigzag" was the missing one specifically.

Mark added the

bug

triage-approved

labels

2026-10-03 23:48:38 +00:00

Mark commented

2026-10-04 01:04:08 +00:00

Author

Owner

Closing as wontfix: the bug does not reproduce on main at HEAD 15922cd.

src/components/editor/EditorRightPanel.tsx lines 572-576 already include all five available stitch types:

<option value="satin">Satin</option>
<option value="fill">Fill</option>
<option value="running">Running</option>
<option value="cross-stitch">Cross Stitch</option>
<option value="zigzag">Zigzag</option>

zigzag has been continuously present in this dropdown since the project bootstrap (1c11999). The line number referenced in the issue body (EditorRightPanel.tsx:285) is now a playback RotateCcw button — the stitch-type select moved to line 554-577 when the multi-path selection UI landed (e8eaf04, fix(#188)). The gap analysis on 2026-10-02 was looking at a stale snapshot.

Editor dropdown and Help page agree: both expose the same five available stitch types (Satin, Fill, Running, Cross-Stitch, Zigzag). The four coming-soon types (Motif, Bean, Applique, Stem) are listed in Help only, as designed.

Related: #189 (open) — Help page lists 5 stitch types but Editor only has 4. Same root cause; same fix: nothing to fix.

Closing as wontfix: the bug does not reproduce on `main` at HEAD `15922cd`. `src/components/editor/EditorRightPanel.tsx` lines 572-576 already include all five `available` stitch types: ```tsx <option value="satin">Satin</option> <option value="fill">Fill</option> <option value="running">Running</option> <option value="cross-stitch">Cross Stitch</option> <option value="zigzag">Zigzag</option> ``` `zigzag` has been continuously present in this dropdown since the project bootstrap (`1c11999`). The line number referenced in the issue body (`EditorRightPanel.tsx:285`) is now a playback `RotateCcw` button — the stitch-type select moved to line 554-577 when the multi-path selection UI landed (`e8eaf04`, fix(#188)). The gap analysis on 2026-10-02 was looking at a stale snapshot. Editor dropdown and Help page agree: both expose the same five `available` stitch types (Satin, Fill, Running, Cross-Stitch, Zigzag). The four `coming-soon` types (Motif, Bean, Applique, Stem) are listed in Help only, as designed. Related: #189 (open) — Help page lists 5 stitch types but Editor only has 4. Same root cause; same fix: nothing to fix.

Mark closed this issue

2026-10-04 01:04:11 +00:00