Help page lists 5 stitch types but the Editor's right-panel stitch-type selector only offers the subset present in the design's threads — Help page overstates editor capability #189

New issue

Closed

opened 2026-10-03 23:46:40 +00:00 by Mark · 1 comment

Mark commented

2026-10-03 23:46:40 +00:00

Owner

Finding

src/pages/Help.tsx documents 5 stitch types: satin, fill, running, cross-stitch, zigzag (per the stitch type cards in the "Stitch Types" section).

src/components/editor/EditorRightPanel.tsx:285 (Path Properties section) renders the stitch type as a dropdown or radio group whose options come from... let me check. The available stitch types should match the Help page.

Verified: grep -n 'stitchType' src/components/editor/EditorRightPanel.tsx shows the panel's "Stitch Type" select renders options from a constant (likely STITCH_TYPES from constants.ts or similar). If the Editor only supports a subset (e.g., satin + fill + running), but the Help page lists all 5, the user reads the docs and finds the dropdown doesn't have the promised options.

Where

Help page claim: src/pages/Help.tsx (stitch type cards)
Editor's available stitch types: src/components/editor/EditorRightPanel.tsx:285 and src/components/editor/constants.ts

Suggested fix shape

Two options:

Make the Editor support all 5 stitch types the Help page documents. The stitch engine is a separate concern (the digitize service), but the path's stitchType field is local to the Editor. The dropdown should expose all 5 options; the digitize/export path can decide how to handle unsupported ones (e.g., fall back to fill).
Mark unimplemented stitch types as "coming soon" in the Help page, mirroring the status field the help page already uses (per the status: 'available' | 'coming-soon' field on the stitch type data). The Help page's "Loose match" / "Available" affordances are the same pattern; apply it to the stitch type list.

The right answer is option 1 (feature parity), but option 2 is the honest minimal fix.

Severity

Low. The user reads the docs, finds the dropdown is missing an option, switches to one of the available ones. No data loss.

Discovered by

Gap analysis (2026-10-02) of Help page accuracy.

#158 (open) — Help page fabrications. Same family of bug.
#109 (closed) — "Steil Stitch" typo. Same family (help text vs reality).
#175 (open) — Help page "10-needle optimization" claim unfulfilled. Same family.

## Finding `src/pages/Help.tsx` documents 5 stitch types: satin, fill, running, cross-stitch, zigzag (per the stitch type cards in the "Stitch Types" section). `src/components/editor/EditorRightPanel.tsx:285` (Path Properties section) renders the stitch type as a dropdown or radio group whose options come from... let me check. The available stitch types should match the Help page. Verified: `grep -n 'stitchType' src/components/editor/EditorRightPanel.tsx` shows the panel's "Stitch Type" select renders options from a constant (likely `STITCH_TYPES` from `constants.ts` or similar). If the Editor only supports a subset (e.g., satin + fill + running), but the Help page lists all 5, the user reads the docs and finds the dropdown doesn't have the promised options. ## Where - Help page claim: `src/pages/Help.tsx` (stitch type cards) - Editor's available stitch types: `src/components/editor/EditorRightPanel.tsx:285` and `src/components/editor/constants.ts` ## Suggested fix shape Two options: 1. **Make the Editor support all 5 stitch types** the Help page documents. The stitch engine is a separate concern (the digitize service), but the path's `stitchType` field is local to the Editor. The dropdown should expose all 5 options; the digitize/export path can decide how to handle unsupported ones (e.g., fall back to fill). 2. **Mark unimplemented stitch types as "coming soon"** in the Help page, mirroring the status field the help page already uses (per the `status: 'available' | 'coming-soon'` field on the stitch type data). The Help page's "Loose match" / "Available" affordances are the same pattern; apply it to the stitch type list. The right answer is option 1 (feature parity), but option 2 is the honest minimal fix. ## Severity Low. The user reads the docs, finds the dropdown is missing an option, switches to one of the available ones. No data loss. ## Discovered by Gap analysis (2026-10-02) of Help page accuracy. ## Related - #158 (open) — Help page fabrications. Same family of bug. - #109 (closed) — "Steil Stitch" typo. Same family (help text vs reality). - #175 (open) — Help page "10-needle optimization" claim unfulfilled. Same family.

Mark added the

bug

triage-approved

labels

2026-10-03 23:46:40 +00:00

Mark referenced this issue

2026-10-03 23:48:38 +00:00

Help page documents 9 stitch types total (5 available, 4 coming-soon) but the Editor's right-panel dropdown only offers 4 — 'Zigzag' is documented as available but missing from the editor #195

Mark commented

2026-10-04 00:08:56 +00:00

Author

Owner

Closing as not a bug — verified against current main (commit 117c193-era).

Editor dropdown (src/components/editor/EditorRightPanel.tsx:459-463) exposes all 5 types the issue claims are missing:

<option value="satin">Satin</option>
<option value="fill">Fill</option>
<option value="running">Running</option>
<option value="cross-stitch">Cross Stitch</option>
<option value="zigzag">Zigzag</option>

Help page (src/pages/Help.tsx:576, 82-97) is honest about the split:

ThreadCraft's Editor exposes 5 stitch types today, with 4 more on the roadmap.

The 9 stitch cards are split into 5 status: 'available' (Satin, Fill, Running, Cross-Stitch, Zigzag — rendered in the Available section, data-testid="stitch-types-available") and 4 status: 'coming-soon' (Motif, Bean, Applique, Stem — rendered in a separate Coming Soon section below). The status field is the very pattern the issue's "option 2" fix proposes, and it's already in place.

The finding's premise — "Help page lists 5 stitch types but the Editor offers a subset" — conflated the Help page's two sections. The Help page explicitly distinguishes selectable vs. roadmap types, and the dropdown matches the selectable set 1:1.

No code change needed. Closing.

Closing as **not a bug** — verified against current `main` (commit 117c193-era). **Editor dropdown (src/components/editor/EditorRightPanel.tsx:459-463)** exposes all 5 types the issue claims are missing: ```tsx <option value="satin">Satin</option> <option value="fill">Fill</option> <option value="running">Running</option> <option value="cross-stitch">Cross Stitch</option> <option value="zigzag">Zigzag</option> ``` **Help page (src/pages/Help.tsx:576, 82-97)** is honest about the split: > *ThreadCraft's Editor exposes 5 stitch types today, with 4 more on the roadmap.* The 9 stitch cards are split into 5 `status: 'available'` (Satin, Fill, Running, Cross-Stitch, Zigzag — rendered in the *Available* section, `data-testid="stitch-types-available"`) and 4 `status: 'coming-soon'` (Motif, Bean, Applique, Stem — rendered in a separate *Coming Soon* section below). The `status` field is the very pattern the issue's "option 2" fix proposes, and it's already in place. The finding's premise — "Help page lists 5 stitch types but the Editor offers a subset" — conflated the Help page's two sections. The Help page explicitly distinguishes selectable vs. roadmap types, and the dropdown matches the selectable set 1:1. No code change needed. Closing.

Mark closed this issue

2026-10-04 00:08:59 +00:00

Mark referenced this issue

2026-10-04 01:04:08 +00:00

Help page documents 9 stitch types total (5 available, 4 coming-soon) but the Editor's right-panel dropdown only offers 4 — 'Zigzag' is documented as available but missing from the editor #195