Gallery upload accept list excludes BMP that the Help page claims is supported (.pes,.dst,.png,.jpg,.jpeg,.svg — no .bmp); Workspace accepts BMP but Gallery doesn't #148

New issue

Closed

opened 2026-10-03 05:45:14 +00:00 by Mark · 1 comment

Mark commented 2026-10-03 05:45:14 +00:00

Owner

Copy link

Finding

The Gallery's Upload Design file picker accepts only 6 file extensions (.pes, .dst, .png, .jpg, .jpeg, .svg). The Help page's Compatibility FAQ at src/pages/Help.tsx:122 claims:

"ThreadCraft supports PNG, JPG, JPEG, BMP, and SVG files."

BMP is missing from the Gallery's accept list. A user following the Help page's instruction to upload a BMP file will be unable to select one in the file picker (most browsers honor the accept attribute as a filter). The picker only allows the 6 types listed above; BMP is silently excluded.

The Workspace's upload area (CanvasArea) DOES include BMP in its accept attribute (accept="image/png,image/jpeg,image/svg+xml,image/bmp"). So the user can upload a BMP to the Workspace for digitizing, but cannot upload one to the Gallery for archival.

Where

• Gallery accept: src/pages/Gallery.tsx:493 — accept=".pes,.dst,.png,.jpg,.jpeg,.svg"
• Help page claim: src/pages/Help.tsx:122
• Workspace accept (the right shape): src/components/workspace/CanvasArea.tsx:333 — accept="image/png,image/jpeg,image/svg+xml,image/bmp"

Suggested fix shape

Add .bmp to the Gallery's accept list:

-              accept=".pes,.dst,.png,.jpg,.jpeg,.svg"
+              accept=".pes,.dst,.png,.jpg,.jpeg,.svg,.bmp"

Verify the resulting accept string passes validation in the file picker; modern browsers honor .bmp as a valid extension hint. Also: confirm that designFromFile and parseDesignFile (the post-upload pipeline) handle BMP without errors — if either crashes, the upload silently fails even though the picker now shows BMP files.

Severity

Medium. The Help page makes a product claim the Gallery picker can't honor. A user trying to follow the instructions is left confused.

Discovered by

Gap analysis (2026-10-02) of upload affordances.

Related

• #131 (closed) — parseDesignFile's SVG and PDF parsers were made honest. BMP is the inverse: the parser likely works, but the UI never lets the user try.

## Finding The Gallery's Upload Design file picker accepts only 6 file extensions (`.pes`, `.dst`, `.png`, `.jpg`, `.jpeg`, `.svg`). The Help page's Compatibility FAQ at `src/pages/Help.tsx:122` claims: > "ThreadCraft supports PNG, JPG, JPEG, BMP, and SVG files." **BMP is missing from the Gallery's accept list.** A user following the Help page's instruction to upload a BMP file will be unable to select one in the file picker (most browsers honor the `accept` attribute as a filter). The picker only allows the 6 types listed above; BMP is silently excluded. The Workspace's upload area (CanvasArea) DOES include BMP in its accept attribute (`accept="image/png,image/jpeg,image/svg+xml,image/bmp"`). So the user can upload a BMP to the Workspace for digitizing, but cannot upload one to the Gallery for archival. ## Where - Gallery accept: `src/pages/Gallery.tsx:493` — `accept=".pes,.dst,.png,.jpg,.jpeg,.svg"` - Help page claim: `src/pages/Help.tsx:122` - Workspace accept (the right shape): `src/components/workspace/CanvasArea.tsx:333` — `accept="image/png,image/jpeg,image/svg+xml,image/bmp"` ## Suggested fix shape Add `.bmp` to the Gallery's accept list: ```diff - accept=".pes,.dst,.png,.jpg,.jpeg,.svg" + accept=".pes,.dst,.png,.jpg,.jpeg,.svg,.bmp" ``` Verify the resulting accept string passes validation in the file picker; modern browsers honor `.bmp` as a valid extension hint. Also: confirm that `designFromFile` and `parseDesignFile` (the post-upload pipeline) handle BMP without errors — if either crashes, the upload silently fails even though the picker now shows BMP files. ## Severity Medium. The Help page makes a product claim the Gallery picker can't honor. A user trying to follow the instructions is left confused. ## Discovered by Gap analysis (2026-10-02) of upload affordances. ## Related - #131 (closed) — parseDesignFile's SVG and PDF parsers were made honest. BMP is the inverse: the parser likely works, but the UI never lets the user try.

Mark added the

bug

triage-approved

labels 2026-10-03 05:45:14 +00:00

Mark referenced this issue from a commit 2026-10-03 06:32:42 +00:00

fix(#148): add .bmp to Gallery upload accept list (Help page advertises BMP)

Mark commented 2026-10-03 06:33:00 +00:00

Author

Owner

Copy link

Fixed in commit c2beef8 (rebased to c2beef8 on origin/main): added .bmp to the Gallery's Upload Design picker accept list at src/pages/Gallery.tsx:496. Help page claim now matches the picker. Post-upload pipeline (designFromFile → parseDesignFile) already documented BMP as a supported image type (parseDesignFile.ts:8), so the picker now correctly offers what the rest of the system already accepts. Lint clean, 52/52 Gallery + Help + gallery-component tests pass.

Fixed in commit c2beef8 (rebased to c2beef8 on origin/main): added `.bmp` to the Gallery's Upload Design picker accept list at `src/pages/Gallery.tsx:496`. Help page claim now matches the picker. Post-upload pipeline (`designFromFile` → `parseDesignFile`) already documented BMP as a supported image type (parseDesignFile.ts:8), so the picker now correctly offers what the rest of the system already accepts. Lint clean, 52/52 Gallery + Help + gallery-component tests pass.

Mark closed this issue 2026-10-03 06:33:07 +00:00

Mark referenced this issue 2026-10-03 23:20:48 +00:00

Workspace has no clipboard paste support — user can drag/drop or click to browse, but can't paste an image from another app #186

Mark referenced this issue 2026-10-03 23:50:14 +00:00

Gallery has no drag-and-drop design import — only the 'Upload' button (click to open file picker) is available; the workspace dropzone is the only surface that supports drag-and-drop #197

Mark referenced this issue 2026-10-04 02:11:02 +00:00

Workspace has no empty state for 'no image uploaded' — the canvas is just blank with no prompt, and the right panel's Object List shows the same 'No paths loaded' generic text #226

Mark referenced this issue 2026-10-04 02:16:26 +00:00

Gallery's filter (search, sort, folder, favorites-only) doesn't survive a page refresh — user with a long search query and a specific folder has to re-enter the filter every time #232

Mark referenced this issue 2026-10-04 02:32:09 +00:00

Gallery folders have no drag-reorder affordance — folders appear in fixed insertion order, user with 8 folders in a non-ideal order has to delete and recreate them to reorder #235

Mark referenced this issue 2026-10-04 02:38:00 +00:00

Editor has no reference image backdrop — user tracing a hand-drawn sketch on the canvas has no way to load the sketch as a backdrop, the editor canvas is always blank (or shows the path being drawn) #245

Mark referenced this issue 2026-10-04 03:43:03 +00:00

Editor has no way to import a SVG file as editable paths — user with an SVG file (e.g., a logo) on their disk wants to bring it in as vector paths, can only screenshot and re-digitize via the workspace #283

Mark referenced this issue 2026-10-04 03:49:23 +00:00

Editor has no 'save as preset' for the current design as a template — user wanting to reuse the layout (e.g., a quilt block) for a new design has to start from scratch, no template library #307

Mark referenced this issue 2026-10-04 03:49:45 +00:00

Editor's session restore (per #161) restores the editor's state from sessionStorage, but the gallery designs list is in localStorage — user with a stale localStorage (e.g., cleared it) gets a 'design not found' error in the editor with no graceful re… #309

Mark referenced this issue 2026-10-04 03:50:03 +00:00

Gallery has no 'tag' system for designs — user wanting to group designs by project (e.g., 'logo', 'birthday', 'wedding') can only use folders (one folder per design) or favorites (binary), no multi-tag #310

Mark referenced this issue 2026-10-04 03:50:22 +00:00

Gallery has no 'sort' within a folder (e.g., by name, by stitch count) — user with 30 designs in one folder can only see the default order, no way to sort by date edited or stitches #312

Sign in to join this conversation.

No Branch/Tag specified

Branches Tags

main

No results found.

Labels

Clear labels   

blocked:commit-ready-failed

  

blocked:gate-fetch

  

blocked:gate-lint

  

blocked:gate-plan

  

blocked:gate-research

  

blocked:needs-attention

Worker halted; needs human/janitor inspection

  

blocked:needs-decision

  

blocked:needs-human

  

blocked:no-changes

  

blocked:verify-failed

  

bug

  

deferred

  

feature-request

  

in-progress

  

needs-decompose

  

needs-triage

  

quickfix

  

security/medium

  

triage-approved

No labels

blocked:commit-ready-failed

blocked:gate-fetch

blocked:gate-lint

blocked:gate-plan

blocked:gate-research

blocked:needs-attention

blocked:needs-decision

blocked:needs-human

blocked:no-changes

blocked:verify-failed

bug

deferred

feature-request

in-progress

needs-decompose

needs-triage

quickfix

security/medium

triage-approved

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

Mark/Kimi_Agent_Brother_10_Digitizing_App#148

No description provided.