Editor "Export PES" button is hardcoded to PES — service also supports DST, EXP, JEF (per #129) but Editor offers no format selector #142

New issue

Closed

opened 2026-10-03 04:07:30 +00:00 by Mark · 1 comment

Mark commented

2026-10-03 04:07:30 +00:00

Owner

Finding

The Editor's "Export PES" button (src/components/editor/EditorHeader.tsx:84-110) is hardcoded to PES. The handleExport function (src/pages/Editor.tsx:545-560 or similar) calls exportPES with format: 'pes' directly. The service supports PES, DST, EXP, JEF (per #129).

A user editing a design in the Editor cannot export to any format other than PES without leaving the Editor and going to the Workspace's export dialog.

Where

Button: src/components/editor/EditorHeader.tsx:84-110 — text says "Export PES" and there is no format selector
Handler: src/pages/Editor.tsx — handleExport passes format: 'pes' to exportPES
Workspace's export dialog already offers the multi-format picker (post #129 fix); the Editor does not

Suggested fix shape

Add a format selector to the Editor header, similar to the Workspace's export dialog. Two approaches:

Inline dropdown in the EditorHeader: replace the "Export PES" button with a <select> (PES / DST / EXP / JEF) plus an "Export" button. Smaller change, no new dialog component.
Open the Workspace's ExportDialog from the Editor: navigate to /workspace?export=open&format=...&design=... and have the Workspace's dialog respect the query params. Bigger change but reuses existing UI.

Option 1 is the smaller change. The editor's handleExport already accepts a format string; the only addition is the dropdown.

Also: rename the button from "Export PES" to "Export" since it's no longer format-specific.

Severity

Medium. The user is in the editor refining their design; clicking "Export PES" is a familiar action. The surprise is when they realize they can't export to a different format from the same place they're editing.

Discovered by

Gap analysis (2026-10-02) of editor export flow.

#129 (open) — adds EXP/JEF to the export format list. This issue covers the Editor side of the same change; the Editor's button needs the same treatment the Workspace's dialog will get.

## Finding The Editor's "Export PES" button (`src/components/editor/EditorHeader.tsx:84-110`) is hardcoded to PES. The handleExport function (`src/pages/Editor.tsx:545-560` or similar) calls `exportPES` with `format: 'pes'` directly. The service supports PES, DST, EXP, JEF (per #129). A user editing a design in the Editor cannot export to any format other than PES without leaving the Editor and going to the Workspace's export dialog. ## Where - Button: `src/components/editor/EditorHeader.tsx:84-110` — text says "Export PES" and there is no format selector - Handler: `src/pages/Editor.tsx` — `handleExport` passes `format: 'pes'` to `exportPES` - Workspace's export dialog already offers the multi-format picker (post #129 fix); the Editor does not ## Suggested fix shape Add a format selector to the Editor header, similar to the Workspace's export dialog. Two approaches: 1. **Inline dropdown in the EditorHeader**: replace the "Export PES" button with a `<select>` (PES / DST / EXP / JEF) plus an "Export" button. Smaller change, no new dialog component. 2. **Open the Workspace's ExportDialog** from the Editor: navigate to `/workspace?export=open&format=...&design=...` and have the Workspace's dialog respect the query params. Bigger change but reuses existing UI. Option 1 is the smaller change. The editor's `handleExport` already accepts a format string; the only addition is the dropdown. Also: rename the button from "Export PES" to "Export" since it's no longer format-specific. ## Severity Medium. The user is in the editor refining their design; clicking "Export PES" is a familiar action. The surprise is when they realize they can't export to a different format from the same place they're editing. ## Discovered by Gap analysis (2026-10-02) of editor export flow. ## Related - #129 (open) — adds EXP/JEF to the export format list. This issue covers the Editor side of the same change; the Editor's button needs the same treatment the Workspace's dialog will get.

Mark added the

feature-request

triage-approved

labels

2026-10-03 04:07:31 +00:00

Mark referenced this issue from a commit

2026-10-03 05:36:48 +00:00

fix(#142): rename Editor header 'Export PES' to 'Export'

Mark commented

2026-10-03 05:37:51 +00:00

Author

Owner

Closed in commit ddd820f on main.

Re-reading the issue before fixing: the Editor's handleExport (src/pages/Editor.tsx:507-509) does NOT call exportPES with format: "pes" — it calls setExportDialogOpen(true), which opens the same ExportDialog component the Workspace uses (Editor.tsx:603-617). That dialog already offers the full 4-format picker (PES / DST / EXP / JEF, post #129).

So Approach 2 from the issue ("open the Workspace's ExportDialog from the Editor") is already implemented. Approach 1 (inline dropdown in the Editor header) would create a second format selector on top of the one inside the dialog — redundant.

The actual UX gap is that the button label lies: it says "Export PES" but clicking it opens a multi-format picker. Renamed to "Export" (matching AppHeader / Workspace).

Diff: src/components/editor/EditorHeader.tsx — 1 string change (Export PES → Export) + a comment explaining the flow.

Side note: Help.tsx:75 still tells users to "click 'Export PES'" with text implying PES-only output. Same mismatch but out of scope for this issue.

Closed in commit ddd820f on main. **Re-reading the issue before fixing:** the Editor's `handleExport` (src/pages/Editor.tsx:507-509) does NOT call `exportPES` with `format: "pes"` — it calls `setExportDialogOpen(true)`, which opens the same `ExportDialog` component the Workspace uses (Editor.tsx:603-617). That dialog already offers the full 4-format picker (PES / DST / EXP / JEF, post #129). So Approach 2 from the issue ("open the Workspace's ExportDialog from the Editor") is already implemented. Approach 1 (inline dropdown in the Editor header) would create a second format selector on top of the one inside the dialog — redundant. The actual UX gap is that the **button label lies**: it says "Export PES" but clicking it opens a multi-format picker. Renamed to "Export" (matching AppHeader / Workspace). Diff: src/components/editor/EditorHeader.tsx — 1 string change (`Export PES` → `Export`) + a comment explaining the flow. Side note: Help.tsx:75 still tells users to "click 'Export PES'" with text implying PES-only output. Same mismatch but out of scope for this issue.

Mark closed this issue

2026-10-03 05:37:57 +00:00

Mark referenced this issue

2026-10-03 23:59:32 +00:00

Editor has no way to load a design back to the workspace for re-digitization — user edits a design, must navigate Gallery → Workspace → Re-Digitize to fix issues #207