Mark/Kimi_Agent_Brother_10_Digitizing_App
1
0
Fork 0
Code Issues 14 Pull requests Projects Releases Packages Wiki Activity Actions

Auto-Digitize Settings panel is half-wired: detail 422s the service, underlay is silently dropped, error messages hide the cause #115

New issue
Closed
opened 2026-09-30 01:43:56 +00:00 by Mark · 1 comment
Mark commented 2026-09-30 01:43:56 +00:00
Owner
Copy link

Superseded by #116, #117, #118. Splitting this umbrella into three focused issues for independent triage and regression coverage. Original analysis remains accurate; this issue just aggregates three distinct root causes.

  • #116 — detail stitch preference 422s the service (front-end / back-end literal mismatch)
  • #117 — underlay toggle silently dropped before the request
  • #118 — 422 error messages hide FastAPI body.detail from the user
Superseded by #116, #117, #118. Splitting this umbrella into three focused issues for independent triage and regression coverage. Original analysis remains accurate; this issue just aggregates three distinct root causes. - **#116** — `detail` stitch preference 422s the service (front-end / back-end literal mismatch) - **#117** — `underlay` toggle silently dropped before the request - **#118** — 422 error messages hide FastAPI `body.detail` from the user
Mark 2026-09-30 01:43:56 +00:00
Mark commented 2026-09-30 01:57:55 +00:00
Author
Owner
Copy link

Closed via two-repo fix (commits on main):

Mark/Kimi_Agent_Brother_10_Digitizing_App — commit 2b2f630

  • mapStitchPreference(): UI detail → service quality so the Detail preference no longer 422s.
  • toServiceSettings(): includes underlay so the workspace Underlay toggle reaches the service.
  • AutoDigitizeSettings type: stitch-preference literal set corrected; new optional underlay field.
  • readErrorBody(): now reads FastAPI's detail (string OR RequestValidationError array). The previously opaque easystitch-service responded 422 now surfaces the actual field-level cause (e.g. stitchPreference: Input should be ... quality).
  • Tests: replaced the obsolete 'passes detail through' assertion; new readErrorBody describe block covers the FastAPI envelope (string detail, validation-error array, message/error fallbacks, non-JSON).

Mark/easystitch-service — commit e452c59

  • DigitizeSettings: accepts underlay: bool | None = None as a forward-compatible wire field (same pattern as fabric / targetStitchCount in #31). Engine-side consumption is deferred; the wire field is accepted now so the front-end control has a real effect the moment the engine adopts it.
  • New test: test_digitize_accepts_underlay_field — verifies on/off payloads both 200 and reach the runner.

Verification

  • Front-end: pnpm test — 376/376 pass. pnpm lint clean.
  • Back-end: pytest tests/ — 159/159 pass. ruff check clean.
  • Both CI runs on Forgejo Actions: green.
Closed via two-repo fix (commits on `main`): **`Mark/Kimi_Agent_Brother_10_Digitizing_App`** — commit `2b2f630` - `mapStitchPreference()`: UI `detail` → service `quality` so the Detail preference no longer 422s. - `toServiceSettings()`: includes `underlay` so the workspace Underlay toggle reaches the service. - `AutoDigitizeSettings` type: stitch-preference literal set corrected; new optional `underlay` field. - `readErrorBody()`: now reads FastAPI's `detail` (string OR `RequestValidationError` array). The previously opaque `easystitch-service responded 422` now surfaces the actual field-level cause (e.g. `stitchPreference: Input should be ... quality`). - Tests: replaced the obsolete 'passes detail through' assertion; new `readErrorBody` describe block covers the FastAPI envelope (string detail, validation-error array, message/error fallbacks, non-JSON). **`Mark/easystitch-service`** — commit `e452c59` - `DigitizeSettings`: accepts `underlay: bool | None = None` as a forward-compatible wire field (same pattern as `fabric` / `targetStitchCount` in #31). Engine-side consumption is deferred; the wire field is accepted now so the front-end control has a real effect the moment the engine adopts it. - New test: `test_digitize_accepts_underlay_field` — verifies on/off payloads both 200 and reach the runner. **Verification** - Front-end: `pnpm test` — 376/376 pass. `pnpm lint` clean. - Back-end: `pytest tests/` — 159/159 pass. `ruff check` clean. - Both CI runs on Forgejo Actions: green.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
blocked:commit-ready-failed

   
blocked:gate-fetch

   
blocked:gate-lint

   
blocked:gate-plan

   
blocked:gate-research

   
blocked:needs-attention

Worker halted; needs human/janitor inspection

  
blocked:needs-decision

   
blocked:needs-human

   
blocked:no-changes

   
blocked:verify-failed

   
bug

   
deferred

   
feature-request

   
in-progress

   
needs-decompose

   
needs-triage

   
quickfix

   
security/medium

   
triage-approved
No labels
blocked:commit-ready-failed
blocked:gate-fetch
blocked:gate-lint
blocked:gate-plan
blocked:gate-research
blocked:needs-attention
blocked:needs-decision
blocked:needs-human
blocked:no-changes
blocked:verify-failed
bug
deferred
feature-request
in-progress
needs-decompose
needs-triage
quickfix
security/medium
triage-approved
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Mark/Kimi_Agent_Brother_10_Digitizing_App#115
No description provided.