AuWoMe/forgeflow
2
0
Fork 0
Code Issues 2 Pull requests Projects Releases Packages Wiki Activity Actions

kilo-gsd.py:1177 still runs plain git commit — wire hermes-git-commit wrapper #29

New issue
Open
opened 2026-09-18 23:25:45 +00:00 by Mark · 1 comment
Mark commented 2026-09-18 23:25:45 +00:00
Owner
Copy link

Parent-Issue: #24

Layer 2 of #24 remains unaddressed: ~/.hermes/scripts/kilo-gsd.py:1177 (and mirrors at ~/Projects/hermes-config/scripts/kilo-gsd.py:1475 and ~/Projects/hermes-scripts/scripts/kilo-gsd.py:1061) executes git commit -m ... directly via subprocess.run. The pre-commit re-staging-loop wrapper installed by #23/26 (~/.hermes/bin/hermes-git-commit) is therefore never invoked by kilo-gsd.

Fix: replace the git commit subprocess.run call with one that invokes the wrapper when present (PATH lookup, fallback to git commit if missing). Apply identically to the dev copy under ~/Projects/hermes-scripts/ and the config copy under ~/Projects/hermes-config/. quickfix-kilo also delegates the commit to the model and needs the same wrapper shim.

Acceptance: grep on ~/.hermes/scripts/kilo-gsd.py shows the wrapper invocation; a forced hook loop on a test commit exits 0 instead of cycling. Closes #24 Layer 2.

**Parent-Issue:** #24 Layer 2 of #24 remains unaddressed: `~/.hermes/scripts/kilo-gsd.py:1177` (and mirrors at `~/Projects/hermes-config/scripts/kilo-gsd.py:1475` and `~/Projects/hermes-scripts/scripts/kilo-gsd.py:1061`) executes `git commit -m ...` directly via subprocess.run. The pre-commit re-staging-loop wrapper installed by #23/26 (`~/.hermes/bin/hermes-git-commit`) is therefore never invoked by kilo-gsd. Fix: replace the `git commit` subprocess.run call with one that invokes the wrapper when present (PATH lookup, fallback to `git commit` if missing). Apply identically to the dev copy under `~/Projects/hermes-scripts/` and the config copy under `~/Projects/hermes-config/`. quickfix-kilo also delegates the commit to the model and needs the same wrapper shim. Acceptance: grep on `~/.hermes/scripts/kilo-gsd.py` shows the wrapper invocation; a forced hook loop on a test commit exits 0 instead of cycling. Closes #24 Layer 2.
Mark commented 2026-09-25 02:52:35 +00:00
Author
Owner
Copy link

⚠️ Auto-dedup: this issue looks like a duplicate of #28 (title similarity 100%). Skipping kanban card creation. Please close this one as duplicate or merge into #28 if they're the same root cause.

⚠️ Auto-dedup: this issue looks like a duplicate of [#28](https://forgejo.tail018ac4.ts.net/AuWoMe/forgeflow/issues/28) (title similarity 100%). Skipping kanban card creation. Please close this one as duplicate or merge into #28 if they're the same root cause.
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
blocked:needs-attention

Manually blocked — needs human attention

  
blocked:needs-decision

   
bug

Functional defect — incorrect behavior, regression, or unmet expectation

  
chore

Config / cleanup / hygiene item, no functional behavior change

  
in-progress

Currently being worked by an agent

  
quickfix

Small, low-risk, spec-aligned — opencode fast-path

  
security/high

High severity security issue

  
triage-approved

Approved by triage — eligible for the issue-fixer pipeline

No labels
blocked:needs-attention
blocked:needs-decision
bug
chore
in-progress
quickfix
security/high
triage-approved
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
AuWoMe/forgeflow#29
No description provided.