kilo-gsd.py:1177 still runs plain git commit — wire hermes-git-commit wrapper #28

New issue

Open

opened 2026-09-18 23:25:30 +00:00 by Mark · 1 comment

Mark commented

2026-09-18 23:25:30 +00:00

Owner

Parent-Issue: #24

Layer 2 of #24 remains unaddressed: ~/.hermes/scripts/kilo-gsd.py:1177 (and mirrors at ~/Projects/hermes-config/scripts/kilo-gsd.py:1475 and ~/Projects/hermes-scripts/scripts/kilo-gsd.py:1061) executes git commit -m ... directly via subprocess.run. The pre-commit re-staging-loop wrapper installed by #23/26 (~/.hermes/bin/hermes-git-commit) is therefore never invoked by kilo-gsd.

Fix: replace the git commit subprocess.run call with one that invokes the wrapper when present (PATH lookup, fallback to git commit if missing). Apply identically to the dev copy under ~/Projects/hermes-scripts/ and the config copy under ~/Projects/hermes-config/. quickfix-kilo also delegates the commit to the model and needs the same wrapper shim.

Acceptance: grep on ~/.hermes/scripts/kilo-gsd.py shows the wrapper invocation; a forced hook loop on a test commit exits 0 instead of cycling. Closes #24 Layer 2.

**Parent-Issue:** #24 Layer 2 of #24 remains unaddressed: `~/.hermes/scripts/kilo-gsd.py:1177` (and mirrors at `~/Projects/hermes-config/scripts/kilo-gsd.py:1475` and `~/Projects/hermes-scripts/scripts/kilo-gsd.py:1061`) executes `git commit -m ...` directly via subprocess.run. The pre-commit re-staging-loop wrapper installed by #23/26 (`~/.hermes/bin/hermes-git-commit`) is therefore never invoked by kilo-gsd. Fix: replace the `git commit` subprocess.run call with one that invokes the wrapper when present (PATH lookup, fallback to `git commit` if missing). Apply identically to the dev copy under `~/Projects/hermes-scripts/` and the config copy under `~/Projects/hermes-config/`. quickfix-kilo also delegates the commit to the model and needs the same wrapper shim. Acceptance: grep on `~/.hermes/scripts/kilo-gsd.py` shows the wrapper invocation; a forced hook loop on a test commit exits 0 instead of cycling. Closes #24 Layer 2.

Mark added the

triage-approved

bug

labels

2026-09-18 23:25:45 +00:00

Mark referenced this issue

2026-09-25 02:52:35 +00:00

kilo-gsd.py:1177 still runs plain git commit — wire hermes-git-commit wrapper #29

Mark commented

2026-09-25 02:52:35 +00:00

Author

Owner

⚠️ Auto-dedup: this issue looks like a duplicate of #29 (title similarity 100%). Skipping kanban card creation. Please close this one as duplicate or merge into #29 if they're the same root cause.

⚠️ Auto-dedup: this issue looks like a duplicate of [#29](https://forgejo.tail018ac4.ts.net/AuWoMe/forgeflow/issues/29) (title similarity 100%). Skipping kanban card creation. Please close this one as duplicate or merge into #29 if they're the same root cause.