Right panel: Stitch Parameters accordion does nothing when no stitch object is selected #56

New issue

Closed

opened 2026-09-02 01:51:15 +00:00 by Mark · 0 comments

Mark commented

2026-09-02 01:51:15 +00:00

Owner

Bug

In the Workspace right panel, clicking the Stitch Parameters section header has no visible effect unless a stitch object is already selected. The toggle flips its internal state, but the panel never expands and no content is shown — leaving the user with a button that appears broken.

Reproduction

Open Workspace, upload an image, run Auto-Digitize, click Confirm & Edit.
With nothing selected (no stitch object highlighted in Object List), click the Stitch Parameters header in the right panel.
Observe: nothing expands. The section stays visually flat.
Click any other section (Design Settings, Thread Colors, Object List) — those expand correctly.
Click a stitch object in the Object List — Stitch Parameters still does not expand.

Observed

Stitch Parameters toggle: clicking does nothing visible.
Design Settings, Thread Colors, Object List all expand correctly when their headers are clicked.
Confirmed by accessibility snapshot: after clicking Stitch Parameters, no children appear between the Stitch Parameters button and the next section (Thread Colors).

Root cause

src/components/workspace/RightPanel.tsx line 208:

<Collapsible
  title="Stitch Parameters"
  icon={<Layers size={14} />}
  open={openSections.stitch && !!selectedObject}   // ← gated on selection
  onToggle={() => toggleSection('stitch')}
>

The open prop is openSections.stitch && !!selectedObject. The toggle flips openSections.stitch but open short-circuits back to false whenever no object is selected, so the section is rendered as closed regardless of how many times the user clicks. The placeholder text "Select a stitch object to edit parameters" (line 277) is only shown when selectedObject exists but is inside a Collapsible that is itself collapsed, so it never appears.

Expected

The accordion should expand on click even when no object is selected. When expanded with no selection, it should show a helpful empty-state: "Select a stitch object in the Object List to edit its parameters." This gives the user feedback that the button works and tells them what to do.

Severity

Medium. The button appears completely broken; users think the panel is broken.

## Bug In the Workspace right panel, clicking the **Stitch Parameters** section header has no visible effect unless a stitch object is already selected. The toggle flips its internal state, but the panel never expands and no content is shown — leaving the user with a button that appears broken. ## Reproduction 1. Open Workspace, upload an image, run Auto-Digitize, click Confirm & Edit. 2. With nothing selected (no stitch object highlighted in Object List), click the **Stitch Parameters** header in the right panel. 3. Observe: nothing expands. The section stays visually flat. 4. Click any other section (Design Settings, Thread Colors, Object List) — those expand correctly. 5. Click a stitch object in the Object List — Stitch Parameters still does not expand. ## Observed - Stitch Parameters toggle: clicking does nothing visible. - Design Settings, Thread Colors, Object List all expand correctly when their headers are clicked. - Confirmed by accessibility snapshot: after clicking Stitch Parameters, no children appear between the Stitch Parameters button and the next section (Thread Colors). ## Root cause `src/components/workspace/RightPanel.tsx` line 208: ```tsx <Collapsible title="Stitch Parameters" icon={<Layers size={14} />} open={openSections.stitch && !!selectedObject} // ← gated on selection onToggle={() => toggleSection('stitch')} > ``` The `open` prop is `openSections.stitch && !!selectedObject`. The toggle flips `openSections.stitch` but `open` short-circuits back to `false` whenever no object is selected, so the section is rendered as closed regardless of how many times the user clicks. The placeholder text "Select a stitch object to edit parameters" (line 277) is only shown when `selectedObject` exists but is inside a Collapsible that is itself collapsed, so it never appears. ## Expected The accordion should expand on click even when no object is selected. When expanded with no selection, it should show a helpful empty-state: "Select a stitch object in the Object List to edit its parameters." This gives the user feedback that the button works and tells them what to do. ## Severity Medium. The button appears completely broken; users think the panel is broken.