Error message keys in strings.json do not match config_flow.py #6

New issue

Closed

opened 2026-05-11 06:15:05 +00:00 by Mark · 0 comments

Mark commented

2026-05-11 06:15:05 +00:00

Owner

Summary

strings.json defines specific error keys that are never used by the config flow validation code:

invalid_url_schema_override_rest_url (defined in strings.json but not in code)
invalid_url_schema_override_mqtt_url (defined in strings.json but not in code)

The config flow uses the generic key "invalid_url" for both REST and MQTT URL validation errors:

errors[CONF_OVERRIDE_REST_URL] = "invalid_url"
errors[CONF_OVERRIDE_MQTT_URL] = "invalid_url"

Impact

The more descriptive error messages in strings.json are never displayed to users.
Users see generic "Invalid URL" regardless of which URL field has the problem.

Suggested fix

Change config_flow.py to use the specific keys matching strings.json, for example:

errors[CONF_OVERRIDE_REST_URL] = "invalid_url_schema_override_rest_url"
errors[CONF_OVERRIDE_MQTT_URL] = "invalid_url_schema_override_mqtt_url"

Or alternately, remove the unused keys from strings.json.

## Summary strings.json defines specific error keys that are never used by the config flow validation code: - `invalid_url_schema_override_rest_url` (defined in strings.json but not in code) - `invalid_url_schema_override_mqtt_url` (defined in strings.json but not in code) The config flow uses the generic key `"invalid_url"` for both REST and MQTT URL validation errors: ```python errors[CONF_OVERRIDE_REST_URL] = "invalid_url" errors[CONF_OVERRIDE_MQTT_URL] = "invalid_url" ``` ## Impact - The more descriptive error messages in strings.json are never displayed to users. - Users see generic "Invalid URL" regardless of which URL field has the problem. ## Suggested fix Change config_flow.py to use the specific keys matching strings.json, for example: - `errors[CONF_OVERRIDE_REST_URL] = "invalid_url_schema_override_rest_url"` - `errors[CONF_OVERRIDE_MQTT_URL] = "invalid_url_schema_override_mqtt_url"` Or alternately, remove the unused keys from strings.json.