Constants duplicated between const.py and yeedi_auth.py #4

New issue

Closed

opened 2026-05-11 06:14:37 +00:00 by Mark · 0 comments

Mark commented

2026-05-11 06:14:37 +00:00

Owner

Summary

Several constants (app keys, secrets, API paths, app metadata) are defined in two places — yeedi/const.py and yeedi/yeedi_auth.py — with different names and no shared imports. The const.py versions are never imported by any module, making them dead code.

Duplicated values

Purpose	`const.py`	`yeedi_auth.py`
Login app key	`AUTH_USERLOGIN_AUTH_APPKEY_YD`	`_YEEDI_CLIENT_KEY`
Login secret	`AUTH_USERLOGIN_SECRET_YD`	`_YEEDI_CLIENT_SECRET`
Auth code app key	`AUTH_GETAUTH_AUTH_APPKEY_YD`	`_YEEDI_AUTH_CLIENT_KEY`
Auth code secret	`AUTH_GETAUTH_SECRET_YD`	`_YEEDI_AUTH_CLIENT_SECRET`
App code	`YEEDI_APP_CODE`	`_YEEDI_APP_CODE`
App version	`YEEDI_APP_VERSION`	`_YEEDI_APP_VERSION`
Device type	`YEEDI_DEVICE_TYPE`	`_YEEDI_DEVICE_TYPE`
Channel	`YEEDI_CHANNEL`	`_YEEDI_CHANNEL`
UI paths	`PATH_USER_LOGIN`, etc.	`_USER_LOGIN_PATH_FORMAT`, etc.
Org values	`YEEDI_ORG_WW`, `YEEDI_ORG_CN`	`_ORG_WW`, `_ORG_CN`

Suggested fix

Remove unused constants from const.py OR
Refactor yeedi_auth.py to import from const.py instead of redefining

## Summary Several constants (app keys, secrets, API paths, app metadata) are defined in two places — `yeedi/const.py` and `yeedi/yeedi_auth.py` — with different names and no shared imports. The `const.py` versions are never imported by any module, making them dead code. ## Duplicated values | Purpose | `const.py` | `yeedi_auth.py` | |---------|-----------|----------------| | Login app key | `AUTH_USERLOGIN_AUTH_APPKEY_YD` | `_YEEDI_CLIENT_KEY` | | Login secret | `AUTH_USERLOGIN_SECRET_YD` | `_YEEDI_CLIENT_SECRET` | | Auth code app key | `AUTH_GETAUTH_AUTH_APPKEY_YD` | `_YEEDI_AUTH_CLIENT_KEY` | | Auth code secret | `AUTH_GETAUTH_SECRET_YD` | `_YEEDI_AUTH_CLIENT_SECRET` | | App code | `YEEDI_APP_CODE` | `_YEEDI_APP_CODE` | | App version | `YEEDI_APP_VERSION` | `_YEEDI_APP_VERSION` | | Device type | `YEEDI_DEVICE_TYPE` | `_YEEDI_DEVICE_TYPE` | | Channel | `YEEDI_CHANNEL` | `_YEEDI_CHANNEL` | | UI paths | `PATH_USER_LOGIN`, etc. | `_USER_LOGIN_PATH_FORMAT`, etc. | | Org values | `YEEDI_ORG_WW`, `YEEDI_ORG_CN` | `_ORG_WW`, `_ORG_CN` | ## Suggested fix - Remove unused constants from `const.py` OR - Refactor `yeedi_auth.py` to import from `const.py` instead of redefining