CI: Lint and format checks silently pass despite failures #7

New issue

Closed

opened 2026-05-09 05:18:44 +00:00 by Mark · 1 comment

Mark commented

2026-05-09 05:18:44 +00:00

Owner

Severity: Low

The CI workflow at .forgejo/workflows/ci.yml appends || true to both black --check and flake8 commands, which means lint/format failures are always masked and CI never fails on them.

- name: Check code formatting
  run: |
    pip install black
    black --check vikunja_cli/ vikunjatool/ tests/ || true  # <-- ignores failures

- name: Check linting
  run: |
    pip install flake8
    flake8 vikunja_cli/ vikunjatool/ tests/ --max-line-length=100 || true  # <-- ignores failures

Impact: Code quality degrades silently. Formatting and lint issues can be introduced without CI flagging them.

Fix: Remove || true from these steps. If there are existing violations, fix them or create a baseline. Consider also:

Adding a lint step that actually reports failures (not just formatting)
Adding ruff as a faster alternative to flake8
Running lint/format checks before tests so they fail fast

**Severity: Low** The CI workflow at `.forgejo/workflows/ci.yml` appends `|| true` to both `black --check` and `flake8` commands, which means lint/format failures are always masked and CI never fails on them. ```yaml - name: Check code formatting run: | pip install black black --check vikunja_cli/ vikunjatool/ tests/ || true # <-- ignores failures - name: Check linting run: | pip install flake8 flake8 vikunja_cli/ vikunjatool/ tests/ --max-line-length=100 || true # <-- ignores failures ``` **Impact:** Code quality degrades silently. Formatting and lint issues can be introduced without CI flagging them. **Fix:** Remove `|| true` from these steps. If there are existing violations, fix them or create a baseline. Consider also: - Adding a lint step that actually reports failures (not just formatting) - Adding `ruff` as a faster alternative to flake8 - Running lint/format checks before tests so they fail fast