Mark/test-pipeline
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

Add pre-commit hooks to test-pipeline #1

New issue
Closed
opened 2026-06-04 00:37:11 +00:00 by Mark · 2 comments
Mark commented 2026-06-04 00:37:11 +00:00
Owner
Copy link

Repository test-pipeline does not have pre-commit hooks configured. Evaluate the repo's language/tooling and add appropriate hooks (.pre-commit-config.yaml for Python, lefthook.yml for Node, or .githooks/pre-commit for simpler repos).

Repository `test-pipeline` does not have pre-commit hooks configured. Evaluate the repo's language/tooling and add appropriate hooks (`.pre-commit-config.yaml` for Python, `lefthook.yml` for Node, or `.githooks/pre-commit` for simpler repos).
Mark commented 2026-06-07 02:49:52 +00:00
Author
Owner
Copy link

⏸ Needs Decision

What needs to be decided?

  • Is this issue still relevant? If yes, remove the blocked:needs-decision label to route back to triage.

Blocking factors:

  • Didn't meet auto-approve criteria — scope=small, risk=low, spec=partial

Scope: small Risk: low Spec: partial Type: chore
Summary: Add pre-commit hooks to standardize code quality checks in the test-pipeline repository.
Suggestion: This is already implemented — .pre-commit-config.yaml exists with hooks (trailing-whitespace, end-of-file-fixer, check-yaml, check-added-large-files, detect-private-key, check-merge-conflict), the git hook is installed, and test-precommit-hooks.sh validates everything. No action needed.
Rationale: Repo is a shell-based pipeline test bed (no AGENTS.md/CONTEXT.md, no source code beyond README.md and test script). The pre-commit setup is already in place — config file, installed hook, and test harness all exist. Issue scope is a single config file (~10 lines), purely additive with zero risk to existing paths. Partial spec alignment because no AGENTS.md exists to compare against, but it fits the project's testing theme.

To unblock: Remove the blocked:needs-decision label. The triage will apply the appropriate outcome based on your choice above.

## ⏸ Needs Decision **What needs to be decided?** - **Is this issue still relevant?** If yes, remove the `blocked:needs-decision` label to route back to triage. **Blocking factors:** - **Didn't meet auto-approve criteria** — scope=small, risk=low, spec=partial --- **Scope:** small **Risk:** low **Spec:** partial **Type:** chore **Summary:** Add pre-commit hooks to standardize code quality checks in the test-pipeline repository. **Suggestion:** This is already implemented — .pre-commit-config.yaml exists with hooks (trailing-whitespace, end-of-file-fixer, check-yaml, check-added-large-files, detect-private-key, check-merge-conflict), the git hook is installed, and test-precommit-hooks.sh validates everything. No action needed. **Rationale:** Repo is a shell-based pipeline test bed (no AGENTS.md/CONTEXT.md, no source code beyond README.md and test script). The pre-commit setup is already in place — config file, installed hook, and test harness all exist. Issue scope is a single config file (~10 lines), purely additive with zero risk to existing paths. Partial spec alignment because no AGENTS.md exists to compare against, but it fits the project's testing theme. **To unblock:** Remove the `blocked:needs-decision` label. The triage will apply the appropriate outcome based on your choice above.
Mark commented 2026-09-14 16:16:54 +00:00
Author
Owner
Copy link

Closed by operator: pre-commit hooks are already shipped on origin/main.

  • .pre-commit-config.yaml added in 9ecf4d2 ("Add .pre-commit-config.yaml with standard hooks", 2026-06-06) — covers trailing-whitespace, end-of-file-fixer, check-yaml, check-added-large-files, detect-private-key, check-merge-conflict.
  • test-precommit-hooks.sh added in 55a3471 ("Add integration test for pre-commit hooks", 2026-06-06) — verifies the config exists, the .git/hooks/pre-commit symlink is installed, and pre-commit run --all-files exits 0.

Verified locally on origin/main: bash test-precommit-hooks.sh passes (PASS/PASS/PASS).

§7 stale closure pattern: fix landed pre-claim, close step never fired.

Closed by operator: pre-commit hooks are already shipped on `origin/main`. - `.pre-commit-config.yaml` added in `9ecf4d2` ("Add .pre-commit-config.yaml with standard hooks", 2026-06-06) — covers trailing-whitespace, end-of-file-fixer, check-yaml, check-added-large-files, detect-private-key, check-merge-conflict. - `test-precommit-hooks.sh` added in `55a3471` ("Add integration test for pre-commit hooks", 2026-06-06) — verifies the config exists, the `.git/hooks/pre-commit` symlink is installed, and `pre-commit run --all-files` exits 0. Verified locally on `origin/main`: `bash test-precommit-hooks.sh` passes (PASS/PASS/PASS). §7 stale closure pattern: fix landed pre-claim, close step never fired.
Mark closed this issue 2026-09-14 16:17:28 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
No results found.
Labels
Clear labels   
blocked:needs-decision

   
enhancement

New feature or request

  
quickfix

Small scoped fix for quick pipeline

  
triage-approved
No labels
blocked:needs-decision
enhancement
quickfix
triage-approved
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
Mark/test-pipeline#1
No description provided.