[LOW] Log JSON parse/read errors with file path - distinguish missing DB from corrupt JSON #39

New issue

Closed

opened 2026-06-09 00:03:13 +00:00 by Mark · 0 comments

Mark commented

2026-06-09 00:03:13 +00:00

Owner

Location: backend/src/database.ts:287-292

Problem: catch { return [] } silently swallows all parse/read errors. Data corruption silently becomes an empty result.

Impact: Hard to debug production issues; silent data loss.

Fix:

catch (err) {
  const msg = err instanceof Error ? err.message : String(err);
  if (err.code === "ENOENT") {
    logger.info(`DB file missing, starting fresh: ${path}`);
    return [];
  }
  logger.error(`Corrupt JSON in ${path}: ${msg}`);
  throw err;
}

Effort: ~20 mins

**Location:** `backend/src/database.ts:287-292` **Problem:** `catch { return [] }` silently swallows all parse/read errors. Data corruption silently becomes an empty result. **Impact:** Hard to debug production issues; silent data loss. **Fix:** ```ts catch (err) { const msg = err instanceof Error ? err.message : String(err); if (err.code === "ENOENT") { logger.info(`DB file missing, starting fresh: ${path}`); return []; } logger.error(`Corrupt JSON in ${path}: ${msg}`); throw err; } ``` **Effort:** ~20 mins