LOW: Missing frontend API client for GET /api/news/:id and GET /api/pricing/:id endpoints #16

New issue

Closed

opened 2026-05-09 00:03:27 +00:00 by Mark · 1 comment

Mark commented

2026-05-09 00:03:27 +00:00

Owner

Severity: Low

Location

src/lib/api.ts lines 104–117

Description

The backend defines these endpoints:

GET /api/news/:id — get single news item
GET /api/pricing/:id — get single pricing entry

But the frontend API client only exposes:

pricingApi.getAll() — missing getById
newsApi.getAll() — missing getById

While the frontend currently doesn't use individual detail views, the endpoints exist but are unreachable from the frontend.

Impact

Incomplete API coverage in the frontend client
If detail views are added in the future, the API methods will need to be added

Suggested Fix

Add the missing methods:

export const pricingApi = {
  getAll: (): Promise<PricingEntry[]> => fetchApi('/pricing'),
  getById: (id: string): Promise<PricingEntry> => fetchApi(`/pricing/${id}`),
};

export const newsApi = {
  getAll: (): Promise<NewsItem[]> => fetchApi('/news'),
  getById: (id: string): Promise<NewsItem> => fetchApi(`/news/${id}`),
};

(Note: newsApi.getById is already missing from the current code; pricingApi.getById is also not exposed)

## Severity: Low ## Location `src/lib/api.ts` lines 104–117 ## Description The backend defines these endpoints: - `GET /api/news/:id` — get single news item - `GET /api/pricing/:id` — get single pricing entry But the frontend API client only exposes: - `pricingApi.getAll()` — missing `getById` - `newsApi.getAll()` — missing `getById` While the frontend currently doesn't use individual detail views, the endpoints exist but are unreachable from the frontend. ## Impact - Incomplete API coverage in the frontend client - If detail views are added in the future, the API methods will need to be added ## Suggested Fix Add the missing methods: ```typescript export const pricingApi = { getAll: (): Promise<PricingEntry[]> => fetchApi('/pricing'), getById: (id: string): Promise<PricingEntry> => fetchApi(`/pricing/${id}`), }; export const newsApi = { getAll: (): Promise<NewsItem[]> => fetchApi('/news'), getById: (id: string): Promise<NewsItem> => fetchApi(`/news/${id}`), }; ``` (Note: `newsApi.getById` is already missing from the current code; `pricingApi.getById` is also not exposed)

Mark added the

feature-request

label

2026-05-12 23:26:37 +00:00

Mark added

blocked:verify-failed

and removed

feature-request

labels

2026-05-17 04:10:58 +00:00

Mark commented

2026-05-17 08:42:22 +00:00

Author

Owner

GSD VERIFY phase failed after 3 attempts.
Conformance failure: Unexpected files modified: src/lib/api.ts; Expected files not modified: /home/b/Projects/subvault/src/lib/api.ts

GSD VERIFY phase failed after 3 attempts. Conformance failure: Unexpected files modified: src/lib/api.ts; Expected files not modified: /home/b/Projects/subvault/src/lib/api.ts

Mark removed the

blocked:verify-failed

label

2026-05-18 22:15:42 +00:00

Mark added the

quickfix

label

2026-05-20 23:03:59 +00:00

Mark

2026-05-26 08:12:53 +00:00