Extended match_conditions: operators, logic combinators, conditional branches #14
Labels
No labels
blocked:needs-decision
bug
chore
cron
design
in-progress
infra
milestone
module-o
needs-decompose
needs-research
ops-task
pm
quickfix
security/medium
triage-approved
vikunja
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference
Mark/org_mode#14
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Summary
Current
match_conditionsis flatfield == valueonly — one operator, implicit AND, single script per trigger. Cannot express:title starts with "Decompose:")labels contains "research")repo already mapped?)Required
Operators
Beyond
equals:not_equalsstarts_with,ends_with,containsexists,not_existsin(set membership)matches(regex)Logic combinators
and(implicit today, make explicit)ornotand: [{or: [...]}, {not: {equals: ...}}]Conditional branches
One trigger defining multiple execution paths:
This kills the pattern of N unconditional triggers all firing on every
issues.openedand relying on worker scripts to self-filter.Motivation
Three current triggers (
research-on-issue-opened,decompose-on-issue-opened,onboard-on-issue-opened) fire unconditionally because match_conditions literally cannot express their required predicates. Fixing the filter system moves routing logic back to the trigger layer where it belongs.⏸ Needs Decision
Blocking factors:
Scope: medium Risk: medium Spec: aligned Type: enhancement
Summary: Extends match_conditions with operators (starts_with, contains, regex, etc.), explicit logic combinators (AND/OR/NOT plus nested trees), and conditional branching (if/then/else within a single trigger) so routing logic lives at the trigger layer instead of worker scripts.
Suggestion: Implement backward-compatibly: (1) keep old
{field: val}as implicit eq-AND — zero breakage. (2) Build a composableConditionEvaluatorthat converts a condition tree into callable predicates with operator dispatch. (3) For branching, embed branch → script mappings inside the conditions JSON field, and havematch_triggersdynamically settrigger['script']to the matched branch's script so the caller (action_chain.py) is unchanged. (4) Wire up in_check_conditions/match_triggersin automation_registry.py only — the schema (JSON TEXT column) needs no migration. (5) Test with the three unconditional triggers (research/decompose/onboard) as validation.Rationale: SCOPE=medium: operators+combinators are a pure code change in one method (~100-150 lines of predicate evaluation), but branching requires changing how match_triggers populates the
scriptfield on returned trigger dicts, and tests are substantial. Affects <10 files but one core dispatch path. RISK=medium: this is the routing decision core — bugs mean wrong scripts fire or missed triggers — but the change is additive (old syntax preserved) and branch embedding keeps the caller contract unchanged. SPEC=aligned: the design-spec explicitly calls for local predicates on content tags and labels, and the issue eliminates unconditional triggers that the spec already identifies as undesirable.Action: Review each blocking factor above. Remove
blocked:needs-decisionlabel to route back to triage.🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry🤖 [
quickfix-org_mode-14] still working — overseer retry